Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contains usage in GH Actions to unbreak deploys #1795

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

roryabraham
Copy link
Contributor

Broken workflow run: https://github.com/Expensify/Expensify.cash/actions/runs/658590878
Proper example of "contains" usage:

image

@roryabraham roryabraham requested a review from AndrewGable March 16, 2021 18:33
@roryabraham roryabraham self-assigned this Mar 16, 2021
@roryabraham roryabraham requested a review from a team as a code owner March 16, 2021 18:33
@botify botify requested review from MariaHCD and removed request for a team March 16, 2021 18:33
@AndrewGable AndrewGable removed the request for review from MariaHCD March 16, 2021 18:38
@AndrewGable
Copy link
Contributor

Merging to un block deploys!

@AndrewGable AndrewGable merged commit c256ccc into master Mar 16, 2021
@AndrewGable AndrewGable deleted the Rory-FixStringArgInContains branch March 16, 2021 18:38
@botify
Copy link

botify commented Mar 16, 2021

@AndrewGable looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants