Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new emojiReaction data format #17996

Merged
merged 83 commits into from
Jul 20, 2023
Merged

Support new emojiReaction data format #17996

merged 83 commits into from
Jul 20, 2023

Commits on Apr 25, 2023

  1. Create a separate collection for reactions

    @tgolen
    tgolen committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    46f1cca View commit details
    Browse the repository at this point in the history

  2. Call the new toggle method

    @tgolen
    tgolen committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f5de44f View commit details
    Browse the repository at this point in the history

  3. Display reactions in new format

    @tgolen
    tgolen committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a7945e9 View commit details
    Browse the repository at this point in the history

  4. Make sure toggling reactions works locally in onyx

    @tgolen
    tgolen committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1b9f15f View commit details
    Browse the repository at this point in the history

  5. Fix a few references to user account IDs and clean up code

    @tgolen
    tgolen committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    af0fed2 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Protect against report actions that don't have any reactions yet

    @tgolen
    tgolen committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    b805586 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Turn on API requests

    @tgolen
    tgolen committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4d70bbd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7698ad0 View commit details
    Browse the repository at this point in the history

  3. Simplify the reaction data

    @tgolen
    tgolen committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    8aacb9f View commit details
    Browse the repository at this point in the history

  4. Use the updated data structure

    @tgolen
    tgolen committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    cf4a396 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5d0808b View commit details
    Browse the repository at this point in the history

  2. style

    @tgolen
    tgolen committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f88e62c View commit details
    Browse the repository at this point in the history

  3. style

    @tgolen
    tgolen committed May 11, 2023
    Configuration menu
    Copy the full SHA
    ea49f29 View commit details
    Browse the repository at this point in the history

  4. Get new emoji reactions displaying properly

    @tgolen
    tgolen committed May 11, 2023
    Configuration menu
    Copy the full SHA
    36568e2 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Add timestamp to requests when adding reactions

    @tgolen
    tgolen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    62f83fe View commit details
    Browse the repository at this point in the history

  2. Add API parameter to use new data format

    @tgolen
    tgolen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8c31f4f View commit details
    Browse the repository at this point in the history

  3. Rename methods

    @tgolen
    tgolen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f93266e View commit details
    Browse the repository at this point in the history

  4. Rename old toggle method

    @tgolen
    tgolen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    44d426a View commit details
    Browse the repository at this point in the history

  5. Provide a second toggle method for emojiReactions

    @tgolen
    tgolen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    5b99716 View commit details
    Browse the repository at this point in the history

  6. Update for checking to see if someone already reacted

    @tgolen
    tgolen committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b2781c9 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9adef35 View commit details
    Browse the repository at this point in the history

  2. style

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    c8369e5 View commit details
    Browse the repository at this point in the history

  3. Remove code that still uses old format

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    d7221f6 View commit details
    Browse the repository at this point in the history

  4. Remove more code referencing old reactions

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    34797c7 View commit details
    Browse the repository at this point in the history

  5. Remove unused component

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    11c5380 View commit details
    Browse the repository at this point in the history

  6. Get tests working for toggling reactions

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2970f79 View commit details
    Browse the repository at this point in the history

  7. Update tests for adding reactions

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    c17e2ec View commit details
    Browse the repository at this point in the history

  8. Get emojis removing properly

    @tgolen
    tgolen committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b8add23 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a51ede1 View commit details
    Browse the repository at this point in the history

  2. Fix optimistic removal of emoji

    @tgolen
    tgolen committed May 16, 2023
    Configuration menu
    Copy the full SHA
    cb9c262 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. WIP on preserving order of reactions

    @tgolen
    tgolen committed May 17, 2023
    Configuration menu
    Copy the full SHA
    f35e7bc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 17, 2023
    Configuration menu
    Copy the full SHA
    3de5adf View commit details
    Browse the repository at this point in the history

  3. Apply changes from main

    @tgolen
    tgolen committed May 17, 2023
    Configuration menu
    Copy the full SHA
    62464bd View commit details
    Browse the repository at this point in the history

  4. Remove unused method

    @tgolen
    tgolen committed May 17, 2023
    Configuration menu
    Copy the full SHA
    7d5eca7 View commit details
    Browse the repository at this point in the history

  5. Sort the reactions by timestamp so that they are always in the same o… 

    …rder
    @tgolen
    tgolen committed May 17, 2023
    Configuration menu
    Copy the full SHA
    28b31c9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    02d333b View commit details
    Browse the repository at this point in the history

  2. Update from recent code changes

    @tgolen
    tgolen committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2394a42 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2855cc0 View commit details
    Browse the repository at this point in the history

  2. Remove debug

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    729f2aa View commit details
    Browse the repository at this point in the history

  3. Use negative values instead of strings

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5ae68d6 View commit details
    Browse the repository at this point in the history

  4. Remove unused parameter

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f26dacc View commit details
    Browse the repository at this point in the history

  5. Share proptypes

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    270e166 View commit details
    Browse the repository at this point in the history

  6. Share more propTypes

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5f9dc09 View commit details
    Browse the repository at this point in the history

  7. Remove unused method

    @tgolen
    tgolen committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9f26e87 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Fix lint errors

    @tgolen
    tgolen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2994e00 View commit details
    Browse the repository at this point in the history

  2. Correct the tests when removing emoji

    @tgolen
    tgolen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    b90fed1 View commit details
    Browse the repository at this point in the history

  3. Disable eslint error

    @tgolen
    tgolen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c24edaa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    5bf57b3 View commit details
    Browse the repository at this point in the history

  5. Move ESLint disable to a better line

    @tgolen
    tgolen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    93012d7 View commit details
    Browse the repository at this point in the history

  6. Add more data to the sorting key so that things will stay in order

    @tgolen
    tgolen committed May 25, 2023
    Configuration menu
    Copy the full SHA
    b518fcd View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Merge branch 'main' into tgolen-migrate-reactions

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    53c3b98 View commit details
    Browse the repository at this point in the history

  2. Simplify onyx key for collection

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    e422147 View commit details
    Browse the repository at this point in the history

  3. Add comment about cleanup task

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    3d6f5a2 View commit details
    Browse the repository at this point in the history

  4. Rename method and fix proptypes

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    5227282 View commit details
    Browse the repository at this point in the history

  5. Make the sorting work a little more reliably

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    6d60bee View commit details
    Browse the repository at this point in the history

  6. Replace prop that was mistakingly removed

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    5cf209f View commit details
    Browse the repository at this point in the history

  7. Fix lint problem with propTypes

    @tgolen
    tgolen committed May 29, 2023
    Configuration menu
    Copy the full SHA
    07ef367 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Fix prop reference and jsdocs

    @tgolen
    tgolen committed May 30, 2023
    Configuration menu
    Copy the full SHA
    149cb37 View commit details
    Browse the repository at this point in the history

  2. Fix other JSDocs

    @tgolen
    tgolen committed May 30, 2023
    Configuration menu
    Copy the full SHA
    69a05a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge branch 'main' of github.com:Expensify/App into tgolen-migrate-r… 

    …eactions
    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    da7d9fc View commit details
    Browse the repository at this point in the history

  2. Fix emojiReaction prop name

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f2cf706 View commit details
    Browse the repository at this point in the history

  3. Fix memo check

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d11717b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:Expensify/App into tgolen-migrate-r… 

    …eactions
    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0c7396e View commit details
    Browse the repository at this point in the history

  5. Fix test

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bf7f6f7 View commit details
    Browse the repository at this point in the history

  6. Lint

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ccf50b0 View commit details
    Browse the repository at this point in the history

  7. Actually fix tests

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    979066a View commit details
    Browse the repository at this point in the history

  8. Fix counting of skintones

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0ed88fd View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary lodash get

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f5fb5a1 View commit details
    Browse the repository at this point in the history

  10. Fix quick reactions not properly removing emojis

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9d6e4e0 View commit details
    Browse the repository at this point in the history

  11. Only get users who have reacted to display tooltip, and pass as number

    @stitesExpensify
    stitesExpensify committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    86d836a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Simplify counting and update variable name

    @stitesExpensify
    stitesExpensify committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    f6593a4 View commit details
    Browse the repository at this point in the history

  2. Fix bad check that would fail for skintone==0

    @stitesExpensify
    stitesExpensify committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    aa0c587 View commit details
    Browse the repository at this point in the history

  3. Fix bad merge

    @stitesExpensify
    stitesExpensify committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    47e6505 View commit details
    Browse the repository at this point in the history

  4. Fix param documentation

    @stitesExpensify
    stitesExpensify committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    88e6d1a View commit details
    Browse the repository at this point in the history

  5. Update name to follow conventions

    @stitesExpensify
    stitesExpensify committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ae31431 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Check for undefined to account for 0

    @stitesExpensify
    stitesExpensify committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    066ad58 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Start fixing merge conflicts

    @stitesExpensify
    stitesExpensify committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    f77421e View commit details
    Browse the repository at this point in the history

  2. Finish merge

    @stitesExpensify
    stitesExpensify committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    846d059 View commit details
    Browse the repository at this point in the history

  3. Style

    @stitesExpensify
    stitesExpensify committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a9e26e5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:Expensify/App into tgolen-migrate-r… 

    …eactions
    @stitesExpensify
    stitesExpensify committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c46bd4b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Merge branch 'main' of github.com:Expensify/App into tgolen-migrate-r… 

    …eactions
    @stitesExpensify
    stitesExpensify committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    6d89fa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Merge branch 'main' of github.com:Expensify/App into tgolen-migrate-r… 

    …eactions
    @stitesExpensify
    stitesExpensify committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b4d7e6e View commit details
    Browse the repository at this point in the history

  2. Remove unused prop

    @stitesExpensify
    stitesExpensify committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    73ca137 View commit details
    Browse the repository at this point in the history