Don't skip all actions on version update PRs, because it also skips automerge #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
approved these changes
Mar 16, 2021
|
Merging to unbreak e.cash deploys |
|
@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done or remove the |
|
We merged early to unbreak deploys. It looks like this was successful in triggering the automerge workflow on the version-bump PR as expected. However, the automerge did not re-trigger the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR added some code to skip all Github Actions on automatically generated version-bump PRs, because we never wait for tests to finish on those anyways. However, this also skips the
automergeworkflow, which prevents the master branch from actually being updated.Merge to test