Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo cla actor #1821

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Echo cla actor #1821

merged 3 commits into from
Mar 17, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 17, 2021

Tested in Public-Test-Repo https://github.com/Andrew-Test-Org/Public-Test-Repo/pull/44/checks?check_run_id=2127201191 and github.event.pull_request.user.login does give the creator of the PR. So it must be some other syntax error. This is a bit of a shot-in-the-dark, but given the following passage from the GH Actions docs, I think it's worth a shot:

image

@roryabraham roryabraham requested a review from a team as a code owner March 17, 2021 02:32
@botify botify requested review from robertjchen and removed request for a team March 17, 2021 02:32
@roryabraham roryabraham requested a review from Jag96 March 17, 2021 02:37
@roryabraham roryabraham self-assigned this Mar 17, 2021
@Jag96
Copy link
Contributor

Jag96 commented Mar 17, 2021

Testing workflow again, no need to wait for e2e

@Jag96 Jag96 merged commit 3466c37 into master Mar 17, 2021
@Jag96 Jag96 deleted the Rory-TestCLAActor branch March 17, 2021 02:41
@botify
Copy link

botify commented Mar 17, 2021

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@Jag96 Jag96 removed the Emergency label Mar 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
@Jag96
Copy link
Contributor

Jag96 commented Mar 17, 2021

This failed on the CLA workflow again, and it didn't print out the CLA actor: https://github.com/Expensify/Expensify.cash/runs/2127310065?check_suite_focus=true

@roryabraham
Copy link
Contributor Author

@roryabraham
Copy link
Contributor Author

This failed on the CLA workflow again, and it didn't print out the CLA actor

This is super weird, and makes me think that the CLA workflow is for some reason not using the code on master.

@AndrewGable
Copy link
Contributor

Did you figure this one out?

@roryabraham
Copy link
Contributor Author

Nope, but you did!

image

Basically the changes to the CLA workflow weren't on staging yet, so they weren't taking effect on PRs w/ staging as the base.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants