Don't require clean mergeable state #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
approved these changes
Mar 17, 2021
|
Merging to fix deploys, no need to wait for e2e tests |
|
@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done or remove the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR comment lays out the current state of our deploys. We're very close, but we're not successfully updating the
stagingbranch because of failing CLA checks on the automerge PR.Ideally we would skip CLA on automerge PRs so that they would be able to be in a clean mergeable_state (no failing checks), but unfortunately that code is not working. The purpose of this PR is to get deploys in a functional state before I leave for the night.