Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo revert of clean staging PR check #1840

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Undo revert of clean staging PR check #1840

merged 1 commit into from
Mar 17, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

This reverts some checks for the "clean" status of a staging PR. I believe with our current code we are correctly skipping the CLA checks, meaning the staging PR will be clean and able to be merged.

Fixed Issues

Fixes N/A

Tests

  1. Merge this PR
  2. Verify that the staging PR created and merged automatically

@AndrewGable AndrewGable self-assigned this Mar 17, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner March 17, 2021 17:33
@botify botify requested review from marcaaron and removed request for a team March 17, 2021 17:34
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham roryabraham merged commit 5cc1a81 into master Mar 17, 2021
@roryabraham roryabraham deleted the andrew-clean branch March 17, 2021 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
@roryabraham
Copy link
Contributor

Automerge failed for the PR to bump version on master!

@AndrewGable
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants