Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split finishReleaseCycle into two jobs #1876

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Mar 18, 2021

Details

The finishReleaseCycle workflow previously only had on job which ran on ubuntu. However, the bumpVersion action relies on the macOS utility PListBuddy, so it failed. Furthermore, the repo-sync/pull-request action only works on ubuntu. So this PR splits the finishReleaseCycle workflow into two jobs: one that runs ubuntu and another macOS.

Fixes

Failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2144100874?check_suite_focus=true

Tests

To test this workflow, we'll need to:

  1. Merge this PR
  2. Close an E.cash issue labeled StagingDeployCash

We'll then expect that:

  • An automerge PR is created from staging -> production
  • A new BUILD version is created off master.
  • An automerge PR for that new version is created w/ master as the base. Only the version files should be updated in that PR, and it should be merged.
  • Tags should be pushed, and a staging deploy should happen
  • A new StagingDeployCash should be triggered.

@roryabraham roryabraham requested a review from AndrewGable March 18, 2021 22:59
@roryabraham roryabraham self-assigned this Mar 18, 2021
@roryabraham roryabraham requested a review from a team as a code owner March 18, 2021 22:59
@botify botify requested review from thienlnam and removed request for a team March 18, 2021 23:00
@roryabraham
Copy link
Contributor Author

Note that both of these jobs will run asynchronously. I think that's fine and they don't need to be run sequentially in this case, but buddy-check.

@AndrewGable AndrewGable removed the request for review from thienlnam March 18, 2021 23:13
@AndrewGable
Copy link
Contributor

I think this looks good, modeled off of the other workflow well. Skipping e2e to get this tested ASAP.

@AndrewGable AndrewGable merged commit f3544bd into master Mar 18, 2021
@AndrewGable AndrewGable deleted the Rory-FinishReleaseCycleMultipleJobs branch March 18, 2021 23:14
@botify
Copy link

botify commented Mar 18, 2021

@AndrewGable looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2021
@roryabraham
Copy link
Contributor Author

roryabraham commented Mar 18, 2021

Testing:

finishReleaseCycle workflow run: https://github.com/Expensify/Expensify.cash/actions/runs/666214402
automerge PR staging -> prod: #1881 (was merged)
new StagingDeployCash: #1883
new version PR against master: #1882 (was merged)
New version staging deploy happened:
image

  • An automerge PR is created from staging -> production
  • A new BUILD version is created off master.
  • An automerge PR for that new version is created w/ master as the base. Only the version files should be updated in that PR, and it should be merged.
  • Tags should be pushed, and a staging deploy should happen
  • A new StagingDeployCash should be triggered.

So this is a pass 🎉

@AndrewGable
Copy link
Contributor

🥳

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants