-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17047 migrate PressableWithSecondaryInteraction to PressableWithFeedback component #20251
Merged
luacmartins
merged 15 commits into
Expensify:main
from
robertKozik:17047-migrate-PressableWithSecondaryInteraction
Jun 22, 2023
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
33bfa83
fix 19360 app crashes on clicking on replying thread after deleting ws
tienifr ef0dc5a
migrate PressableWithSecondaryInteraction to PressableWithFeedback
robertKozik b901d25
add missing accessibilityLabels
robertKozik 014eb8b
prettier
robertKozik 5cd97a3
create const values for accessibility roles
robertKozik 07e40d1
Merge branch 'main' into 17047-migrate-PressableWithSecondaryInteraction
robertKozik a453a84
Merge branch 'main' into 17047-migrate-PressableWithSecondaryInteraction
robertKozik cac624c
add possibility to pass components as functions to PressableWithFeedback
robertKozik e94aa5b
move accessibilityLabel to PressableWithFeedback component
robertKozik 88bde68
disable dimming on hover for PeessableWithSecondaryInteraction
robertKozik bd7c23d
Merge remote-tracking branch 'upstream/main' into 17047-migrate-Press…
robertKozik 42fb09d
disable text selection for touch devices in PressableWithSecondaryInt…
robertKozik b9d38f5
Merge branch 'main' into 17047-migrate-PressableWithSecondaryInteraction
robertKozik 235b5fc
define EmojiReactionBubble accessibilityRole by CONST value
robertKozik 4572235
Merge remote-tracking branch 'upstream/main' into 17047-migrate-Press…
robertKozik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -58,6 +58,8 @@ const EmojiReactionBubble = (props) => ( | |||||
enableLongPressWithHover={props.isSmallScreenWidth} | ||||||
// Prevent text input blur when emoji reaction is clicked | ||||||
onMouseDown={(e) => e.preventDefault()} | ||||||
accessibilityRole="button" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NAB since this already exists in many places.
Suggested change
@luacmartins after this PR merged, let's create follow-up issue for replacing all hardcoded roles |
||||||
accessibilityLabel={props.emojiCodes.join('')} | ||||||
> | ||||||
<Text style={[styles.emojiReactionBubbleText, styles.userSelectNone, StyleUtils.getEmojiReactionBubbleTextStyle(props.isContextMenu)]}>{props.emojiCodes.join('')}</Text> | ||||||
{props.count > 0 && <Text style={[styles.reactionCounterText, styles.userSelectNone, StyleUtils.getEmojiReactionCounterTextStyle(props.hasUserReacted)]}>{props.count}</Text>} | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props.title
was of number0
in some cases which caused app crash as mentioned here #25451 (comment).We should make sure the values we pass are string.