Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle isWaitingOnBankAccount for IOU requests #20821

Merged
merged 77 commits into from
Jul 25, 2023
Merged

Handle isWaitingOnBankAccount for IOU requests #20821

merged 77 commits into from
Jul 25, 2023

Commits on Jun 21, 2023

  1. Handle isWaitingForBankAccount when paying request

    @nkuoch
    nkuoch committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    cd6dba8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Handle reimbursed action

    @nkuoch
    nkuoch committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    e84fc71 View commit details
    Browse the repository at this point in the history

  2. Some cleaning

    @nkuoch
    nkuoch committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c370ea9 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Add translations

    @nkuoch
    nkuoch committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    0418d9a View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. New copies

    @nkuoch
    nkuoch committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f9a0756 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    483a029 View commit details
    Browse the repository at this point in the history

  2. js style

    @nkuoch
    nkuoch committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    be5f7cc View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a656df2 View commit details
    Browse the repository at this point in the history

  2. Use getMoneyRequestTotal for displayed amount

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    ff482ab View commit details
    Browse the repository at this point in the history

  3. Fix console error by adding report billing state

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    ffdbf1a View commit details
    Browse the repository at this point in the history

  4. Fix eslint

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2f1a1b2 View commit details
    Browse the repository at this point in the history

  5. Some refactoring

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f68a275 View commit details
    Browse the repository at this point in the history

  6. Use button instead of link to add a bank account

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    53717db View commit details
    Browse the repository at this point in the history

  7. No need to show green dot on parent report

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    7d5150f View commit details
    Browse the repository at this point in the history

  8. Small fixes from Carlos PR review

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    abcaacd View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4efa13b View commit details
    Browse the repository at this point in the history

  10. Fix lint

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    c39b697 View commit details
    Browse the repository at this point in the history

  11. js prettier

    @nkuoch
    nkuoch committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    3d7f396 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Move addbankaccount button to MoneyRequestHeader and create generic R… 

    …eportActionItemBasicMessage instead of ReportActionItemReimbursed and ReportActionItemReimbursementQueued
    @nkuoch
    nkuoch committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2927f9a View commit details
    Browse the repository at this point in the history

  2. Fix tests and style

    @nkuoch
    nkuoch committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c13502a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. If current user already has a iou waitingForBankAccount, prevent reus… 

    …ing same iouReportID for other requests
    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d586383 View commit details
    Browse the repository at this point in the history

  2. Some refactoring

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f00bc0b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d440b61 View commit details
    Browse the repository at this point in the history

  4. Show green dot when admin needs to pay his own request

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    67e19ad View commit details
    Browse the repository at this point in the history

  5. Add button back to reportAction level

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ad9dacc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    dc64d3f View commit details
    Browse the repository at this point in the history

  7. Fix test

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d7ce6ce View commit details
    Browse the repository at this point in the history

  8. prettier

    @nkuoch
    nkuoch committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    5bc651a View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Fix tests

    @nkuoch
    nkuoch committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    32acf1c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Rename method to hasIouWaitingOnCurrentUserBankAccount

    @nkuoch
    nkuoch committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    bedc151 View commit details
    Browse the repository at this point in the history

  2. Prettier

    @nkuoch
    nkuoch committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    41d7bb3 View commit details
    Browse the repository at this point in the history

  3. Small fixes

    @nkuoch
    nkuoch committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    b1cde86 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Prettier

    @nkuoch
    nkuoch committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    284ce2f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    218d88a View commit details
    Browse the repository at this point in the history

  2. Dont show green button on chat report for isWaitingOnBankAccount case

    @nkuoch
    nkuoch committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    aa2c40f View commit details
    Browse the repository at this point in the history

  3. Default report preview amount to the one from the report action if io… 

    …uReport is not available
    @nkuoch
    nkuoch committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    19df18a View commit details
    Browse the repository at this point in the history

  4. Dont show green button on chat report for isWaitingOnBankAccount case

    @nkuoch
    nkuoch committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d8f75d5 View commit details
    Browse the repository at this point in the history

  5. Default report preview amount to the one from the report action if io… 

    …uReport is not available
    @nkuoch
    nkuoch committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    840587d View commit details
    Browse the repository at this point in the history

  6. Make sure we close the modal after clicking on Continue

    @nkuoch
    nkuoch committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    4449a86 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    821628b View commit details
    Browse the repository at this point in the history

  2. Fix missing iou amount

    @nkuoch
    nkuoch committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ad62d24 View commit details
    Browse the repository at this point in the history

  3. Fix merge conflict

    @nkuoch
    nkuoch committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4984806 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'nat-iouw' of github.com:Expensify/App into nat-iouw

    @nkuoch
    nkuoch committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    77783a4 View commit details
    Browse the repository at this point in the history

  5. prettier

    @nkuoch
    nkuoch committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9f90c9f View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge branch 'vit-bumpOnyxVersion' into nat-iouw

    @nkuoch
    nkuoch committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7f729f6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    627f4cd View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. shouldShowGreenDotIndicator needs managerID in optionItem

    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cae3c44 View commit details
    Browse the repository at this point in the history

  2. Fix unit test

    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b889078 View commit details
    Browse the repository at this point in the history

  3. Fix ioupreview amount for other types of messages

    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    87eb926 View commit details
    Browse the repository at this point in the history

  4. Fix preview message

    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    4549681 View commit details
    Browse the repository at this point in the history

  5. Close modal to show report only if coming from click from button from… 

    … report
    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7f1b9e7 View commit details
    Browse the repository at this point in the history

  6. Fix eslint

    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    fbe5aed View commit details
    Browse the repository at this point in the history

  7. If no iouReport to get managerID from, get actorAccountID from report… 

    …Action
    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    caa301b View commit details
    Browse the repository at this point in the history

  8. Update src/components/ReportActionItem/ReportPreview.js 

    Co-authored-by: Carlos Martins <cmartins@expensify.com>
    @nkuoch @luacmartins
    nkuoch and luacmartins authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cf72cc1 View commit details
    Browse the repository at this point in the history

  9. Fixes from Carlos PR review

    @nkuoch
    nkuoch committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    043398d View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Dont show settlement button if we dont have the ioureport

    @nkuoch
    nkuoch committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    f40658c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Global create update

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    bde5c68 View commit details
    Browse the repository at this point in the history

  2. Resolve merge conflicts

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9370590 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into nat-iouw

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    35923fd View commit details
    Browse the repository at this point in the history

  4. Fix linter

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    05a7eab View commit details
    Browse the repository at this point in the history

  5. Resolve merge conflicts

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e3513f5 View commit details
    Browse the repository at this point in the history

  6. Update tests

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ba7f911 View commit details
    Browse the repository at this point in the history

  7. Update the tests

    @mountiny
    mountiny committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    40e6d86 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Resolve merge conflicts

    @mountiny
    mountiny committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5845661 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate single transaction details

    @mountiny
    mountiny committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    c1b8d6e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8234369 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflict

    @nkuoch
    nkuoch committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    871821f View commit details
    Browse the repository at this point in the history

  3. Fix cannot read property of null

    @nkuoch
    nkuoch committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    05f270b View commit details
    Browse the repository at this point in the history

  4. Revert console.log

    @nkuoch
    nkuoch committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    dfa3230 View commit details
    Browse the repository at this point in the history

  5. Import underscore

    @nkuoch
    nkuoch committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    58bf070 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    405f470 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflict

    @nkuoch
    nkuoch committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    91a40c5 View commit details
    Browse the repository at this point in the history

  3. Fix eslint

    @nkuoch
    nkuoch committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2f48cd2 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Merge branch 'main' into nat-iouw

    @nkuoch
    nkuoch committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3c45555 View commit details
    Browse the repository at this point in the history

  2. Fix addBankAccount button still visible after user adds a bank account

    @nkuoch
    nkuoch committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    388d977 View commit details
    Browse the repository at this point in the history

  3. Only show iou.pay, not reimbursed action to avoid duplicate message

    @nkuoch
    nkuoch committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1158139 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix test

    @nkuoch
    nkuoch committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6462b40 View commit details
    Browse the repository at this point in the history