Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17548 Personal details push to page #21049

Merged
merged 37 commits into from
Jul 26, 2023
Merged

17548 Personal details push to page #21049

merged 37 commits into from
Jul 26, 2023

Conversation

gedu
Copy link
Contributor

@gedu gedu commented Jun 19, 2023 •
edited
Loading

Details

Updated dropdowns fields to be MenuItems which sends the user to another page to pick the option
Standarized the spaces between Inputs, created a new FormSpace component.

Fixed Issues

$ #17548
PROPOSAL: #17548 (comment)

Main PR where all started: #18424

Tests

Errors on Empty State

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Save
  4. All the Inputs even the Menu Items should show a required field error

Update the menu Country item (no USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select a new country (no USA)
  5. The Country Item should show the selected Country
  6. The State Input should be an input component
  7. You can select new ones and the Menu Item should be updated

Update the menu Country item (USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select United State
  5. Should send you back and the Country Item should show the selected Country
  6. The State Input should be a Menu Item

Update the menu State item (USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select United State
  5. The Country Item should show the selected Country
  6. Clicking on the State menu should send you to a new Page
  7. You can select any State
  8. Should send you back to and show you the updated State

Autocomplete address

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Start filling the Address Line 1, a suggestion menu should shows up
  4. Clicking on any address should autocomplete, menu items and inputs
  • Verify that no errors appear in the JS console

Offline tests

Errors on Empty State

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Save
  4. All the Inputs even the Menu Items should show a required field error

Update the menu Country item (no USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select a new country (no USA)
  5. The Country Item should show the selected Country
  6. The State Input should be an input component
  7. You can select new ones and the Menu Item should be updated

Update the menu Country item (USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select United State
  5. Should send you back and the Country Item should show the selected Country
  6. The State Input should be a Menu Item

Update the menu State item (USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select United State
  5. The Country Item should show the selected Country
  6. Clicking on the State menu should send you to a new Page
  7. You can select any State
  8. Should send you back to and show you the updated State

QA Steps

Errors on Empty State

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Save
  4. All the Inputs even the Menu Items should show a required field error

Update the menu Country item (no USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select a new country (no USA)
  5. The Country Item should show the selected Country
  6. The State Input should be an input component
  7. You can select new ones and the Menu Item should be updated

Update the menu Country item (USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select United State
  5. Should send you back and the Country Item should show the selected Country
  6. The State Input should be a Menu Item

Update the menu State item (USA)

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Click on Country item
  4. Should send you to a new page, select United State
  5. The Country Item should show the selected Country
  6. Clicking on the State menu should send you to a new Page
  7. You can select any State
  8. Should send you back to and show you the updated State

Autocomplete address

  1. Sign in using an User that doesn’t have address
  2. Go to the Address Page (No inputs should be filled)
  3. Start filling the Address Line 1, a suggestion menu should shows up
  4. Clicking on any address should autocomplete, menu items and inputs
  • Verify you can update the Menu Items or you can go back to from the selection and the last selection should be in place
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn’t include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function’s arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn’t exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it’s using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don’t apply to this PR.

Screenshots/Videos

Web
chrome_pushDetails.mp4
safari_pushDetails.mp4
Mobile Web - Chrome
androidChrome_pushDetails.mp4
Mobile Web - Safari
iphoneSafari_pushDetails.mp4
Desktop
desktop_pushDetails.mp4
iOS
iphone_pushDetails.mp4
Android
android_pushDetails.mp4

@gedu gedu requested a review from a team as a code owner June 19, 2023 16:08
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot bot requested review from 0xmiros and removed request for a team June 19, 2023 16:08
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@gedu
Copy link
Contributor Author

gedu commented Jun 19, 2023

@0xmiroslav Sorry for the new PR creation, don't know why a signed commit was missing and trying to fix it the PR got closed with no commits

@gedu
Copy link
Contributor Author

gedu commented Jun 19, 2023

@0xmiroslav last comment from the other PR:

#18424 (comment)

@gedu
Copy link
Contributor Author

gedu commented Jun 21, 2023

@0xmiroslav can I help with something else?

cc: @mountiny

@mountiny
Copy link
Contributor

@gedu Can you please include recordings on all the platforms?

@mountiny mountiny requested a review from cristipaval June 21, 2023 09:54
@gedu
Merge branch 'main' into edu/17548_personal_details_push_to_page_patch
b603569 
# Conflicts:
#	src/libs/Navigation/AppNavigator/ModalStackNavigators.js
#	src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js
#	src/libs/Navigation/linkingConfig.js
@gedu
Copy link
Contributor Author

gedu commented Jun 22, 2023

@mountiny Uploaded the videos, is missing the iOS ones, I'm having some issues running it.

Variable binding in a condition requires an initializer in AirshipChannelProxy & AirshipContactProxy swift files

So I'm updating my xCode version

@gedu
Copy link
Contributor Author

gedu commented Jun 22, 2023

@mountiny I will need to upgrade my OS at least to Monterey 12.5 to use xcode 14.2, because downgrading to 13.2 didn't work,

@gedu
Copy link
Contributor Author

gedu commented Jun 23, 2023

@mountiny @0xmiroslav all videos are up

@mountiny
Copy link
Contributor

@cristipaval will be abel to handle this pr as a reviewer 🙇

@gedu
Copy link
Contributor Author

gedu commented Jun 26, 2023

I found a bug checking the bank flow, seems that after the navigation refactor something is broken, the state picker isn't getting rerender (adding bank manually) so I'm checking it

@gedu
Copy link
Contributor Author

gedu commented Jun 28, 2023

@0xmiroslav @mountiny updated

bank_flow_state.mp4

@mountiny
Copy link
Contributor

mountiny commented Jul 4, 2023

@0xmiroslav any updates?

@gedu
Copy link
Contributor Author

gedu commented Jul 5, 2023

@0xmiroslav can I help with something? so we can merge this PR?

cc: @mountiny

@0xmiros
Copy link
Contributor

0xmiros commented Jul 5, 2023

I am checklisting right now. Thanks for patience

@mountiny
Copy link
Contributor

thanks everyone, asked about it in Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1690375860010059

@mountiny
Copy link
Contributor

given this already exists in the App, I think we can safely proceed with this

mountiny
mountiny approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koko57 @s77rt one question pending, thank you!

src/components/CountryPicker/index.js Show resolved Hide resolved
@mountiny mountiny merged commit 3d22f59 into Expensify:main Jul 26, 2023
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 26, 2023
Closed
43 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.46-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@MariaHCD MariaHCD mentioned this pull request Jul 27, 2023
Closed
6 tasks
@MariaHCD
Copy link
Contributor

MariaHCD commented Jul 27, 2023 •
edited
Loading

👋🏼 I have a deploy blocker that I think is related to this PR: #23725

Does anyone have more context on this?

@OSBotify OSBotify mentioned this pull request Jul 27, 2023
Closed
79 tasks
@melvin-bot melvin-bot bot mentioned this pull request Jul 27, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.47-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@s77rt
Copy link
Contributor

s77rt commented Jul 28, 2023

This caused a "regression?" #23768 After opening the modal we should always set the search text to the current selected value. For App consistency I think we consider this as a bug.

@koko57
Copy link
Contributor

koko57 commented Jul 31, 2023

@s77rt yeah, my bad I haven't checked that scenario. Should I handle it or you're going with the accepted #23768 (comment)?

@s77rt
Copy link
Contributor

s77rt commented Jul 31, 2023

@koko57 I think we will be going with the contributor as he got assigned already.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

mananjadhav
mananjadhav reviewed Aug 16, 2023
View reviewed changes
src/components/StatePicker/index.js
onInputChange: PropTypes.func,

/** A ref to forward to MenuItemWithTopDescription */
forwardedRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we migrated the StatePicker component, we missed adding the label prop, which caused a regression here.

@eVoloshchak eVoloshchak mentioned this pull request Aug 17, 2023
Closed
6 tasks
@s77rt s77rt mentioned this pull request Aug 18, 2023
Closed
6 tasks
allroundexperts
allroundexperts reviewed Aug 20, 2023
View reviewed changes
src/pages/settings/Profile/PersonalDetails/AddressPage.js
if (key !== 'country') {
return;
}
setCurrentCountry(value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not reset the value of address state which led to this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a regression? Seems more like an improvement, we didn't use to reset such values previously right?

@allroundexperts allroundexperts mentioned this pull request Aug 20, 2023
Closed
6 tasks
@sobitneupane
Copy link
Contributor

We missed to make change in AddDebitCardPage which causes this regression and was fixed by this PR.

@sobitneupane sobitneupane mentioned this pull request Aug 21, 2023
Closed
6 tasks
@tienifr tienifr mentioned this pull request Aug 24, 2023
Closed
6 tasks
@b4s36t4 b4s36t4 mentioned this pull request Aug 26, 2023
Closed
6 tasks
s77rt
s77rt reviewed Oct 17, 2023
View reviewed changes
src/pages/ReimbursementAccount/AddressForm.js
@@ -137,7 +138,6 @@ function AddressForm(props) {
label={props.translate('common.zip')}
accessibilityLabel={props.translate('common.zip')}
accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
containerStyles={[styles.mt4]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we need margin here. If the input is focused the label looks too close to the input above it. (#29137)

@s77rt s77rt mentioned this pull request Oct 17, 2023
Closed
6 tasks
fedirjh
fedirjh reviewed Jan 24, 2024
View reviewed changes
src/components/StatePicker.js
errorText: '',
shouldSaveDraft: false,
inputID: undefined,
onBlur: () => {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from #30195 , onBlur is crucial for the Form validation; it should have been preserved when migrating the StatePicker to the new push-to-page component.

@fedirjh fedirjh mentioned this pull request Jan 24, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmiros 0xmiros 0xmiros left review comments

@fedirjh fedirjh fedirjh left review comments

@allroundexperts allroundexperts allroundexperts left review comments

@koko57 koko57 koko57 left review comments

@s77rt s77rt s77rt approved these changes

@mananjadhav mananjadhav mananjadhav left review comments

@mountiny mountiny mountiny approved these changes

@cristipaval cristipaval Awaiting requested review from cristipaval

Assignees

@gedu gedu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.