prevent user with no permission from flag comment #22099

hungvu193 · 2023-07-03T10:45:14Z

Details

Fix: Prevent user with no permission from flagging comment

Fixed Issues

$ #21719
PROPOSAL: #21719 (comment)

Tests

Login with userA account
Go to the “New room” section
Enter room name and select userA workspace
Select visibility to “Public”
Click on “Create room”
Send some messages in room chat
Go to the room detail
Share code > Copy URL to clipboard
Go back and click on Settings > Who can post
Select Admin only
Open other browser and login with userB account
Join the room by pasting URL
Hover or right click on userB comment
Verify that there's no Flag as offensive option.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Login with userA account
Go to the “New room” section
Enter room name and select userA workspace
Select visibility to “Public”
Click on “Create room”
Send some messages in room chat
Go to the room detail
Share code > Copy URL to clipboard
Go back and click on Settings > Who can post
Select Admin only
Open other browser and login with userB account
Join the room by pasting URL
Hover or right click on userB comment
Verify that there's no Flag as offensive option.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots

Web

Screen.Recording.2023-07-03.at.17.51.08.mov

Mobile Web - Chrome

RPReplay_Final1688381780.MP4

Mobile Web - Safari

RPReplay_Final1688381592.MP4

Desktop

Screen.Recording.2023-07-03.at.17.58.05.mov

iOS

Screen.Recording.2023-07-03.at.18.01.56.mov

Android

Screen.Recording.2023-07-03.at.18.04.19.mov

melvin-bot · 2023-07-03T11:05:04Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-07-03T11:05:22Z

@allroundexperts PR is ready for review!

allroundexperts · 2023-07-03T15:17:21Z

@hungvu193 Please fix the lint error.

allroundexperts · 2023-07-03T15:17:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-04.at.3.44.35.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-04.at.3.58.56.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-04.at.3.57.59.PM.mov

Desktop

Screen.Recording.2023-07-04.at.3.49.16.PM.mov

iOS

Screen.Recording.2023-07-04.at.4.02.29.PM.mov

Android

Screen.Recording.2023-07-04.at.4.00.23.PM.mov

allroundexperts · 2023-07-03T15:31:29Z

Still not fixed @hungvu193.

hungvu193 · 2023-07-03T15:32:04Z

ah I see @allroundexperts, I'm working on a fix

hungvu193 · 2023-07-03T15:45:48Z

Fixed @allroundexperts

allroundexperts · 2023-07-04T10:42:30Z

src/libs/ReportUtils.js

+ * @param {number} reportID
+ * @returns {Boolean}
+ */
+function canFlagReportAction(reportAction, reportID) {


@hungvu193 You need to supply reportID everywhere where canFlagReportAction function is being called. Please test your code thoroughly before creating PRs. Regressions like these cause a lot of trouble down the lane.

@allroundexperts my bad, I've just updated

allroundexperts · 2023-07-04T11:20:57Z

@hungvu193 I think the test steps can be improved. Can you please reduce there length and make sure that they're more clear?

allroundexperts

Works and tests good.

OSBotify · 2023-07-04T12:02:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-05T17:31:41Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-07T10:37:07Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

prevent user with no permission from flag comment

190c030

hungvu193 marked this pull request as ready for review July 3, 2023 11:04

hungvu193 requested a review from a team as a code owner July 3, 2023 11:04

melvin-bot bot requested review from allroundexperts and removed request for a team July 3, 2023 11:05

fix lint error

310ca01

fix lint

5cc07e0

allroundexperts suggested changes Jul 4, 2023

View reviewed changes

hungvu193 added 2 commits July 4, 2023 17:49

update canFlagReportAction params

824b7b2

Merge branch 'fix-21719' of github.com:hungvu193/App into fix-21719

0a05097

allroundexperts approved these changes Jul 4, 2023

View reviewed changes

melvin-bot bot requested a review from danieldoglas July 4, 2023 11:21

danieldoglas approved these changes Jul 4, 2023

View reviewed changes

danieldoglas merged commit 7a99206 into Expensify:main Jul 4, 2023

hungvu193 mentioned this pull request Jul 5, 2023

Dev: Web - User can flag a message on admins only room #22237

Closed

6 tasks

Beamanator mentioned this pull request Jul 5, 2023

Remove few instances of reportAction.actorEmail for email -> accountID migration #22269

Merged

57 tasks

OSBotify mentioned this pull request Jul 5, 2023

Deploy Checklist: New Expensify 2023-07-05 #22282

Closed

58 tasks

0xmiros mentioned this pull request Jul 5, 2023

Remove all uses of actorEmail as part of personalDetails migration #21874

Merged

57 tasks

melvin-bot bot mentioned this pull request Jul 7, 2023

[HOLD for payment 2023-07-14] [$1000] Error message displayed when User flags a message with no permission in a group chat #21719

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prevent user with no permission from flag comment #22099

prevent user with no permission from flag comment #22099

hungvu193 commented Jul 3, 2023 •

edited

Loading

melvin-bot bot commented Jul 3, 2023

hungvu193 commented Jul 3, 2023

allroundexperts commented Jul 3, 2023

allroundexperts commented Jul 3, 2023 •

edited

Loading

allroundexperts commented Jul 3, 2023

hungvu193 commented Jul 3, 2023

hungvu193 commented Jul 3, 2023

allroundexperts Jul 4, 2023 •

edited

Loading

hungvu193 Jul 4, 2023

allroundexperts commented Jul 4, 2023

allroundexperts left a comment

OSBotify commented Jul 4, 2023

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

prevent user with no permission from flag comment #22099

prevent user with no permission from flag comment #22099

Conversation

hungvu193 commented Jul 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot bot commented Jul 3, 2023

hungvu193 commented Jul 3, 2023

allroundexperts commented Jul 3, 2023

allroundexperts commented Jul 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Jul 3, 2023

hungvu193 commented Jul 3, 2023

hungvu193 commented Jul 3, 2023

allroundexperts Jul 4, 2023 • edited Loading

Choose a reason for hiding this comment

hungvu193 Jul 4, 2023

Choose a reason for hiding this comment

allroundexperts commented Jul 4, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 4, 2023

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

hungvu193 commented Jul 3, 2023 •

edited

Loading

allroundexperts commented Jul 3, 2023 •

edited

Loading

allroundexperts Jul 4, 2023 •

edited

Loading