-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 20848 enable 2fa button in verify page #22151
fix: 20848 enable 2fa button in verify page #22151
Conversation
@mollfpr After testing this PR, I found out that the prop type of It should be changed like the following commit, because we're using function component So using forwardRef in Should we handle it here? |
@mollfpr Can you help check my PR? |
Reviewer Checklist
Screenshots/VideosWeb22151.Web.movMobile Web - Chrome22151.mWeb.Chrome.webmMobile Web - Safari22151.mWeb.Safari.mp4Desktop22151.Desktop.moviOS22151.iOS.mp4Android22151.Android.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienifr Regarding this #22151 (comment) I don't think we need to. Maybe it's already logged somewhere.
src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthForm/BaseTwoFactorAuthForm.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.38-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀
|
Details
Fixed Issues
$ #20848
PROPOSAL: #20848 (comment)
Tests
Offline tests
same as above
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-07-04.at.10.17.17.mov
Mobile Web - Chrome
video_2023-07-04_15-37-05.mp4
Mobile Web - Safari
original-7E25D788-F301-4414-A570-7FEE410CD839.mp4
Desktop
Screen.Recording.2023-07-04.at.11.02.34.mov
iOS
Screen.Recording.2023-07-04.at.10.50.18.mov
Android
Screencast.from.04-07-2023.15.29.13.webm