Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ReportActionsView.js to function component #22200

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Migrate ReportActionsView.js to function component #22200

merged 8 commits into from
Jul 6, 2023

Commits on Jul 4, 2023

  1. Migrate ReportActionsView.js to function component

    @rayane-djouah
    rayane-djouah committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    ed82458 View commit details
    Browse the repository at this point in the history

  2. include context.flatListRef missing dependency in useCallback

    @rayane-djouah
    rayane-djouah committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    1b9f172 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. using useMemo in isReportFullyVisible instead of useCallback, and rep… 

    …lace ReportScrollManager with useReportScrollManager hook
    @rayane-djouah
    rayane-djouah committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3c53108 View commit details
    Browse the repository at this point in the history

  2. remove context.flatListRef arg from reportScrollManager.scrollToBottom()

    @rayane-djouah
    rayane-djouah committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    22ecb15 View commit details
    Browse the repository at this point in the history

  3. remove ReportScrollManager files as we don't need it anymore

    @rayane-djouah
    rayane-djouah committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    963b9e4 View commit details
    Browse the repository at this point in the history

  4. put each task performed when the component mounts into it's own useEf… 

    …fect call
    @rayane-djouah
    rayane-djouah committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9810bcd View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. remove wraping all functions in useCallback, and remove openReportIfN… 

    …ecessary from useEffect deps
    @rayane-djouah
    rayane-djouah committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    343a43c View commit details
    Browse the repository at this point in the history

  2. adding back unsubscribeVisibilityListener in useEffect hook

    @rayane-djouah
    rayane-djouah committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2ca339e View commit details
    Browse the repository at this point in the history