Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove all uses of actorEmail as part of personalDetails migration" #22303

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Revert "Remove all uses of actorEmail as part of personalDetails migration" #22303

merged 1 commit into from
Jul 5, 2023

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jul 5, 2023

Reverts #21874

Due to #22286 (comment)

@iwiznia iwiznia requested a review from a team as a code owner July 5, 2023 19:54
@iwiznia iwiznia self-assigned this Jul 5, 2023
@melvin-bot melvin-bot bot requested review from PauloGasparSv and removed request for a team July 5, 2023 19:55
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

@PauloGasparSv Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@iwiznia
Copy link
Contributor Author

iwiznia commented Jul 5, 2023

This is a revert, not doing the checklist really

thienlnam
thienlnam approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving tho https://expensify.slack.com/archives/C01SKUP7QR0/p1688587045117749?thread_ts=1688585912.527219&cid=C01SKUP7QR0

@PauloGasparSv
Copy link
Contributor

Feel free to merge since we got some reviews here already, removing myself!

@PauloGasparSv PauloGasparSv removed their request for review July 5, 2023 20:00
@luacmartins luacmartins mentioned this pull request Jul 5, 2023
Closed
57 tasks
@iwiznia
Copy link
Contributor Author

iwiznia commented Jul 5, 2023

Did not wait for travis to pass since this is a revert

@iwiznia iwiznia merged commit 711f45e into main Jul 5, 2023
@iwiznia iwiznia deleted the revert-21874-beaman-migrateActorEmail branch July 5, 2023 20:02
@melvin-bot melvin-bot bot added the Emergency label Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@iwiznia iwiznia removed the Emergency label Jul 5, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 5, 2023
@iwiznia @OSBotify
Merge pull request #22303 from Expensify/revert-21874-beaman-migrateA…
fb0e559 
…ctorEmail

Revert "Remove all uses of  `actorEmail` as part of personalDetails migration"

(cherry picked from commit 711f45e)
@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2023

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.37-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Jul 6, 2023
Merged
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Jul 7, 2023

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@luacmartins luacmartins mentioned this pull request Jul 18, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

@luacmartins luacmartins luacmartins approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iwiznia @PauloGasparSv @OSBotify @luacmartins @thienlnam