-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD E/E#294647] Update PersonalDetails migration of reports to remove email-based data #22811
Closed
Closed
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4586665
Add report email migration
Beamanator 4bb54c1
Add basic report migration tests
Beamanator 91bec77
Merge branch 'main' of github.com:Expensify/App into beaman-reportEma…
Beamanator 6fd9a31
Update migration
Beamanator 4125721
Prettify
Beamanator 215456a
Update src/libs/migrations/PersonalDetailsByAccountID.js
Beamanator 9c6c1ca
Merge branch 'main' of github.com:Expensify/App into beaman-reportEma…
Beamanator 3788ef6
A few more test fixes
Beamanator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not doing such migration. We are just removing the email data and hoping the server would return the the IDs version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here is slightly different than report actions. In reports we are blindly removing email data i.e. if a report has email data but not ids data, we will only remove the email data. The report data is now useless (no email data nor ids data). Should we delete the whole report in this case (similarly how it's done with report actions)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We thought about this and decided not to, because then we'd also have to delete anything related to that report (ex: report actions) so we thought it would just be better to kill the keys we're no longer using