Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language on Split Preview #22818

Merged
merged 1 commit into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/MoneyRequestConfirmationList.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function MoneyRequestConfirmationList(props) {
const selectedParticipants = useMemo(() => _.filter(props.participants, (participant) => participant.selected), [props.participants]);
const payeePersonalDetails = useMemo(() => props.payeePersonalDetails || props.currentUserPersonalDetails, [props.payeePersonalDetails, props.currentUserPersonalDetails]);
const canModifyParticipants = !props.isReadOnly && props.canModifyParticipants && props.hasMultipleParticipants;
const shouldDisableWhoPaidSection = canModifyParticipants;
const shouldDisablePaidBySection = canModifyParticipants;

const optionSelectorSections = useMemo(() => {
const sections = [];
Expand All @@ -150,14 +150,14 @@ function MoneyRequestConfirmationList(props) {

sections.push(
{
title: translate('moneyRequestConfirmationList.whoPaid'),
title: translate('moneyRequestConfirmationList.paidBy'),
data: [formattedPayeeOption],
shouldShow: true,
indexOffset: 0,
isDisabled: shouldDisableWhoPaidSection,
isDisabled: shouldDisablePaidBySection,
},
{
title: translate('moneyRequestConfirmationList.whoWasThere'),
title: translate('moneyRequestConfirmationList.splitWith'),
data: formattedParticipantsList,
shouldShow: true,
indexOffset: 1,
Expand All @@ -181,7 +181,7 @@ function MoneyRequestConfirmationList(props) {
selectedParticipants,
payeePersonalDetails,
translate,
shouldDisableWhoPaidSection,
shouldDisablePaidBySection,
]);

const selectedOptions = useMemo(() => {
Expand Down
4 changes: 2 additions & 2 deletions src/languages/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ export default {
tfaRequiredDescription: 'Please enter the two-factor authentication code\nwhere you are trying to sign in.',
},
moneyRequestConfirmationList: {
whoPaid: 'Who paid?',
whoWasThere: 'Who was there?',
paidBy: 'Paid by',
splitWith: 'Split with',
whatsItFor: "What's it for?",
},
iOUCurrencySelection: {
Expand Down
4 changes: 2 additions & 2 deletions src/languages/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ export default {
tfaRequiredDescription: 'Por favor, introduce el código de autenticación de dos factores\ndonde estás intentando iniciar sesión.',
},
moneyRequestConfirmationList: {
whoPaid: '¿Quién pago?',
whoWasThere: '¿Quién asistió?',
paidBy: 'Pagado por',
splitWith: 'Dividir con',
whatsItFor: '¿Para qué es?',
},
iOUCurrencySelection: {
Expand Down
Loading