-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text based mobile search on InviteMembers page #23366
Fix text based mobile search on InviteMembers page #23366
Conversation
Signed-off-by: Anjana Mendiratta <expertsquarrel@gmail.com>
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@GItGudRatio Can you fix the lint failure? |
Signed-off-by: Anjana Mendiratta <expertsquarrel@gmail.com>
@abdulrahuman5196 updated! |
@GItGudRatio Unit tests is failing. Kindly fix the same. Kindly make sure checks are passing. |
@abdulrahuman5196 updated! The test was failing because we were checking directly against the search value for digits and Also, added a unit test to account for this issue. |
Signed-off-by: Anjana Mendiratta <expertsquarrel@gmail.com>
79bbeb9
to
e845e87
Compare
@GItGudRatio Lint is failing agian. @GItGudRatio Kindly make sure the auto checks are passing before a review. |
Signed-off-by: Anjana Mendiratta <expertsquarrel@gmail.com>
@abdulrahuman5196 Sorry for wasting your time having to point out these trivial things, I'll take more care to do so in the future! Please review this now :) |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-07-23.at.9.26.07.PM.movMobile Web - Chromeaz_recorder_20230723_213608.mp4Mobile Web - SafariUntitled.movDesktopScreen.Recording.2023-07-23.at.9.27.55.PM.moviOSScreen.Recording.2023-07-23.at.9.30.47.PM.movAndroidaz_recorder_20230723_213651.mp4 |
No worries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @amyevans
🎀 👀 🎀
C+ Reviewed
Signed-off-by: Anjana Mendiratta <expertsquarrel@gmail.com>
Signed-off-by: Anjana Mendiratta <expertsquarrel@gmail.com>
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.45-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀
|
Details
We fix the issue where we can see that when we try to search for a user using just text, a phone number shows up, which can be confusing.
Fixed Issues
$ #22521
PROPOSAL: #22521 (comment)
Tests
998243aaaa
. Make sure that no user is shown.Offline tests
Same as above
QA Steps
Same as above.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mp4
Mobile Web - Chrome
android-mWeb.mp4
Mobile Web - Safari
ios-mWeb.mp4
Desktop
desktop.mp4
iOS
ios.mp4
Android
android.mp4