-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Remove reference to missing method #24010
Conversation
@@ -453,14 +453,7 @@ function BasePaymentsPage(props) { | |||
// InteractionManager fires after the currently running animation is completed. | |||
// https://github.com/Expensify/App/issues/7768#issuecomment-1044879541 | |||
InteractionManager.runAfterInteractions(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't removed in Nikki's PR... which doesn't really answer your question, but I think that could be part of the additional cleanup.
@rushatgabhane Would you mind taking the review? I didn't have time left and felt unwell to stay up late. Thanks! |
feel better soon! @mollfpr |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-08-01.at.21.33.42.movMobile Web - ChromeWhatsApp.Video.2023-08-01.at.21.41.12.mp4Mobile Web - SafariScreen.Recording.2023-08-01.at.21.38.59.movDesktopScreen.Recording.2023-08-01.at.21.46.33.moviOSScreen.Recording.2023-08-01.at.21.37.29.movAndroidScreen.Recording.2023-08-01.at.21.42.41.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also do more cleanup surrounding showPassword.shouldShowPasswordPrompt
and showPassword.passwordButtonText
since those will never get updated after this change, right?
How about we just fix the crash for now in this PR? |
@tgolen cool, that works too. If you want, I could create a follow up PR to remove deadcode and link it to the same issue. We still need to fix lint errors tho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be fine to not do any refactoring, but as Rushat said - lint is not happy b/c setShowPassword
is assigned but not used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well!
@@ -38,7 +38,7 @@ function BasePaymentsPage(props) { | |||
const {isSmallScreenWidth, windowWidth} = useWindowDimensions(); | |||
const [shouldShowAddPaymentMenu, setShouldShowAddPaymentMenu] = useState(false); | |||
const [shouldShowDefaultDeleteMenu, setShouldShowDefaultDeleteMenu] = useState(false); | |||
const [showPassword, setShowPassword] = useState({ | |||
const [showPassword] = useState({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need showPassword
? In what scenario is it going to be true
if everyone is passwordless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be addressed in a follow up PR #24010 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be addressed in the additional cleanup PR. I think we just stop the crash for now with this PR and CP it.
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
OK, should be all tested and have all the videos added that I can |
can be merged @Beamanator |
[CP Staging] Remove reference to missing method (cherry picked from commit 3bdfd45)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
CPing 👍 |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.48-4 🚀
|
@tgolen or @Beamanator Can either of you confirm, per our new SOX process, that @rushatgabhane should be compensated $1,000 for the review of this PR? |
I confirm 👍 |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.50-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀
|
@NikkiWines @multijump
Details
BasePaymentsPage.js
which added the reference back in refactored BasePaymentsPage to function based component #22412Fixed Issues
$ #24005
Tests
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
2023-08-01_09-32-35.mp4
Mobile Web - Chrome
Unable to test on mobile web chrome due to #22395
Mobile Web - Safari
2023-08-01_09-54-20.mp4
Desktop
2023-08-01_09-37-58.mp4
iOS
2023-08-01_09-48-41.mp4
Android
2023-08-01_10-06-51.mp4