fix reply in thread does not have from link in header #24113

StevenKKC · 2023-08-03T14:29:02Z

Details

Fixed Issues

$ #23492
PROPOSAL: #23492 (comment)

Tests

Open the app
Request money from any user, in their report, open 'owes' report and send any message
Hover on message and click on reply in thread
Verify that the app display 'From' link to parent thread in header
Now create a new workspace
Go to the new workspace chat (with square logo) on LHN
Click on + and request money
Open request money report and send any message
Hover on message and click on reply in thread
Verify that the app display 'From' link to parent thread in header

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open the app
Request money from any user, in their report, open 'owes' report and send any message
Hover on message and click on reply in thread
Verify that the app display 'From' link to parent thread in header
Now create a new workspace
Go to the new workspace chat (with square logo) on LHN
Click on + and request money
Open request money report and send any message
Hover on message and click on reply in thread
Verify that the app display 'From' link to parent thread in header

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web.webm

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Desktop.webm

iOS

Android

melvin-bot · 2023-08-03T14:29:08Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

StevenKKC · 2023-08-04T05:33:38Z

@fedirjh Could you please review PR?

fedirjh · 2023-08-04T12:16:06Z

@StevenKKC We have this warning in the Android native

StevenKKC · 2023-08-04T12:29:00Z

@fedirjh I can't reproduce it. Could you please record video?

StevenKKC · 2023-08-04T12:37:56Z

@fedirjh
BE returns the report that have parentReportID of number type.

We should fix this warning, right?

StevenKKC · 2023-08-04T12:41:08Z

@fedirjh I have committed. Please check again.

fedirjh · 2023-08-04T13:11:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-08-04.at.12.16.53.mp4

Mobile Web - Chrome

Mobile Web - Safari

CleanShot.2023-08-04.at.12.21.44.mp4

Desktop

iOS

Android

fedirjh · 2023-08-04T13:15:53Z

More Tests

Policy Expense Reports

Public Rooms

fedirjh · 2023-08-04T13:18:11Z

@StevenKKC For QA let's add another test for Policy expense reports.

StevenKKC · 2023-08-04T13:22:28Z

@fedirjh Seems like I have no permission for the policy expense reports.

After create a workspace, if open the report, BE returns as below.

fedirjh · 2023-08-04T13:49:31Z

@StevenKKC I think you have to ask for policy expense beta access in Slack #expensify-open-source channel.

StevenKKC · 2023-08-04T14:50:26Z

@fedirjh Updated test steps.

fedirjh

Looks good to me and tests well.

🎀 👀 🎀 C+ reviewed

StevenKKC · 2023-08-04T16:24:44Z

@bondydaa Could you please review PR?

bondydaa

I'm going to ask about my comment in slack since I'm not the most up to date on new dot things to make sure I haven't missed or confused something but otherwise things look good. thank you for testing the other spots like the anonymous footer as well!

bondydaa · 2023-08-04T16:49:01Z

src/components/ParentNavigationSubtitle.js

@@ -18,7 +18,7 @@ const propTypes = {
    }).isRequired,

    /** parent Report ID */
-    parentReportID: PropTypes.string,
+    parentReportID: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),


Hmm I thought reportID were always supposed to be strings when they got returned from the API... if this isn't the case something might be broken in the API.

https://expensify.slack.com/archives/C01GTK53T8Q/p1691167905181059

Please check #24113 (comment)
BE returns number type of parentReportID for the task report.

I think we are just missing cases in the backend where these properties should be converted to strings... like parentReportID

For example, the reportID in a report is a string:

We should be consistent on that.

Now... since the backend is wrong, I'm not sure what do in your case... should we fix the backend and put this on hold until that is done? or we fix this in a follow up when we update the backend?

The changes in this commit are not required for this PR, it was added to address this warning, Since this PR does not cause the warning, I think we should revert the changes and make a fix in the backend.

Here is a link to the related bug: https://expensify.slack.com/archives/C049HHMV9SM/p1691035111039979.

@fedirjh Let me revert this commit, what do you think?

@bondydaa @fedirjh Could you please confirm that we should revert this commit?

Yeah let's revert that, we have a PR open right now to fix this so that the BE will return strings.

@bondydaa I have reverted last commit. Can you please review again?

fedirjh · 2023-08-13T18:41:24Z

cc @bondydaa little bump

StevenKKC · 2023-08-15T14:54:45Z

@bondydaa Friendly bump

bondydaa · 2023-08-17T03:34:21Z

doesn't look like the back end PR is merged yet https://github.com/Expensify/Web-Expensify/pull/38444

I think this is okay to merge though, it will just throw a warning if the type is incorrect right, not crash the app or anything?

StevenKKC · 2023-08-17T05:31:29Z

@bondydaa It will just throw a warning. Could you please merge this branch?

OSBotify · 2023-08-17T14:59:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:26:07Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:09:08Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix reply in thread does not have from link in header

e4c9850

StevenKKC requested a review from a team as a code owner August 3, 2023 14:29

melvin-bot bot requested review from fedirjh and removed request for a team August 3, 2023 14:29

StevenKKC mentioned this pull request Aug 3, 2023

[$1000] Web - Reply in thread on messages in 'owes' or 'paid' money reports does not have 'From' link in header #23492

Closed

6 tasks

fix parentReportID prop type warning

d07e5c1

fedirjh approved these changes Aug 4, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa August 4, 2023 16:11

bondydaa reviewed Aug 4, 2023

View reviewed changes

revert last commit

cd4d7db

StevenKKC requested review from fedirjh and bondydaa August 11, 2023 18:41

fedirjh approved these changes Aug 13, 2023

View reviewed changes

bondydaa approved these changes Aug 17, 2023

View reviewed changes

bondydaa merged commit 2e1c4e7 into Expensify:main Aug 17, 2023
13 checks passed

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix reply in thread does not have from link in header #24113

fix reply in thread does not have from link in header #24113

StevenKKC commented Aug 3, 2023 •

edited

Loading

melvin-bot bot commented Aug 3, 2023

StevenKKC commented Aug 4, 2023

fedirjh commented Aug 4, 2023

StevenKKC commented Aug 4, 2023

StevenKKC commented Aug 4, 2023 •

edited

Loading

StevenKKC commented Aug 4, 2023

fedirjh commented Aug 4, 2023

fedirjh commented Aug 4, 2023

fedirjh commented Aug 4, 2023

StevenKKC commented Aug 4, 2023 •

edited

Loading

fedirjh commented Aug 4, 2023

StevenKKC commented Aug 4, 2023

fedirjh left a comment

StevenKKC commented Aug 4, 2023

bondydaa left a comment

bondydaa Aug 4, 2023

bondydaa Aug 4, 2023

StevenKKC Aug 4, 2023

aldo-expensify Aug 4, 2023

fedirjh Aug 4, 2023

StevenKKC Aug 4, 2023

StevenKKC Aug 7, 2023

StevenKKC Aug 7, 2023

bondydaa Aug 9, 2023

StevenKKC Aug 9, 2023

fedirjh commented Aug 13, 2023

StevenKKC commented Aug 15, 2023

bondydaa commented Aug 17, 2023

StevenKKC commented Aug 17, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

fix reply in thread does not have from link in header #24113

fix reply in thread does not have from link in header #24113

Conversation

StevenKKC commented Aug 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 3, 2023

StevenKKC commented Aug 4, 2023

fedirjh commented Aug 4, 2023

StevenKKC commented Aug 4, 2023

StevenKKC commented Aug 4, 2023 • edited Loading

StevenKKC commented Aug 4, 2023

fedirjh commented Aug 4, 2023

Reviewer Checklist

Screenshots/Videos

fedirjh commented Aug 4, 2023

More Tests

fedirjh commented Aug 4, 2023

StevenKKC commented Aug 4, 2023 • edited Loading

fedirjh commented Aug 4, 2023

StevenKKC commented Aug 4, 2023

fedirjh left a comment

Choose a reason for hiding this comment

StevenKKC commented Aug 4, 2023

bondydaa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedirjh commented Aug 13, 2023

StevenKKC commented Aug 15, 2023

bondydaa commented Aug 17, 2023

StevenKKC commented Aug 17, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

StevenKKC commented Aug 3, 2023 •

edited

Loading

StevenKKC commented Aug 4, 2023 •

edited

Loading

StevenKKC commented Aug 4, 2023 •

edited

Loading