-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broaden dependency to prevent PDF upload error #24283
Conversation
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewing this now |
@dangrous Have you tested android? |
Reviewer Checklist
Screenshots/VideosiOSScreen.Recording.2023-08-09.at.12.16.20.AM.movAndroidAndroid.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crash occurs on Android too, fix resolved it on both platforms, only native screens were added as it affects only the same.
LGTM tests well!
(cherry picked from commit 18bdf46)
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.51-1 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀
|
cc @Julesssss since you seem like you worked on the PR that affected this.
Details
It looks like
shouldPagerScroll
doesn't always exist onattachmentCarouselPagerContext
so it's safer to check the whole thing for changes. Given the simplicity of the function it shouldn't hit performance too hard (if at all) due to slightly more redefinings.Fixed Issues
$ #24275
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Here's the important screenshot, I'm testing the others now.
2023-08-08_13-47-39.mp4
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android