-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:21706 remove optimistic user info from personal details list #24355
Conversation
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@aimane-chnaif If we remove optimistic account info, in task assign flow, will occur an bug. But this bug will be fixed in #24078, because is the same root cause. What is your opinion on this? |
I think this already existed as hidden bug in #24078 as the root cause is same. So I'd say our fix doesn't cause regression. Just changes buggy behavior: stale assignee -> no assignee So I don't think we need to hold this for #24078. #24078 also depends on this PR. cc: @bondydaa |
src/libs/actions/Report.js
Outdated
@@ -472,7 +472,7 @@ function openReport(reportID, participantLoginList = [], newReportObject = {}, p | |||
|
|||
// Add optimistic personal details for new participants | |||
const optimisticPersonalDetails = {}; | |||
const failurePersonalDetails = {}; | |||
const removalPersonalDetails = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is incorrect. Maybe settledPersonalDetails
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aimane-chnaif Renamed to settledPersonalDetails
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Still I will defer this to @bondydaa
@StevenKKC lint failing |
@aimane-chnaif Fixed lint error. |
Reviewer Checklist
Screenshots/VideosWebnew.group.movinvite.members.movnew.chat.search.movMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests well.
@bondydaa all yours
@bondydaa Could you please review this PR? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.56-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀
|
Details
Fixed Issues
$ #21706
PROPOSAL: #21706 (comment)
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Web.mp4
Mobile Web - Chrome
Android-Chrome.webm
Mobile Web - Safari
iOS-Safari.webm
Desktop
Desktop.mp4
iOS
iOS.webm
Android
Android.mp4