-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup/23961 edit request autofocus and date #24634
Followup/23961 edit request autofocus and date #24634
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I will handle this one |
Reviewer Checklist
Screenshots/VideosSimple changes, testing on web and mobile web The description autofocus works well too Mobile Web - ChromeDesktopiOSAndroid |
I had actually started on this one @mountiny! |
Sorry for the bother, I will check this one off, if you interested, I can keep you tagged on the issue, there will be more edit request follow ups coming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sounds good! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.55-0 🚀
|
@mountiny I reported that future dates should be disabled when editing an IOU details on August 14th. It seems the issue is fixed here. Is this something I am eligible for bonus reporting? |
@Natnael-Guchima Nope as we knew about this from the beginning of implementation, it was not a bug but just something we decided to implement as a follow up, sorry |
No worries! Thanks, @mountiny 👍 |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.56-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀
|
Details
Fixed Issues
$ #23961
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-08-16.at.20.12.13.mp4
Mobile Web - Chrome
Screen.Recording.2023-08-16.at.19.56.22.mp4
Mobile Web - Safari
Screen.Recording.2023-08-16.at.20.15.30.mp4
Desktop
Screen.Recording.2023-08-16.at.20.05.14.mp4
iOS
Screen.Recording.2023-08-16.at.20.14.16.mp4
Android
Screen.Recording.2023-08-16.at.19.11.49.mp4