[Step 3] Remove CARD_LIST key from NewDot #24637

grgia · 2023-08-16T17:06:50Z

Details

Now that Web is sending user card info to fundList, we can remove the cardList key entirely from App.

App PR that added dual support for cardList and fundList - #23242
Web PR to send data to fundList- https://github.com/Expensify/Web-Expensify/pull/38226

Fixed Issues

$ #23559

Tests

Verify that no errors appear in the JS console
Verify that we no longer reference ONYXKEYS.CARD_LIST
Verified that I updated all the temporary changes in https://github.com/Expensify/App/pull/23242/files

WEB:

For each of the following cases:

Open the console and past these blocks
Go to settings/payments page
Ensure that the correct card is listed.
- Case 1: card Test cardList card ending in 4242 appears

Case 1: user has fundList data

Onyx.merge('fundList',
{
  "4": {
    "title": "Test fundlist card",
    "description": "Card ending in 0000",
    "methodID": 4,
    "key": "card-4",
    "accountType": "debitCard",
    "accountData": {
      "additionalData": {
        "isBillingCard": false,
        "isP2PDebitCard": true
      },
      "addressName": "Test fundlist card",
      "addressState": "US",
      "addressStreet": "Street",
      "addressZip": 75092,
      "cardMonth": 12,
      "cardNumber": "424242XXXXXX0000",
      "cardYear": 2026,
      "created": "2023-01-13 22:27:23",
      "currency": "USD",
      "fundID": 4
    },
    "isDefault": true
  }
}
);


Onyx.set('cardList', null);

Case 2: user has fundList data with errors set

Onyx.merge('fundList',
{
  "4": {
    "errors": {"test": "example error"},
    "title": "Test fundlist card",
    "description": "Card ending in 0000",
    "methodID": 4,
    "key": "card-4",
    "accountType": "debitCard",
    "accountData": {
      "additionalData": {
        "isBillingCard": false,
        "isP2PDebitCard": true
      },
      "addressName": "Test fundlist card",
      "addressState": "US",
      "addressStreet": "Street",
      "addressZip": 75092,
      "cardMonth": 12,
      "cardNumber": "424242XXXXXX0000",
      "cardYear": 2026,
      "created": "2023-01-13 22:27:23",
      "currency": "USD",
      "fundID": 4
    },
    "isDefault": true
  }
}
);


Onyx.set('cardList', null);

Offline tests

QA Steps

Verify that no errors appear in the JS console
Add a debit card, ensure that card is listed on the payments page
Add a second debit card, ensure that card is listed on the payments page
Make the second card the default payment card, ensure that card is set as default card without error
Remove a debit card, ensure that card is removed without error

PR Author Checklist

Screenshots/Videos

Web

Cleared cache, logged in and out. Note ONLY fundList key:

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Emulator not working :(

melvin-bot · 2023-08-16T18:17:14Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav

Code change looks good. I will check if there's any other place where've left out this change.

melvin-bot · 2023-08-17T06:42:56Z

@hayata-suenaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-08-17T13:51:48Z

Tested this in Web, works fine. I am not added to the betas to add the Debit card, but I've manually set the data and checked. I've also forced adding cardList to test if we see any double records, etc. Will finish other platforms in a few hours..

mananjadhav · 2023-08-17T14:26:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mananjadhav · 2023-08-17T17:22:59Z

I am kind of stuck on Android build, as it's taking ages to complete. I'll upload the screenshot as soon as it is ready.

mananjadhav · 2023-08-17T17:35:37Z

@grgia This is complete from my end.

🎀 👀 🎀 C+ reviewed.

hayata-suenaga · 2023-08-17T18:27:50Z

src/pages/settings/Payments/PaymentMethodList.js

-        selectedMethodID,
-        translate,
-    } = props;
+    const {actionPaymentMethodType, activePaymentMethodID, bankAccountList, fundList, filterType, network, onPress, payPalMeData, shouldShowSelectedState, selectedMethodID, translate} =


non blocker: I can't remember if we formally added it, but we have a new style guide to de-structure props inside the function input.

unction PaymentMethodList({actionPaymentMethodType, activePaymentMethodID, ...})

Good to know moving forward! Will merge this for now

OSBotify · 2023-08-17T18:34:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:25:43Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2023-08-23T23:35:37Z

Gonna check this one off I'm able to see my debit card in NewDot so the migration to fundList worked great.

OSBotify · 2023-08-24T03:08:44Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Remove CARD_LIST key

9e042fa

grgia self-assigned this Aug 16, 2023

run prettier

f8895c6

grgia marked this pull request as ready for review August 16, 2023 18:17

grgia requested a review from a team as a code owner August 16, 2023 18:17

melvin-bot bot requested review from mananjadhav and removed request for a team August 16, 2023 18:17

grgia requested a review from marcaaron August 16, 2023 18:17

grgia changed the title ~~Remove CARD_LIST key from NewDot~~ [Step 3] Remove CARD_LIST key from NewDot Aug 16, 2023

mananjadhav approved these changes Aug 17, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga August 17, 2023 06:42

hayata-suenaga reviewed Aug 17, 2023

View reviewed changes

hayata-suenaga approved these changes Aug 17, 2023

View reviewed changes

grgia merged commit 8d11238 into main Aug 17, 2023
13 of 15 checks passed

grgia deleted the georgia-ReplaceCardListWithFundList branch August 17, 2023 18:30

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Step 3] Remove CARD_LIST key from NewDot #24637

[Step 3] Remove CARD_LIST key from NewDot #24637

grgia commented Aug 16, 2023 •

edited

Loading

melvin-bot bot commented Aug 16, 2023

mananjadhav left a comment

melvin-bot bot commented Aug 17, 2023

mananjadhav commented Aug 17, 2023

mananjadhav commented Aug 17, 2023 •

edited by grgia

Loading

mananjadhav commented Aug 17, 2023

mananjadhav commented Aug 17, 2023

hayata-suenaga Aug 17, 2023

grgia Aug 17, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

marcaaron commented Aug 23, 2023

OSBotify commented Aug 24, 2023

[Step 3] Remove CARD_LIST key from NewDot #24637

[Step 3] Remove CARD_LIST key from NewDot #24637

Conversation

grgia commented Aug 16, 2023 • edited Loading

Details

Fixed Issues

Tests

WEB:

Case 1: user has fundList data

Case 2: user has fundList data with errors set

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 16, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 17, 2023

mananjadhav commented Aug 17, 2023

mananjadhav commented Aug 17, 2023 • edited by grgia Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Aug 17, 2023

mananjadhav commented Aug 17, 2023

hayata-suenaga Aug 17, 2023

Choose a reason for hiding this comment

grgia Aug 17, 2023

Choose a reason for hiding this comment

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

marcaaron commented Aug 23, 2023

OSBotify commented Aug 24, 2023

grgia commented Aug 16, 2023 •

edited

Loading

mananjadhav commented Aug 17, 2023 •

edited by grgia

Loading