Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary manual focus #2528

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix: remove unnecessary manual focus #2528

merged 1 commit into from
Apr 22, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Apr 22, 2021 •
edited
Loading

Please review.

Details

Fix the regression https://expensify.slack.com/archives/C01GTK53T8Q/p1619030226468300

Tests / QA Steps

  1. open a chat on Mobile Web and then navigate back to another screen.
  2. Now going back to the chat should not open the keyboard automatically

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

NA

@parasharrajat parasharrajat requested a review from a team as a code owner April 22, 2021 02:46
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team April 22, 2021 02:47
@ctkochan22 ctkochan22 merged commit d06ebd0 into Expensify:main Apr 22, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat parasharrajat mentioned this pull request Apr 22, 2021
Closed
@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the parasharrajat/keyboard-fix branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctkochan22 ctkochan22 ctkochan22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @ctkochan22