Remove unused attachment placeholder code

src/pages/home/report/ReportActionItem.js

@@ -549,7 +549,7 @@ function ReportActionItem(props) {
                         <View
                             style={StyleUtils.getReportActionItemStyle(
                                 hovered || isWhisper || isContextMenuActive || props.draftMessage,
-                                (props.network.isOffline && props.action.isLoading) || props.action.error,
+                                props.action.error,
                             )}
                         >
                             <OfflineWithFeedback

src/pages/home/report/ReportActionItemFragment.js

@@ -1,5 +1,4 @@
 import React, {memo} from 'react';
-import {ActivityIndicator, View} from 'react-native';
 import PropTypes from 'prop-types';
 import Str from 'expensify-common/lib/str';
 import reportActionFragmentPropTypes from './reportActionFragmentPropTypes';
@@ -29,7 +28,7 @@
     fragment: reportActionFragmentPropTypes.isRequired,
 
     /** Is this fragment an attachment? */
     isAttachment: PropTypes.bool,
 
     /** If this fragment is attachment than has info? */
     attachmentInfo: PropTypes.shape({
@@ -46,9 +45,6 @@
         source: PropTypes.string,
     }),
 
-    /** Does this fragment belong to a reportAction that has not yet loaded? */
-    loading: PropTypes.bool,
-
     /** The reportAction's source */
     source: PropTypes.oneOf(['Chronos', 'email', 'ios', 'android', 'web', 'email', '']),
 
@@ -78,7 +74,6 @@
         type: '',
         source: '',
     },
-    loading: false,
     isSingleLine: false,
     source: '',
     style: [],
@@ -89,20 +84,6 @@
 function ReportActionItemFragment(props) {
     switch (props.fragment.type) {
         case 'COMMENT': {
-            // If this is an attachment placeholder, return the placeholder component
-            if (props.isAttachment && props.loading) {
-                return Str.isImage(props.attachmentInfo.name) ? (
-                    <RenderHTML html={`<comment><img src="${props.attachmentInfo.source}" data-expensify-preview-modal-disabled="true"/></comment>`} />
-                ) : (
-                    <View style={[styles.chatItemAttachmentPlaceholder]}>
-                        <ActivityIndicator
-                            size="large"
-                            color={themeColors.textSupporting}
-                            style={[styles.flex1]}
-                        />
-                    </View>
-                );
-            }
             const {html, text} = props.fragment;
 
             // Threaded messages display "[Deleted message]" instead of being hidden altogether.

src/pages/home/report/ReportActionItemMessage.js

@@ -48,7 +48,6 @@ function ReportActionItemMessage(props) {
                         pendingAction={props.action.pendingAction}
                         source={lodashGet(props.action, 'originalMessage.source')}
                         accountID={props.action.actorAccountID}
-                        loading={props.action.isLoading}
                         style={props.style}
                     />
                 ))

src/pages/home/report/ReportActionItemSingle.js

@@ -231,7 +231,6 @@ function ReportActionItemSingle(props) {
                                     accountID={actorAccountID}
                                     fragment={fragment}
                                     isAttachment={props.action.isAttachment}
-                                    isLoading={props.action.isLoading}
                                     delegateAccountID={props.action.delegateAccountID}
                                     isSingleLine
                                     actorIcon={icon}

src/pages/home/report/reportActionPropTypes.js

@@ -23,9 +23,6 @@ export default {
         IOUTransactionID: PropTypes.string,
     }),
 
-    /** Whether we have received a response back from the server */
-    isLoading: PropTypes.bool,
-
     /** Error message that's come back from the server. */
     error: PropTypes.string,
 

src/styles/StyleUtils.js

@@ -637,18 +637,18 @@ function getLoginPagePromoStyle() {
  * Generate the styles for the ReportActionItem wrapper view.
  *
  * @param {Boolean} [isHovered]
- * @param {Boolean} [isLoading]
+ * @param {Boolean} [hasError]
  * @returns {Object}
  */
-function getReportActionItemStyle(isHovered = false, isLoading = false) {
+function getReportActionItemStyle(isHovered = false, hasError = false) {
     return {
         display: 'flex',
         justifyContent: 'space-between',
         backgroundColor: isHovered
             ? themeColors.hoverComponentBG
             : // Warning: Setting this to a non-transparent color will cause unread indicator to break on Android
               colors.transparent,
-        opacity: isLoading ? 0.5 : 1,
+        opacity: hasError ? 0.5 : 1,
         ...styles.cursorInitial,
     };
 }