Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] [TS Migration] migrate containerComposeStyles style to TypeScript #25920

Merged
merged 4 commits into from
Sep 12, 2023
Merged

[No QA] [TS Migration] migrate containerComposeStyles style to TypeScript #25920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92df740
migrate containerComposeStyles to TypeScript
JKobrynski Aug 25, 2023
4f87eca
simplify the type
JKobrynski Aug 25, 2023
e9ff569
change type to satisfy View
JKobrynski Sep 4, 2023
aeeaf2d
apply changes based on feedback from code review
JKobrynski Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/styles/containerComposeStyles/index.native.js
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions src/styles/containerComposeStyles/index.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import {StyleProp, ViewStyle} from 'react-native';
import styles from '../styles';

const containerComposeStyles: StyleProp<ViewStyle> = [styles.textInputComposeSpacing];

export default containerComposeStyles;
3 changes: 2 additions & 1 deletion src/styles/containerComposeStyles/index.js → src/styles/containerComposeStyles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {StyleProp, ViewStyle} from 'react-native';
import styles from '../styles';

// We need to set paddingVertical = 0 on web to avoid displaying a normal pointer on some parts of compose box when not in focus
const containerComposeStyles = [styles.textInputComposeSpacing, {paddingVertical: 0}];
const containerComposeStyles: StyleProp<ViewStyle> = [styles.textInputComposeSpacing, {paddingVertical: 0}];

export default containerComposeStyles;
Loading