Fix Chat - Notification is NOT received in the main device after Control policy was created

[hungvu193]

Details

Fix Chat - Notification is NOT received in the main device after Control policy was created

Fixed Issues

$ #23234
PROPOSAL: #23234 (comment)

Tests

1. From account A, create a new room, change the notification preference to Immediately
2. From account B, join the room and send any message.
3. From account A, verify that's there's notification displays or verify that there's no console error displays

• Verify that no errors appear in the JS console

Offline tests

This bug is not related to offline mode.

QA Steps

1. From account A, create a new room, change the notification preference to Immediately
2. From account B, join the room and send any message.
3. From account A, verify that's there's notification displays or verify that there's no console error displays

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

trim.406B6DA9-31C0-42CF-9ADA-AEE67F922949.MOV

Mobile Web - Safari

trim.805904E0-F8D8-433B-BF50-F4ADDC9391BB.MOV

Desktop

iOS

Android

[melvin-bot]

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

@mananjadhav Please take a look, I'll complete the screenshots today

[hungvu193]

Do you know how to test it on Safari and mWeb chrome? @mananjadhav

[danieldoglas]

@mananjadhav can you please test this against other normal reports? Creating a new account and sending a new message from it.

I'm worried this might break other types of chats or show the wrong name in the notification for those.

[mananjadhav]

@danieldoglas I am still testing this, I'll finish the checklist by tomorrow.

[mananjadhav]

for some reason I am not getting any notifications from the local build. @danieldoglas Is it possible to get an adhoc build triggered for this one?

[hungvu193]

Same here, I recently can not receive any notification for adhoc build, only Desktop is working for me.

[danieldoglas]

hmm, I don't know exactly. Can you post it in #open-source? Maybe it was something we merged recently

[hungvu193]

hey can you create a slack post? @mananjadhav

[danieldoglas]

@hungvu193 @mananjadhav how's this one going?

[hungvu193]

Can we build a prod version from this PR? I currently cant test the notification on adhoc build.

[mountiny]

Can we build a prod version from this PR? I currently cant test the notification on adhoc build.

There is no way to do that

[mountiny]

Creating the adhoc build https://github.com/Expensify/App/actions/runs/6434201515

not sure if that is what you meant with the production version :D

[OSBotify]

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/26358/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/26358/NewExpensify.dmg	https://26358.pr-testing.expensify.com

[hungvu193]

So it was creating notification without any errors, but I couldn't see the browser notification. Not sure why it happened 😮‍💨

[hungvu193]

can we move forward with this PR? The expected result should be, there's no console error when receiving notification from room.
Before:

After:

[mountiny]

@mananjadhav can you please fill out the checklist and test this in the adhoc build on web/dektop? Thank you

[mananjadhav]

Yes I'll do that today.

[mananjadhav]

@mountiny Can you help with the Desktop dmg? I am getting Access denied here.

[mountiny]

@mananjadhav same :/

I will go ahead this is a simple change

[mountiny]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A Small change which is tough to test locally, contributor has shown the console error disappears

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1225.413 ms → 1338.895 ms (+113.482 ms, +9.3%) 🔴
App start runJsBundle	837.495 ms → 925.055 ms (+87.560 ms, +10.5%) 🔴

Show details

Name	Duration
App start TTI	Baseline Mean: 1225.413 ms Stdev: 47.787 ms (3.9%) Runs: 1118.9125140001997 1126.995928000193 1131.6548649999313 1146.5062380000018 1149.9511859999038 1151.1293170000426 1153.456491000019 1157.802083000075 1160.5573900002055 1169.9159889998846 1171.541900999844 1172.426878000144 1173.9304289999418 1175.1231479998678 1175.4233180000447 1175.5537789999507 1178.4996259999461 1181.594223999884 1181.6707509998232 1182.4386849999428 1182.4609199999832 1182.711228999775 1182.94444799982 1187.9221049998887 1189.6569579998031 1192.7972789998166 1198.9213060000911 1200.7720369999297 1200.9320990000851 1201.4818339999765 1202.9775979998522 1204.6129660001025 1207.967813000083 1210.216791999992 1210.7987950001843 1212.1432759999298 1212.6527030002326 1213.2535069999285 1215.6510720001534 1215.9046880002134 1216.9037469998002 1218.9512849999592 1219.0504839997739 1226.5972509998828 1227.2873260001652 1227.7029050001875 1229.482309000101 1229.5773450001143 1229.5822870000266 1230.097945000045 1234.8440330000594 1238.232890999876 1238.2733590002172 1238.7400320000015 1239.423527999781 1239.6569099999033 1241.8614010000601 1242.4820739999413 1243.5317660002038 1246.6248650001362 1246.9630990000442 1249.1608669999987 1249.202409000136 1250.4368850002065 1251.6365399998613 1251.91927199997 1252.0739389997907 1254.448253000155 1263.3788060001098 1263.5293879997917 1263.6113629997708 1264.3691920000128 1264.7975889998488 1266.4447829998098 1273.0628800000995 1276.880111000035 1276.9838890000246 1279.0593820000067 1279.5459969998337 1279.918663999997 1279.95881799981 1281.7252259999514 1281.7931130002253 1283.1579309999943 1293.377142000012 1301.9339620000683 1304.1124350000173 1309.941523999907 1317.2388690002263 1317.3860010001808 1363.738504999783 Current Mean: 1338.895 ms Stdev: 74.880 ms (5.6%) Runs: 1206.9566390002146 1210.435254999902 1218.7308769999072 1222.7263259999454 1227.6277089999057 1232.8819200000726 1233.1984399999492 1239.1901569999754 1242.2592170001008 1244.3720149998553 1247.2231700001284 1249.8315679999068 1251.1695730001666 1251.3588029998355 1253.8016800000332 1255.004060999956 1256.519559000153 1256.6379599999636 1257.662487000227 1258.1856280001812 1263.2834740001708 1264.194327000063 1264.6759500000626 1266.1849589999765 1266.2467840001918 1274.9320840002038 1276.0070440000854 1276.6758759999648 1276.687752999831 1278.1097099999897 1284.0470969998278 1289.8943110001273 1293.0828320002183 1301.125097999815 1305.293316999916 1306.8579719997942 1308.2204900002107 1311.0417800000869 1311.1749559999444 1313.9355660001747 1333.0071780001745 1338.834557000082 1339.286055999808 1342.1479420000687 1342.8654060000554 1356.0776089997962 1356.9570690002292 1357.284539999906 1359.3235410000198 1363.7609109999612 1365.3648640001193 1368.3774919998832 1372.255152999889 1372.4964959998615 1375.706096000038 1375.921122000087 1379.5978489997797 1381.6475289999507 1382.9067119997926 1384.231606000103 1385.318440000061 1385.7336169998161 1386.7941160001792 1387.2553759999573 1391.2810459998436 1391.8419699999504 1393.964778999798 1394.9689839999191 1399.5304279997945 1401.2473630001768 1406.970379000064 1407.7867640000768 1410.7354100001976 1411.4021220002323 1411.7142449999228 1417.928846000228 1423.623186999932 1423.74069100013 1426.7891790000722 1426.9002979998477 1427.360140999779 1429.7197380000725 1435.266119999811 1438.7414580001496 1440.137285000179 1441.9063960001804 1442.0821380000561 1447.1631709998474 1453.3223080001771 1471.9581900001504 1530.7282289997675
App start runJsBundle	Baseline Mean: 837.495 ms Stdev: 40.956 ms (4.9%) Runs: 723 743 744 746 753 770 781 786 786 789 789 791 797 799 801 801 804 806 807 807 810 811 811 811 812 816 817 818 819 821 821 822 825 828 828 828 829 829 830 832 832 832 837 839 839 840 840 844 845 845 846 846 847 848 848 848 849 850 852 853 854 856 856 856 857 862 863 863 868 871 872 874 874 877 879 880 881 882 882 882 882 883 888 889 892 892 901 906 913 919 937 Current Mean: 925.055 ms Stdev: 47.253 ms (5.1%) Runs: 843 848 852 855 855 860 860 861 862 862 863 867 869 870 870 870 873 873 874 877 878 879 883 883 885 888 890 890 892 893 894 896 896 896 903 903 905 906 911 916 917 920 922 923 926 926 930 930 931 937 937 938 939 942 942 944 944 946 947 950 950 953 955 956 957 957 962 963 967 968 969 972 972 972 975 976 976 978 979 980 982 983 985 990 997 1001 1005 1012 1013 1014 1019

Meaningless Changes To Duration

Show entries

Name	Duration
Open Search Page TTI	623.425 ms → 625.932 ms (+2.507 ms, ±0.0%)
App start regularAppStart	0.015 ms → 0.016 ms (+0.001 ms, +6.4%)
App start nativeLaunch	22.427 ms → 22.213 ms (-0.213 ms, -1.0%)

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 623.425 ms Stdev: 14.883 ms (2.4%) Runs: 600.2191980001517 601.2110599996522 602.5261640003882 602.7414549998939 606.1928309998475 606.5871580000967 606.7391360001639 606.8137210002169 607.3398029999807 607.4145909999497 607.4734699996188 607.756510999985 608.1182049997151 608.2043059999123 608.9506840002723 609.118896999862 609.9286699998192 610.741578000132 610.9674889999442 611.1376550002024 611.8833820000291 611.9083249997348 613.5496020000428 613.6891279998235 613.6983239999972 613.7502040001564 613.8041590000503 613.9606940001249 614.3116869996302 614.4345300002024 614.688355000224 614.8492020000704 615.0787760000676 615.6000169999897 615.6716310000047 616.2406009999104 616.3124190000817 618.6950280000456 619.1395260002464 619.2324230000377 619.3208420001902 619.4334309999831 619.9282639999874 620.3592530000024 620.8127439999953 621.3103029998019 621.4366060001776 621.8636070000939 622.2869469998404 622.8280850001611 623.3341879998334 623.8150639999658 623.9106449997053 623.9539799997583 624.4508870001882 624.5637620002963 625.3471689997241 626.8820399995893 627.187826000154 628.6264650002122 628.7508950000629 628.8227949999273 628.9219979997724 629.0032150000334 631.7038980000652 631.9904789999127 632.1115319998935 632.7064209999517 633.5464679999277 633.5826829997823 634.6544189997949 636.3180339997634 636.3424069997855 636.9949550000019 637.7810060000047 638.7547200000845 639.1901449998841 645.8077400000766 646.4545090002939 647.0279539995827 648.3254809998907 649.5813810001127 653.078451000154 655.7868249998428 657.8980710003525 658.2814939999953 661.6545819998719 663.988851999864 Current Mean: 625.932 ms Stdev: 16.057 ms (2.6%) Runs: 596.6293140002526 598.2392579996958 599.7894290001132 600.7094330000691 604.4752199999057 606.3822439997457 606.4563400000334 606.5421959999949 606.9004730000161 607.0577389998361 607.4434409998357 608.7408449999057 608.8768319999799 608.8790699997917 609.5888269999996 609.9672440001741 610.115438000299 610.3755699996836 610.7765299999155 612.7488609999418 613.1425789999776 613.1805829997174 614.3061119997874 614.3915610001422 614.4870210001245 614.8825679998845 615.5261240000837 617.8157150000334 618.3662920002826 618.6314699999057 618.9300130000338 619.0684819999151 619.187663000077 620.0728350002319 620.2367759998888 620.4194750003517 620.5153819997795 621.3983160001226 621.6589359999634 622.5198570000939 622.840046999976 623.0356449997053 623.3167319996282 623.4861659999005 623.7630210001953 623.8517660000362 624.1855879998766 624.9482010002248 625.1560470000841 625.6553960000165 625.6743569998071 625.915811999701 625.9180909995921 626.256510999985 626.3569339998066 626.438965999987 626.9629319999367 627.2189950002357 627.2853600000963 627.5542810000479 628.1940520000644 629.5629480001517 631.1872159997001 631.2805180000141 632.4329429999925 633.0192459998652 633.4866949999705 633.8146979999729 634.4631350003183 635.1163739999756 637.6813559997827 638.544311999809 639.3254390000366 639.5268969996832 639.574951000046 640.6789550003596 640.7499599996954 643.0350750000216 647.0209969999269 648.4296059999615 649.1147469999269 650.4930829997174 651.1654460001737 652.4883630000986 653.906413000077 655.6316730002873 656.6761070000939 658.8415939998813 664.2084959996864 666.2873539999127 668.597534999717
App start regularAppStart	Baseline Mean: 0.015 ms Stdev: 0.001 ms (6.4%) Runs: 0.012532999739050865 0.013142999727278948 0.013264999724924564 0.0134680001065135 0.013509000185877085 0.013509000185877085 0.013549000024795532 0.013590000104159117 0.013671999797224998 0.013671999797224998 0.013672000262886286 0.013753999955952168 0.013753999955952168 0.013793000020086765 0.013874999713152647 0.013956000097095966 0.014037999790161848 0.014039000030606985 0.01411899970844388 0.014159999787807465 0.014159999787807465 0.014241999946534634 0.014241999946534634 0.014322999864816666 0.014322999864816666 0.014322999864816666 0.01436399994418025 0.014403999783098698 0.014404000248759985 0.01444500032812357 0.014485999941825867 0.014525999780744314 0.014526000246405602 0.014527000021189451 0.014566999860107899 0.014607000164687634 0.014607999939471483 0.014688999857753515 0.014688999857753515 0.0147299999371171 0.014810999855399132 0.014812000095844269 0.014851999934762716 0.0148930000141263 0.014933000318706036 0.014973999932408333 0.014973999932408333 0.015014000236988068 0.015015000011771917 0.015054999850690365 0.01509599993005395 0.015137000009417534 0.015137000009417534 0.015177000313997269 0.015217999927699566 0.015217999927699566 0.015218000393360853 0.01525900000706315 0.01525900000706315 0.015298999845981598 0.015381000004708767 0.015381000004708767 0.015381000004708767 0.015381000004708767 0.015420999843627214 0.015422000084072351 0.015543000306934118 0.015544000081717968 0.015583999920636415 0.015665000304579735 0.015705999918282032 0.015705999918282032 0.015829000156372786 0.015829000156372786 0.015868999995291233 0.015951000154018402 0.01599099999293685 0.016032000072300434 0.016113999765366316 0.01615400006994605 0.016193999908864498 0.016235999763011932 0.016316999681293964 0.016478999983519316 0.016478999983519316 0.016764000058174133 0.016846000216901302 0.017009000293910503 0.017374000046402216 Current Mean: 0.016 ms Stdev: 0.001 ms (6.7%) Runs: 0.0133050000295043 0.013794000260531902 0.0138349998742342 0.013957000337541103 0.01399700017645955 0.01411899970844388 0.014241000171750784 0.014282000251114368 0.014323000330477953 0.01436399994418025 0.014444999862462282 0.014527000021189451 0.01464799977838993 0.014688999857753515 0.0147299999371171 0.014851999934762716 0.01497400039806962 0.015015000011771917 0.015054999850690365 0.015137000009417534 0.015137000009417534 0.015177000313997269 0.015217999927699566 0.015217999927699566 0.015217999927699566 0.01525900000706315 0.01525900000706315 0.015339999925345182 0.015461999922990799 0.015461999922990799 0.015462000388652086 0.015503000002354383 0.015583999920636415 0.015625 0.015625 0.015705999918282032 0.015705999918282032 0.01570699969306588 0.015746999997645617 0.015747999772429466 0.01590899983420968 0.015951000154018402 0.01599099999293685 0.016031999606639147 0.016032000072300434 0.01607199991121888 0.016153999604284763 0.01615400006994605 0.016195000149309635 0.01623500045388937 0.01631700014695525 0.016358000226318836 0.016397999599575996 0.016398000065237284 0.016398000065237284 0.01652099983766675 0.016561000142246485 0.016561000142246485 0.016600999981164932 0.01660200022161007 0.016642000060528517 0.016642000060528517 0.016642000060528517 0.016682999674230814 0.016682999674230814 0.0166830001398921 0.01672299997881055 0.0167239997535944 0.016764000058174133 0.016764000058174133 0.016764999832957983 0.01676500029861927 0.01680499967187643 0.016805000137537718 0.016846000216901302 0.016887000296264887 0.016926999669522047 0.01696799974888563 0.01696800021454692 0.017008000053465366 0.017374999821186066 0.017577999737113714 0.017578000202775 0.018554999958723783 0.01887999987229705
App start nativeLaunch	Baseline Mean: 22.427 ms Stdev: 3.246 ms (14.5%) Runs: 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 25 25 25 26 26 26 26 26 27 27 27 28 28 29 30 30 31 31 31 Current Mean: 22.213 ms Stdev: 2.924 ms (13.2%) Runs: 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 26 26 26 26 27 27 27 28 28 29 29 29 29 30 30

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[mountiny]

False positive

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[hungvu193]

Thanks for pushing this forward @mountiny 🙏 . I was stuck for weeks to test the notification 😢

[mountiny]

Thank YOU!

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅