Translate the MODIFIEDEXPENSE messages #26370

hungvu193 · 2023-08-31T08:20:43Z

Details

Translate the MODIFIEDEXPENSE messages

Fixed Issues

$ #26369
PROPOSAL: #26369 (comment)

Tests

Create money request
Edit some of its values
Change language to Spanish
Verify the modified expense messages are translated to Spanish

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Create money request
Edit some of its values
Change language to Spanish
Verify the modified expense messages are translated to Spanish

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-31.at.15.35.32.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-08-31.at.15.35.32.mov

iOS

Android

melvin-bot · 2023-08-31T09:07:08Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2023-08-31T09:09:10Z

@ntdiary PR is ready for review, please have a look. Ty.
I'm using google translate for Spanish translation, so if you know someone can verify it, that will be cool 😎
cc @mountiny

mountiny · 2023-08-31T09:17:08Z

Can you post your proposed translation in the slack thread? thanks

hungvu193 · 2023-08-31T09:33:18Z

Can you post your proposed translation in the slack thread? thanks

Sure. Posted!

ntdiary · 2023-08-31T11:17:46Z

just tested the code, it works well. I think once these translations are confirmed we can continue to move forward.

Additionally, these translations are also used for the LHN list and clipboard, so also checked these places

ntdiary · 2023-08-31T16:36:16Z

it seems we need to wait for the marketing team to confirm the translation?

cc @mountiny

hungvu193 · 2023-09-02T03:53:16Z

Yeah, waiting for confirmation from slack thread then I'll update the translation.

hungvu193 · 2023-09-04T16:45:41Z

Updated the translation according the slack convo

ntdiary · 2023-09-04T17:18:12Z

Hi, @hungvu193, it looks like the only difference between *Request and *Merchant is la or el, so I think using ternary operator would be enough 😂
e.g.

setTheRequest: ({valueName, newValueToDisplay}) =>  `estableció ${valueName === 'comerciante' ? 'el' : 'la'} ${valueName} a ${newValueToDisplay}`

hungvu193 · 2023-09-05T02:32:40Z

Hi, @hungvu193, it looks like the only difference between *Request and *Merchant is la or el, so I think using ternary operator would be enough 😂 e.g.
setTheRequest: ({valueName, newValueToDisplay}) =>  `estableció ${valueName === 'comerciante' ? 'el' : 'la'} ${valueName} a ${newValueToDisplay}`

that makes sense 😂 , I'll update it in couple of hours.

hungvu193 · 2023-09-05T05:18:12Z

@ntdiary Updated!

ntdiary · 2023-09-05T06:50:58Z

LGTM, just a s small suggestion, we can add the verified step for Tests : )

Create money request
Edit some of its values
Change language to Spanish
Verify the modified expense messages are translated to Spanish

hungvu193 · 2023-09-05T06:52:41Z

LGTM, just a s small suggestion, we can add the verified step for Tests : )

Create money request

Edit some of its values

Change language to Spanish

Verify the modified expense messages are translated to Spanish

Thank you. Not sure why I missed the verify step 🤦
Updated btw.

ntdiary · 2023-09-05T06:53:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

26370-web.mp4

Mobile Web - Chrome

26370-android-chrome.mp4

Mobile Web - Safari

26370-ios-safari.mp4

Desktop

26370-desktop.mp4

iOS

26370-ios-app.mp4

Android

26370-android-app.mp4

hungvu193 · 2023-09-11T06:47:29Z

Re-tested and merged with main
cc @mountiny

update Spanish for modify expense message update the merchant add check case for merchant fix linting

mountiny

Looking good, going to merge this one

OSBotify · 2023-09-11T08:43:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-12T00:17:31Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-13T08:43:58Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

hungvu193 marked this pull request as ready for review August 31, 2023 09:07

hungvu193 requested a review from a team as a code owner August 31, 2023 09:07

melvin-bot bot requested review from ntdiary and removed request for a team August 31, 2023 09:07

ntdiary approved these changes Sep 5, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny September 5, 2023 06:54

ntdiary approved these changes Sep 5, 2023

View reviewed changes

mountiny assigned hungvu193 Sep 5, 2023

mountiny changed the title ~~Translate the MODIFIEDEXPENSE messages~~ [HOLD freeze] Translate the MODIFIEDEXPENSE messages Sep 5, 2023

hungvu193 added 2 commits September 11, 2023 15:08

update translation for modify expense

f9171ab

update Spanish for modify expense message update the merchant add check case for merchant fix linting

update singing commit

3db0427

hungvu193 force-pushed the feature/26369 branch from dac2d87 to 3db0427 Compare September 11, 2023 08:13

hungvu193 changed the title ~~[HOLD freeze] Translate the MODIFIEDEXPENSE messages~~ Translate the MODIFIEDEXPENSE messages Sep 11, 2023

mountiny approved these changes Sep 11, 2023

View reviewed changes

mountiny merged commit 7f5c14a into Expensify:main Sep 11, 2023

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

melvin-bot bot mentioned this pull request Sep 13, 2023

[HOLD for payment 2023-09-20] [$250] Translate the MODIFIEDEXPENSE messages #26369

Closed

6 tasks

abzokhattab mentioned this pull request Oct 5, 2024

[Awaiting checklist] [$125] Expense - "Set the amount" system message not correctly translated into Spanish #50287

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translate the MODIFIEDEXPENSE messages #26370

Translate the MODIFIEDEXPENSE messages #26370

hungvu193 commented Aug 31, 2023 •

edited

Loading

melvin-bot bot commented Aug 31, 2023

hungvu193 commented Aug 31, 2023

mountiny commented Aug 31, 2023

hungvu193 commented Aug 31, 2023

ntdiary commented Aug 31, 2023

ntdiary commented Aug 31, 2023

hungvu193 commented Sep 2, 2023

hungvu193 commented Sep 4, 2023

ntdiary commented Sep 4, 2023 •

edited

Loading

hungvu193 commented Sep 5, 2023

hungvu193 commented Sep 5, 2023

ntdiary commented Sep 5, 2023

hungvu193 commented Sep 5, 2023

ntdiary commented Sep 5, 2023 •

edited

Loading

hungvu193 commented Sep 11, 2023

mountiny left a comment

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

Translate the MODIFIEDEXPENSE messages #26370

Translate the MODIFIEDEXPENSE messages #26370

Conversation

hungvu193 commented Aug 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 31, 2023

hungvu193 commented Aug 31, 2023

mountiny commented Aug 31, 2023

hungvu193 commented Aug 31, 2023

ntdiary commented Aug 31, 2023

ntdiary commented Aug 31, 2023

hungvu193 commented Sep 2, 2023

hungvu193 commented Sep 4, 2023

ntdiary commented Sep 4, 2023 • edited Loading

hungvu193 commented Sep 5, 2023

hungvu193 commented Sep 5, 2023

ntdiary commented Sep 5, 2023

hungvu193 commented Sep 5, 2023

ntdiary commented Sep 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Sep 11, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

hungvu193 commented Aug 31, 2023 •

edited

Loading

ntdiary commented Sep 4, 2023 •

edited

Loading

ntdiary commented Sep 5, 2023 •

edited

Loading