-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Fix markPullRequestsAsDeployed #26372
Conversation
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still very new to this stuff but I looked at all of it carefully and I think it's good to go.
.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.js
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosN/A GH actions only WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.62-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀
|
Details
This PR accomplishes three things:
markPullRequestsAsDeployed
to useasync
/await
for better claritymarkPullRequestsAsDeployed
Determining whether a deployed PR was cherry-picked or deployed via a standard staging deploy.
Merge PR #\d+ from branch cherry-pick-staging-.*
. This stopped working when we implemented the branch dance and stopped using pull requests to CP code to staging.-x
flag passed togit cherry-pick
will always contain a suffix like(cherry picked from commit .*)
.Determining who is the deployer for cherry-picked PRs
github.actor
(i.e: the person who triggered the workflow) in the branch name for cherry-picked PRs. We would use that to determine the deployer. That also stopped working when we stopped using PRs to CP stuff.cherryPick.yml
workflow to switch the git user withgit config user.name ${{ github.actor }}
before running the CP. Then we switch the git user back toOSBotify
right after (because onlyOSBotify
can push code tostaging
). This does mean that CP commits are unsigned (sinceOSBotify
doesn't have the signing key for thegithub.actor
), but that's not a problem because we lifted the signed commits requirement on staging. So this means that commits will appear as authored by the original author, committed by thegithub.actor
, and pushed byOSBotify
. Then we can look at thecommit.committer
to determine the deployer.Fixed Issues
$ (partial) #21763
Tests
Also added automated tests.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android