Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update CONTRIBUTING.md #26379

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[No QA] Update CONTRIBUTING.md #26379

merged 1 commit into from
Sep 1, 2023

Conversation

greg-schroeder
Copy link
Contributor

Adjusting guidelines to match new payment amounts for bug reporting

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/308678

Can you confirm this looks ok @thienlnam?

@greg-schroeder greg-schroeder requested a review from a team as a code owner August 31, 2023 10:45
@melvin-bot melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team August 31, 2023 10:45
@greg-schroeder greg-schroeder removed the request for review from Santhosh-Sellavel August 31, 2023 10:45
@Expensify Expensify deleted a comment from melvin-bot bot Aug 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@thienlnam
Copy link
Contributor

These current changes look good, but is another spot we mention the price right? Or maybe we only mention the reporting bonus?

@greg-schroeder
Copy link
Contributor Author

greg-schroeder commented Aug 31, 2023

@thienlnam I went through and tried to find another place we mentioned it but I couldn't. We reference $1k in the C+ article but just as a random example, it's not stating that's what the baseline is.

I searched all of E/App for other references to $1k or $250 and couldn't find any others that were relevant

@thienlnam
Copy link
Contributor

Yeah sounds good - I'm going to test something to see if it can catch stuff

@thienlnam
Copy link
Contributor

Okay looks good - after feeding some files to ChatGPT it seems like those are the main mentions of the price.

In HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md it mentions

... C+ are compensated the same price as the contributor for reviewing proposals and the associated PR. (ie. if a job is listed at $1000, that’s how much the C+ will make if they review both the proposals and PR). If regressions are found that should have* been caught after the PR has ...

But I think that's fine as is

@thienlnam
Copy link
Contributor

@greg-schroeder Can you sign the CLA by adding this in a comment?

I have read the CLA Document and I hereby sign the CLA

@greg-schroeder
Copy link
Contributor Author

Okay looks good - after feeding some files to ChatGPT it seems like those are the main mentions of the price.

In HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md it mentions

... C+ are compensated the same price as the contributor for reviewing proposals and the associated PR. (ie. if a job is listed at $1000, that’s how much the C+ will make if they review both the proposals and PR). If regressions are found that should have* been caught after the PR has ...

But I think that's fine as is

Yeah I referenced that here, I think it's fine.

@greg-schroeder
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@puneetlath puneetlath merged commit f74b332 into main Sep 1, 2023
10 of 13 checks passed
@puneetlath puneetlath deleted the greg-schroeder-patch-1 branch September 1, 2023 14:17
@melvin-bot melvin-bot bot added the Emergency label Sep 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor

Documentation update only, so checklists weren't relevant.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2023

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.62-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 4, 2023

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants