-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update CONTRIBUTING.md #26379
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
These current changes look good, but is another spot we mention the price right? Or maybe we only mention the reporting bonus? |
@thienlnam I went through and tried to find another place we mentioned it but I couldn't. We reference $1k in the C+ article but just as a random example, it's not stating that's what the baseline is. I searched all of E/App for other references to $1k or $250 and couldn't find any others that were relevant |
Yeah sounds good - I'm going to test something to see if it can catch stuff |
Okay looks good - after feeding some files to ChatGPT it seems like those are the main mentions of the price. In ... C+ are compensated the same price as the contributor for reviewing proposals and the associated PR. (ie. if a job is listed at $1000, that’s how much the C+ will make if they review both the proposals and PR). If regressions are found that should have* been caught after the PR has ... But I think that's fine as is |
@greg-schroeder Can you sign the CLA by adding this in a comment?
|
Yeah I referenced that here, I think it's fine. |
I have read the CLA Document and I hereby sign the CLA |
@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Documentation update only, so checklists weren't relevant. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.62-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀
|
Adjusting guidelines to match new payment amounts for bug reporting
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/308678
Can you confirm this looks ok @thienlnam?