Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix Modal animations" #2663

Merged
merged 1 commit into from
May 3, 2021
Merged

Revert "fix Modal animations" #2663

merged 1 commit into from
May 3, 2021

Conversation

roryabraham
Copy link
Contributor

Reverts #2505, because it caused this regression

@roryabraham roryabraham requested a review from a team May 1, 2021 01:16
@roryabraham roryabraham self-assigned this May 1, 2021
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team May 1, 2021 01:16
@roryabraham roryabraham mentioned this pull request May 1, 2021
Merged
5 tasks
@NikkiWines NikkiWines merged commit 502bc38 into main May 3, 2021
@NikkiWines NikkiWines deleted the revert-2505-parasharrajat-animation branch May 3, 2021 15:59
@OSBotify OSBotify mentioned this pull request May 3, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2021

🚀 Deployed to staging in version: 1.0.35-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @NikkiWines