26121-remove-domain-name #26638

pradeepmdk · 2023-09-04T07:41:39Z

Details

Fixed Issues

$ #26121
PROPOSAL: #26121 (comment)

Tests

For WorkSpace

Open https://staging.new.expensify.com/
Log in with any of your logins
Create a new workspace or open an existing one
Open the workspace & click on "Members"
Click on 'Invite' button
Search for an invalid phone number (+2523234211)
Select the user > click on "Next" > click on "Invite"
Select the user & click on the "Remove" button
Click on 'Invite' button

For Request Money

Open the Request money from the fab menu
go to offline
Create Request money with invalid phone number (either manual or distance)
Verify the displayname without the domain name

For Split bill

open the Split bill from the fab menu
go to offline
Create split money with invalid phone number
Verify the displayname without the domain name

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-04.at.12.57.52.PM.mov

Screen.Recording.2023-09-05.at.1.23.08.PM.mov

Mobile Web - Chrome

WhatsApp.Video.2023-09-04.at.1.02.51.PM.mp4

WhatsApp.Video.2023-09-05.at.1.31.46.PM.mp4

Mobile Web - Safari

WhatsApp.Video.2023-09-04.at.1.00.12.PM.mp4

WhatsApp.Video.2023-09-05.at.1.28.40.PM.mp4

Desktop

Screen.Recording.2023-09-04.at.1.04.58.PM.mov

Screen.Recording.2023-09-05.at.1.25.10.PM.mov

iOS

Screen.Recording.2023-09-04.at.1.09.11.PM.mov

Screen.Recording.2023-09-05.at.1.34.36.PM.mov

Android

Record_2023-09-04-12-55-49.mp4

Record_2023-09-05-13-07-26.mp4

melvin-bot · 2023-09-04T07:41:44Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-09-04T16:46:10Z

@pradeepmdk Could correctly link your proposal in the description? Thanks!

Could you also add the test for the IOU case?

pradeepmdk · 2023-09-05T08:07:01Z

@mollfpr all updated

mollfpr · 2023-09-05T12:24:17Z

@pradeepmdk I'm proposing to update the test case to 3 parts, since you have fix all the optimistic data on invite member to workspace, request money, and split bill.

Adding members to the workspace
Create Request money and Split bill from the FAB button with an invalid phone number while offline and verify the display name in the report doesn't have the domain

Update: We can give an option for testing on request money, which can be manual or on distance.

pradeepmdk · 2023-09-05T13:38:16Z

@mollfpr updated

mollfpr · 2023-09-05T14:04:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

26638.Web.-.Invite.Member.Workspace.mp4

26638.Web.-.Split.Bill.mp4

26638.Web.-.Request.Money.mp4

Mobile Web - Chrome

26638.mWeb-Chrome.-.Invite.Member.Workspace.mp4

26638.mWeb-Chrome.-.Request.Money.mp4

26638.mWeb-Chrome.-.Split.Bill.mp4

Mobile Web - Safari

Desktop

26638.Desktop.-.Invite.Member.Workspace.mp4

26638.Desktop.-.Split.Bill.mp4

26638.Desktop.-.Request.Money.mp4

iOS

26638.iOS.-.Request.Money.mp4

26638.iOS.-.Split.Bill.mp4

26638.iOS.-.Invite.Member.Workspace.mp4

Android

26638.Android.-.Invite.Member.Workspace.mp4

26638.Android.-.Request.Money.mp4

26638.Android.-.Split.Bill.mp4

mollfpr

LGTM and tests well 👍

Li357 · 2023-09-11T13:35:35Z

@mollfpr Are you able to merge main and retest this to confirm everything still works after the merge freeze?

mollfpr · 2023-09-11T13:52:57Z

@Li357 Sure!

mollfpr · 2023-09-11T14:13:55Z

@Li357 Tested on all platforms. It seems still looking good!

OSBotify · 2023-09-11T14:46:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-12T00:17:04Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2023-09-12T21:18:04Z

Issue #26121 still reproduced mweb and apps

AndrewGable · 2023-09-12T22:07:12Z

It seems like the @expensify.sms appears in split bill scenario even after this fix, making the QA fail. I believe we should revert in this case in order to get the deploy out.

mollfpr · 2023-09-13T00:56:04Z

@pradeepmdk Could you check the above issue?

pradeepmdk · 2023-09-13T04:26:23Z

@pradeepmdk Could you check the above issue?

checking now

pradeepmdk · 2023-09-13T04:53:29Z

@AndrewGable @mollfpr I am not able to reproduce this on a split bill scenario, could you share some video/steps to reproduce it?

Note: If you have old data with the domain that will still show with the domain name only. because once you log out and log in those data will removed from Onyx Those are invalid data only so not storing in the backend.

Here we are fixing only newly added data that should not be stored with the domain name.

OSBotify · 2023-09-13T08:43:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mollfpr · 2023-09-13T10:59:15Z

I just tested it again with v1.3.68-0 and could reproduce it. In every case, we haven't made it clear in the test step to use the new invalid phone number. @kavimuru Could you share a video of the failing test?

Android

untitled.webm

mWeb/Chrome

untitled.2.webm

iOS

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-09-13.at.17.56.00.mp4

mWeb/Safari

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-09-13.at.17.56.54.mp4

kavimuru · 2023-09-13T15:43:34Z

@mollfpr This is the video for android iOS and mweb

26638_Android.1.mp4

RPReplay_Final1694519661.1.mp4

Recording__283.mp4

pradeepmdk · 2023-09-13T15:59:00Z

@kavimuru let me know which version tested the video

kavimuru · 2023-09-13T16:09:30Z

@pradeepmdk Tested on 1.3.68-9

pradeepmdk · 2023-09-13T16:14:04Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.68-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@pradeepmdk Tested on 1.3.68-9

I am not sure if this version 1.3.68-9 has our code or not. because our code is reverted now.

could you please try to check out this branch for testing?

AndrewGable · 2023-09-13T16:53:08Z

Deployed in 1.3.68-0 it was reverted in 1.3.68-16, the code was included in 1.3.68-9.

pradeepmdk · 2023-09-14T03:50:22Z

@mollfpr @AndrewGable @kavimuru I found this

First we are going to create an invalid phone number on the workspace
Go offline
Then again go to request money instead of creating a new one. selecting the failed phone number one

fixed this scenario

Untitled.mp4

remove domain name

11a6db3

pradeepmdk requested a review from a team as a code owner September 4, 2023 07:41

melvin-bot bot requested review from mollfpr and removed request for a team September 4, 2023 07:41

lint fix

830aa86

mollfpr approved these changes Sep 5, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 September 5, 2023 14:13

Li357 approved these changes Sep 7, 2023

View reviewed changes

Li357 merged commit adac19c into Expensify:main Sep 11, 2023

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

AndrewGable mentioned this pull request Sep 12, 2023

Revert "26121-remove-domain-name" #27300

Merged

57 tasks

melvin-bot bot mentioned this pull request Sep 13, 2023

[HOLD for payment 2023-09-27] [$1000] After deleting a mobile contact from a WorkSpace, it starts showing up in contacts as @expensify.sms #26121

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

26121-remove-domain-name #26638

26121-remove-domain-name #26638

pradeepmdk commented Sep 4, 2023 •

edited

Loading

melvin-bot bot commented Sep 4, 2023

mollfpr commented Sep 4, 2023 •

edited

Loading

pradeepmdk commented Sep 5, 2023

mollfpr commented Sep 5, 2023 •

edited

Loading

pradeepmdk commented Sep 5, 2023

mollfpr commented Sep 5, 2023 •

edited

Loading

mollfpr left a comment

Li357 commented Sep 11, 2023

mollfpr commented Sep 11, 2023

mollfpr commented Sep 11, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

kavimuru commented Sep 12, 2023

AndrewGable commented Sep 12, 2023

mollfpr commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

OSBotify commented Sep 13, 2023

mollfpr commented Sep 13, 2023

kavimuru commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

kavimuru commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

AndrewGable commented Sep 13, 2023

pradeepmdk commented Sep 14, 2023

26121-remove-domain-name #26638

26121-remove-domain-name #26638

Conversation

pradeepmdk commented Sep 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 4, 2023

mollfpr commented Sep 4, 2023 • edited Loading

pradeepmdk commented Sep 5, 2023

mollfpr commented Sep 5, 2023 • edited Loading

pradeepmdk commented Sep 5, 2023

mollfpr commented Sep 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

Li357 commented Sep 11, 2023

mollfpr commented Sep 11, 2023

mollfpr commented Sep 11, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

kavimuru commented Sep 12, 2023

AndrewGable commented Sep 12, 2023

mollfpr commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

OSBotify commented Sep 13, 2023

mollfpr commented Sep 13, 2023

kavimuru commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

kavimuru commented Sep 13, 2023

pradeepmdk commented Sep 13, 2023

AndrewGable commented Sep 13, 2023

pradeepmdk commented Sep 14, 2023

pradeepmdk commented Sep 4, 2023 •

edited

Loading

mollfpr commented Sep 4, 2023 •

edited

Loading

mollfpr commented Sep 5, 2023 •

edited

Loading

mollfpr commented Sep 5, 2023 •

edited

Loading