fix: Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26745

paultsimura · 2023-09-05T07:59:07Z

Details

Change the by-distance rate RegExp to allow negative numbers;
Handle values of rate <= 0 with a separate, more defined error message: "Rate must be greater than 0"

Fixed Issues

$ #26344
PROPOSAL: #26344 (comment)

Tests

Navigate to Workspace Settings;
Click on "Reimbursements" and proceed to "Track Distance" section;
Attempt to add a Track Distance rate of non-numeric format (e.g. abcd);
Attempt to add a Track Distance rate of value below zero (e.g. -1.5);
Attempt to add a Track Distance rate of value 0.00;

Verify that for non-numeric input, the "Please enter a valid rate" validation error is shown
Verify that for values <= 0, the "Rate must be greater than 0" validation error is shown
Verify that no errors appear in the JS console

Offline tests

Navigate to Workspace Settings;
Click on "Reimbursements" and proceed to "Track Distance" section;
Attempt to add a Track Distance rate of non-numeric format (e.g. abcd);
Attempt to add a Track Distance rate of value below zero (e.g. -1.5);
Attempt to add a Track Distance rate of value 0.00;

Verify that for non-numeric input, the "Please enter a valid rate" validation error is shown
Verify that for values <= 0, the "Rate must be greater than 0" validation error is shown
Verify that no errors appear in the JS console

QA Steps

Navigate to Workspace Settings;
Click on "Reimbursements" and proceed to "Track Distance" section;
Attempt to add a Track Distance rate of non-numeric format (e.g. abcd);
Attempt to add a Track Distance rate of value below zero (e.g. -1.5);
Attempt to add a Track Distance rate of value 0.00;

Verify that for non-numeric input, the "Please enter a valid rate" validation error is shown
Verify that for values <= 0, the "Rate must be greater than 0" validation error is shown
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-05T07:59:12Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-09-05T07:59:23Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

cubuspl42 · 2023-09-05T08:08:03Z

src/languages/es.js

@@ -1294,6 +1294,7 @@ export default {
            fastReimbursementsVBACopy: '¡Todo listo para reembolsar recibos desde tu cuenta bancaria!',
            updateCustomUnitError: 'Los cambios no han podido ser guardados. El espacio de trabajo ha sido modificado mientras estabas desconectado. Por favor, inténtalo de nuevo.',
            invalidRateError: 'Por favor, introduce una tarifa válida',
+            lowRateError: 'La tarifa debe ser mayor que 0',


How was this translated?

Google translate + OpenAI check.
I couldn't find a doc for the correct translation flow – is there any?

There is, in a checklist. I commented here.

Awesome I've placed the request from the checklist already.
Does the "waiting for copy" affect the 72 hours timeframe? When should we escalate the translations/copies review?

I will try to make this considered a hold

paultsimura · 2023-09-05T08:17:59Z

I have read the CLA Document and I hereby sign the CLA

cubuspl42 · 2023-09-06T07:21:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

zero-rate-web.mp4

Mobile Web - Chrome

zero-rate-android-web-compressed.mp4

Mobile Web - Safari

zero-rate-ios-web.mp4

Desktop

iOS

zero-rate-ios.mp4

Android

zero-rate-android-compressed.mp4

cubuspl42 · 2023-09-06T07:22:07Z

@marcochavezf The only thing left to figure out is the marketing approval of the copy

paultsimura · 2023-09-08T10:53:39Z

@cubuspl42 ready for the final review 🙏

cubuspl42 · 2023-09-08T13:32:49Z

@paultsimura The PR was already approved by me, I checked off the last boxes in the checklist.

marcochavezf

LGTM

OSBotify · 2023-09-11T05:07:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-12T00:18:01Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-13T08:44:28Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

allroundexperts · 2023-10-18T10:16:25Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.js

        if (!rateValueRegex.test(values.rate) || values.rate === '') {
            errors.rate = 'workspace.reimburse.invalidRateError';
+        } else if (parseFloat(values.rate) <= 0) {


Adding this caused #27595. We should have accounted for a , separator as well.

You're right, unfortunately. Thanks for pointing this out.

paultsimura requested a review from a team as a code owner September 5, 2023 07:59

melvin-bot bot requested review from cubuspl42 and removed request for a team September 5, 2023 07:59

cubuspl42 reviewed Sep 5, 2023

View reviewed changes

Add validation for rate <= 0

d896c7e

paultsimura force-pushed the fix-26344 branch from f7219f7 to d896c7e Compare September 5, 2023 19:20

cubuspl42 approved these changes Sep 6, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf September 6, 2023 07:21

Formatting

c1388d8

marcochavezf approved these changes Sep 11, 2023

View reviewed changes

marcochavezf merged commit 38c3e94 into Expensify:main Sep 11, 2023

paultsimura mentioned this pull request Sep 11, 2023

[HOLD for payment 2023-09-20] [$500] Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26344

Closed

6 tasks

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

peterdbarkerUK mentioned this pull request Sep 21, 2023

[HOLD for payment 2023-11-29] [DISTANCE] [$500] LOW: The notification in Admin is inconsistent with the error message in Reimbursements Section #27720

Closed

6 tasks

allroundexperts reviewed Oct 18, 2023

View reviewed changes

allroundexperts mentioned this pull request Oct 18, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] [iOS] - Workspace - Distance rate separator in Spanish causes errors #27595

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26745

fix: Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26745

paultsimura commented Sep 5, 2023 •

edited

Loading

melvin-bot bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023 •

edited

Loading

cubuspl42 Sep 5, 2023

paultsimura Sep 5, 2023

cubuspl42 Sep 5, 2023

paultsimura Sep 5, 2023

cubuspl42 Sep 5, 2023

paultsimura commented Sep 5, 2023

cubuspl42 commented Sep 6, 2023 •

edited

Loading

cubuspl42 commented Sep 6, 2023 •

edited

Loading

paultsimura commented Sep 8, 2023

cubuspl42 commented Sep 8, 2023

marcochavezf left a comment

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

allroundexperts Oct 18, 2023

paultsimura Oct 18, 2023

fix: Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26745

fix: Web - No Error Generated When Adding a Track Distance Rate of 0.00 #26745

Conversation

paultsimura commented Sep 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 5, 2023

github-actions bot commented Sep 5, 2023 • edited Loading

cubuspl42 Sep 5, 2023

Choose a reason for hiding this comment

paultsimura Sep 5, 2023

Choose a reason for hiding this comment

cubuspl42 Sep 5, 2023

Choose a reason for hiding this comment

paultsimura Sep 5, 2023

Choose a reason for hiding this comment

cubuspl42 Sep 5, 2023

Choose a reason for hiding this comment

paultsimura commented Sep 5, 2023

cubuspl42 commented Sep 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

cubuspl42 commented Sep 6, 2023 • edited Loading

paultsimura commented Sep 8, 2023

cubuspl42 commented Sep 8, 2023

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

allroundexperts Oct 18, 2023

Choose a reason for hiding this comment

paultsimura Oct 18, 2023

Choose a reason for hiding this comment

paultsimura commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023 •

edited

Loading

cubuspl42 commented Sep 6, 2023 •

edited

Loading

cubuspl42 commented Sep 6, 2023 •

edited

Loading