Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS migration] Migrate 'RequestThrottle.js' lib to TypeScript #24807 #26808

Merged
merged 4 commits into from
Sep 12, 2023
Merged

[TS migration] Migrate 'RequestThrottle.js' lib to TypeScript #24807 #26808

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d7ff20
Converted file from .js to .ts
arthurmfgtab Sep 5, 2023
4d19721
Converted it to ts
arthurmfgtab Sep 5, 2023
c1f534e
Use util instead of creating local helper function
arthurmfgtab Sep 11, 2023
ce0a588
Removed unnecessary return type
arthurmfgtab Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/libs/RequestThrottle.js → src/libs/RequestThrottle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,22 @@
import _ from 'underscore';
import CONST from '../CONST';
import {generateRandomInt} from './NumberUtils';

let requestWaitTime = 0;

function clear() {
function clear(): void {
requestWaitTime = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need type this one line function?

Screenshot 2023-09-11 at 15 47 24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should remove this type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, that makes sense, just did it

}

/**
* @returns {Number} time to wait in ms
*/
function getRequestWaitTime() {
if (requestWaitTime) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that getRandomInt and got one from utils as recommended here, thanks though ;)

requestWaitTime = Math.min(requestWaitTime * 2, CONST.NETWORK.MAX_RETRY_WAIT_TIME_MS);
} else {
requestWaitTime = _.random(CONST.NETWORK.MIN_RETRY_WAIT_TIME_MS, CONST.NETWORK.MAX_RANDOM_RETRY_WAIT_TIME_MS);
requestWaitTime = generateRandomInt(CONST.NETWORK.MIN_RETRY_WAIT_TIME_MS, CONST.NETWORK.MAX_RANDOM_RETRY_WAIT_TIME_MS);
}
return requestWaitTime;
}

/**
* @returns {Promise}
*/
function sleep() {
function sleep(): Promise<void> {
return new Promise((resolve) => setTimeout(resolve, getRequestWaitTime()));
}

Expand Down
Loading