Fix composer invisible text covered up the chat/report screen #26847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
narefyev91
and removed request for
a team
|
@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
narefyev91
approved these changes
Sep 6, 2023
pecanoro
approved these changes
Sep 7, 2023
|
Not merging yet since we have a feature freeze due to some conferences. I will merge on Monday. |
|
Tested (on web) and it seems to be working well, merging! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.67-0 🚀
|
6 tasks
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.67-3 🚀
|
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.68-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
On the web, we render an invisible text on the composer to calculate the caret position. However, when the text is very long, it starts to cover up the middle part of the chat screen.
Fixed Issues
$ #26535
PROPOSAL: #26535 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
text:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-06.at.11.51.02.1.mov
Mobile Web - Chrome
Screen.Recording.2023-09-06.at.11.57.30.mov
Mobile Web - Safari
Screen.Recording.2023-09-06.at.11.55.15.mov
Desktop
Screen.Recording.2023-09-06.at.11.53.45.mov
iOS
Screen.Recording.2023-09-06.at.11.58.21.mov
Android
Screen.Recording.2023-09-06.at.12.25.48.mov