Link Request Money not work #26854

akamefi202 · 2023-09-06T07:06:00Z

Updated NewRequestAmountPage to call resetMoneyRequestInfo function in the mounting.

Details

When we open NewRequestAmountPage from the link, resetMoneyRequestInfo function is called only if the user opens the page for editing.
If it's not for editing, resetMoneyRequestInfo function is not called and Onyx data for Amount page won't be initialized.
Then if the user clicks "Next" button, Amount page loads again because of missing initialization of data.

To fix this issue, I moved initialization code to outside of if (isEditing) conditional.
So resetMoneyRequestInfo function will be called when the user opens Amount page from the link and the problem is fixed.

Fixed Issues

$ #26214
PROPOSAL: #26214 (comment)

Tests

Sign in on browser as User A
Click the "+" green button icon and select Split Bill
Copy the URL in the browser (should be https://staging.new.expensify.com/split/new or https://localhost:8082/split/new) and send it to the user B
Login on browser as User B -> go to chat User A
Click on the link that user A just sent
Enter the amount and press Next
Notice the page navigates to user select page.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.2023.09.06.15.35.39.webm

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-06T07:06:05Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akamefi202 · 2023-09-07T15:09:25Z

@ArekChr Could you please review this PR any time soon?

ArekChr · 2023-09-07T19:54:46Z

Hey @akamefi202 currently I'm on RN EU conference, I will back on Monday

ArekChr · 2023-09-11T09:11:20Z

Hey @akamefi202 Looks like there is a regression, After opening the web app from split/new and logging in it doesn't open the split bill

Nagranie.z.ekranu.2023-09-11.o.11.09.19.mov

akamefi202 · 2023-09-11T10:15:59Z

@ArekChr I tested it and I think it's just a fixed bug. We created the PR 5 days ago and I think the bug was not fixed at that time.
So we see this bug when we test with request-money-link branch.
If I test with the latest main branch including current code changes, I'm not able to see this bug.
Anyway, I think this bug isn't related to current PR.

Screencast.from.2023.09.11.18.11.45.webm

ArekChr · 2023-09-12T11:09:13Z

@akamefi202, this bug seems to be linked to your recent PR. When I switch back to the main branch, everything works fine. However, the issue arises when I'm on your branch. Could you please look into fixing this regression?

Specifically, when navigating to localhost:8082/split/new and logging in, the split bill page doesn't open.

Thanks!

akamefi202 · 2023-09-12T13:01:00Z

@ArekChr I rebased request-money-link branch and the bug is fixed. Please review again.

ArekChr · 2023-09-13T09:24:52Z

@akamefi202 Could you merge with the main and retest?

akamefi202 · 2023-09-13T09:55:46Z

@ArekChr I tested it and it was working. I also rebased request-money-link branch by latest main branch.

ArekChr · 2023-09-14T08:50:40Z

@akamefi202 It seems that this problem still occurs in one case the first time after logging in.

Reproduce the steps:

Send the link http://localhost:8082/split/new in any chat.
Log out.
Log in.
Click on the link sent before.
Enter the amount and press next.
Notice that the money request reopens.
After replaying the steps, this no longer happens. until the user logs out and logs back in.

akamefi202 · 2023-09-14T09:20:36Z

@ArekChr I was not able to see the problem from my side. Could you please test again with latest request-money-link branch?
Please share record video if it's possible.

Screencast.from.2023.09.14.17.15.36.webm

ArekChr · 2023-09-14T09:56:47Z

Sure, maybe it happens when you have different currency than '$'

recording.mov

akamefi202 · 2023-09-14T13:03:03Z

@ArekChr I tested with different currency. But it was working well too. Could you please remove & pull local request-money-link branch before test?

Screencast.from.2023.09.14.20.58.30.webm

ArekChr · 2023-09-15T10:03:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.chrome.mov

Mobile Web - Safari

mweb.safari.mov

Desktop

iOS

ios.mov

Android

android.mov

ArekChr

All works now, Thanks!

akamefi202 · 2023-09-18T04:11:17Z

@thienlnam Could you please review and merge this PR soon?

thienlnam

Thanks for the ping - looks good

OSBotify · 2023-09-18T04:30:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-18T10:39:15Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

bondydaa · 2023-09-19T15:28:57Z

this was reverted on #27793

OSBotify · 2023-09-20T08:11:45Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Christinadobrzyn · 2023-09-26T20:02:34Z

Hey there! Looks like there is notice of a regression. can we review this PR to fix the regression?

#26214 (comment)

akamefi202 requested a review from a team as a code owner September 6, 2023 07:06

melvin-bot bot requested review from ArekChr and removed request for a team September 6, 2023 07:06

akamefi202 mentioned this pull request Sep 6, 2023

[HOLD for payment 2023-09-27] [$1000] Link Request Money not work #26214

Closed

6 tasks

reset money request info

f2da0c7

akamefi202 force-pushed the request-money-link branch from ac1e5c7 to f2da0c7 Compare September 12, 2023 12:24

ArekChr approved these changes Sep 15, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam September 15, 2023 10:04

thienlnam approved these changes Sep 18, 2023

View reviewed changes

thienlnam merged commit d2c8fcf into Expensify:main Sep 18, 2023

akamefi202 deleted the request-money-link branch September 18, 2023 05:11

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

bernhardoj mentioned this pull request Sep 19, 2023

[HOLD for payment 2023-09-29] [$500] Workspace details don't show up in participants selector #27510

Closed

situchan mentioned this pull request Sep 19, 2023

[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Split bill - Page freezes when attempting to create split bill #27713

Closed

6 tasks

bernhardoj mentioned this pull request Sep 19, 2023

[CP Staging] Fix empty workspace detail in money request page #27742

Merged

59 tasks

BeeMargarida mentioned this pull request Sep 19, 2023

[HOLD for payment 2023-10-02] [Wave 6: Categories] Empty categories in Money Request when creating it from FAB button #27768

Closed

6 tasks

aimane-chnaif mentioned this pull request Sep 19, 2023

[CP Staging] Revert "Link Request Money not work" #27793

Merged

58 tasks

akamefi202 restored the request-money-link branch September 19, 2023 16:28

AndrewGable mentioned this pull request Sep 20, 2023

[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] IOU - RHP does not disappear after sending a request money #27724

Closed

6 tasks

akamefi202 deleted the request-money-link branch September 21, 2023 09:45

Ollyws mentioned this pull request Oct 23, 2023

[HOLD App # 28618] Request & send money - User is redirected to Amount page from Amount page from deep link #29972

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Link Request Money not work #26854

Link Request Money not work #26854

akamefi202 commented Sep 6, 2023 •

edited

Loading

melvin-bot bot commented Sep 6, 2023

akamefi202 commented Sep 7, 2023

ArekChr commented Sep 7, 2023

ArekChr commented Sep 11, 2023

akamefi202 commented Sep 11, 2023 •

edited

Loading

ArekChr commented Sep 12, 2023

akamefi202 commented Sep 12, 2023

ArekChr commented Sep 13, 2023

akamefi202 commented Sep 13, 2023

ArekChr commented Sep 14, 2023 •

edited

Loading

akamefi202 commented Sep 14, 2023

ArekChr commented Sep 14, 2023

akamefi202 commented Sep 14, 2023

ArekChr commented Sep 15, 2023

ArekChr left a comment

akamefi202 commented Sep 18, 2023

thienlnam left a comment

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

bondydaa commented Sep 19, 2023

OSBotify commented Sep 20, 2023

Christinadobrzyn commented Sep 26, 2023

Link Request Money not work #26854

Link Request Money not work #26854

Conversation

akamefi202 commented Sep 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2023

akamefi202 commented Sep 7, 2023

ArekChr commented Sep 7, 2023

ArekChr commented Sep 11, 2023

akamefi202 commented Sep 11, 2023 • edited Loading

ArekChr commented Sep 12, 2023

akamefi202 commented Sep 12, 2023

ArekChr commented Sep 13, 2023

akamefi202 commented Sep 13, 2023

ArekChr commented Sep 14, 2023 • edited Loading

akamefi202 commented Sep 14, 2023

ArekChr commented Sep 14, 2023

akamefi202 commented Sep 14, 2023

ArekChr commented Sep 15, 2023

Reviewer Checklist

Screenshots/Videos

ArekChr left a comment

Choose a reason for hiding this comment

akamefi202 commented Sep 18, 2023

thienlnam left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

bondydaa commented Sep 19, 2023

OSBotify commented Sep 20, 2023

Christinadobrzyn commented Sep 26, 2023

akamefi202 commented Sep 6, 2023 •

edited

Loading

akamefi202 commented Sep 11, 2023 •

edited

Loading

ArekChr commented Sep 14, 2023 •

edited

Loading