-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Copy category over from expense when Editing a Money Request #27055
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
178de50
Blindly copy over category from original transaction when editing a t…
yuwenmemon 7420167
Merge main
yuwenmemon 5507bc6
Merge branch 'main' of github.com:Expensify/App into yuwen-copyCategory
yuwenmemon 9c06510
Merge branch 'main' of github.com:Expensify/App into yuwen-copyCategory
yuwenmemon 692a5ad
Get category from transaction
yuwenmemon e7df566
Update src/libs/TransactionUtils.js
yuwenmemon ab2fad1
Update src/libs/TransactionUtils.js
yuwenmemon b71fafa
Update src/libs/TransactionUtils.js
yuwenmemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this... required, we clone the original transaction at the start of this method so that would be included.
What we have to do is to add it as a param to the edit money request call and create a new getter for it and return it in the getTransactionDetails
App/src/libs/actions/IOU.js
Lines 1058 to 1071 in 67df8e9