Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Only one active deploy at a time #27399

Merged
merged 5 commits into from
Nov 8, 2023
Merged

[No QA] Only one active deploy at a time #27399

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fef335
Only one active deploy at a time
roryabraham Sep 14, 2023
83d2dbb
Skip deploy comment if workflow was cancelled
roryabraham Nov 3, 2023
b35b3ec
Merge branch 'main' into Rory-OnlyOneActiveDeploy
roryabraham Nov 3, 2023
b3712b3
Rebuild getDeployPullRequestList to look at completed deploys rather …
roryabraham Nov 3, 2023
8adb043
Use not cancelled alone instead of always
roryabraham Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ env:
SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
DEVELOPER_DIR: /Applications/Xcode_14.1.app/Contents/Developer

concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}
cancel-in-progress: true

jobs:
validateActor:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -420,7 +424,7 @@ jobs:
postGithubComment:
name: Post a GitHub comment when platforms are done building and deploying
runs-on: ubuntu-latest
if: ${{ always() }}
if: ${{ always() && !cancelled() }}
roryabraham marked this conversation as resolved.
Show resolved Hide resolved
roryabraham marked this conversation as resolved.
Show resolved Hide resolved
needs: [android, desktop, iOS, web]
steps:
- name: Checkout
Expand Down
Loading