fix: parent thread disappears in LHN when deleting the thread first chat #27410

dukenv0307 · 2023-09-14T05:06:44Z

Details

Parent thread disappears in LHN when deleting the thread first chat

Fixed Issues

$ #26791
PROPOSAL: #26791 (comment)

Tests

Open any report
Send a message
Reply in the thread of this message. Name it thread 1
In thread 1 send a message and reply in the thread of this message. Name it thread 2
In thread 2 delete the thread first chat that is the parent action of thread 2
Verify that the thread 1 is not deleted

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any report
Send a message
Reply in the thread of this message. Name it thread 1
In thread 1 send a message and reply in the thread of this message. Name it thread 2
In thread 2 delete the thread first chat that is the parent action of thread 2
Verify that the thread 1 is not deleted

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.2.mp4

Mobile Web - Safari

safari.1.mp4

Desktop

desktop.mov

iOS

ios.1.mp4

Android

android.4.mp4

melvin-bot · 2023-09-14T05:48:31Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

… first chat" This reverts commit f5cee4e.

narefyev91 · 2023-09-15T07:53:21Z

@dukenv0307 seems something happened after merging main - you got 79 file changes....

dukenv0307 · 2023-09-15T08:15:33Z

@narefyev91 sorry I just pushed the wrong code, let me try to revert it. Will ping back when it ready

…first chat

dukenv0307 · 2023-09-15T08:46:20Z

@narefyev91 Please help review the PR again

narefyev91 · 2023-09-15T09:49:25Z

@dukenv0307 issue seems not fixed on android WEB

Screen.Recording.2023-09-15.at.12.35.19.mov

second 0.51 - we have 2 items in left menu which related to current flow

When we remove 2 thread - 1.34 timing - we still see 2 items - deleted and main one - but we do not see first thread

If we open again all threads one by one - and go back (2.08) - we will see 3 of them as expected

narefyev91 · 2023-09-15T10:03:17Z

Same issue on desktop

Screen.Recording.2023-09-15.at.12.51.03.mov

narefyev91 · 2023-09-15T10:04:01Z

And also not working on native apps - if after removing item - you will click go back and not clicking on header to navigation to next screen

dukenv0307 · 2023-09-15T11:12:47Z

@narefyev91 Report number 1 ( which has a heart icon ) is moved to the bottom when we delete the thread
I believe in your case, your report goes straight to the bottom is the reason why you can not see it since you have a lot of reports in LHN.

Please check this video

Screen.Recording.2023-09-15.at.18.01.50.mp4

narefyev91 · 2023-09-15T11:21:34Z

@dukenv0307 i see - but should it be automatically not moved to the end? maybe this is an issue too - because user expect to the all items related to conversion closely to each other. And when we move again to the same thread - it will appear in the correct place

dukenv0307 · 2023-09-18T07:06:13Z

but should it be automatically not moved to the end? maybe this is an issue too - because user expect to the all items related to conversion closely to each other

@narefyev91 We sorted the report in LHN here by lastVisibleActionCreated and when we delete the last action lastVisibleActionCreated is updated in BE, so it's hard to do this.

App/src/libs/SidebarUtils.js

Line 158 in 01c5b71

    
           ? lodashOrderBy(nonArchivedReports, ['lastVisibleActionCreated', (report) => report.displayName.toLowerCase()], ['desc', 'asc'])

narefyev91 · 2023-09-18T07:25:02Z

but should it be automatically not moved to the end? maybe this is an issue too - because user expect to the all items related to conversion closely to each other

@narefyev91 We sorted the report in LHN here by lastVisibleActionCreated and when we delete the last action lastVisibleActionCreated is updated in BE, so it's hard to do this.

App/src/libs/SidebarUtils.js

Line 158 in 01c5b71

? lodashOrderBy(nonArchivedReports, ['lastVisibleActionCreated', (report) => report.displayName.toLowerCase()], ['desc', 'asc'])

Yup - but why does web working as expected in this situation? With code fix - web starts working as needed - but we have issues with other platforms...

dukenv0307 · 2023-09-18T07:30:25Z

@narefyev91 No, it works the same with other platforms, you can see in the web video in the PR the thread that has no action is moved to the end after we delete the thread first chat. Because your account has many reports in LHN and it has been moved to the end, you cannot see them in LHN. And I belive it only happens when we delete the last message of the report.

narefyev91 · 2023-09-18T08:29:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

Now nothing is disappeared. Deleted charts move to end of the LHN list. If that we expecting than
LGTM
🎀 👀 🎀 C+ reviewed

Julesssss · 2023-09-19T01:47:04Z

Yep, moving the thread lower is fine

src/libs/ReportUtils.js

OSBotify · 2023-09-19T04:22:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-20T08:45:36Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:27:31Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: parent thread disappears in LHN when deleting the thread first chat

f5cee4e

dukenv0307 marked this pull request as ready for review September 14, 2023 05:48

dukenv0307 requested a review from a team as a code owner September 14, 2023 05:48

melvin-bot bot removed the request for review from a team September 14, 2023 05:48

melvin-bot bot requested a review from narefyev91 September 14, 2023 05:48

Ollyws mentioned this pull request Sep 14, 2023

[$500] Web - The group is deleted when there are no messages or the first parent message deleted #27295

Closed

6 tasks

dukenv0307 added 2 commits September 15, 2023 09:36

fix: merge main

028c034

Revert "fix: parent thread disappears in LHN when deleting the thread…

61dd045

… first chat" This reverts commit f5cee4e.

dukenv0307 added 2 commits September 15, 2023 15:22

fix: merge main

a4e5535

fix: Chat - Parent thread disappears in LHN when deleting the thread …

889fc5f

…first chat

Merge branch 'main' into fix/26791

8b942a4

narefyev91 approved these changes Sep 18, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss September 18, 2023 08:49

Julesssss assigned dukenv0307 Sep 19, 2023

Julesssss previously approved these changes Sep 19, 2023

View reviewed changes

Julesssss reviewed Sep 19, 2023

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

dukenv0307 added 2 commits September 19, 2023 09:00

Merge branch 'main' into fix/26791

4ad51c1

merge isChildReportHasComment into shouldHideReport function

cfd1c83

dukenv0307 dismissed Julesssss’s stale review via cfd1c83 September 19, 2023 02:18

Julesssss approved these changes Sep 19, 2023

View reviewed changes

Julesssss merged commit 1c41575 into Expensify:main Sep 19, 2023
13 checks passed

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

melvin-bot bot mentioned this pull request Sep 22, 2023

[HOLD for payment 2023-09-29] [$500] Chat - Parent thread disappears in LHN when deleting the thread first chat #26791

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: parent thread disappears in LHN when deleting the thread first chat #27410

fix: parent thread disappears in LHN when deleting the thread first chat #27410

dukenv0307 commented Sep 14, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023

narefyev91 commented Sep 15, 2023

dukenv0307 commented Sep 15, 2023

dukenv0307 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

dukenv0307 commented Sep 15, 2023 •

edited

Loading

narefyev91 commented Sep 15, 2023 •

edited

Loading

dukenv0307 commented Sep 18, 2023

narefyev91 commented Sep 18, 2023

dukenv0307 commented Sep 18, 2023 •

edited

Loading

narefyev91 commented Sep 18, 2023

narefyev91 left a comment •

edited

Loading

Julesssss commented Sep 19, 2023

OSBotify commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

fix: parent thread disappears in LHN when deleting the thread first chat #27410

fix: parent thread disappears in LHN when deleting the thread first chat #27410

Conversation

dukenv0307 commented Sep 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

narefyev91 commented Sep 15, 2023

dukenv0307 commented Sep 15, 2023

dukenv0307 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

dukenv0307 commented Sep 15, 2023 • edited Loading

narefyev91 commented Sep 15, 2023 • edited Loading

dukenv0307 commented Sep 18, 2023

narefyev91 commented Sep 18, 2023

dukenv0307 commented Sep 18, 2023 • edited Loading

narefyev91 commented Sep 18, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment • edited Loading

Choose a reason for hiding this comment

Julesssss commented Sep 19, 2023

OSBotify commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

dukenv0307 commented Sep 14, 2023 •

edited

Loading

dukenv0307 commented Sep 15, 2023 •

edited

Loading

narefyev91 commented Sep 15, 2023 •

edited

Loading

dukenv0307 commented Sep 18, 2023 •

edited

Loading

narefyev91 left a comment •

edited

Loading