fix: Web - Members page search bar does not get focused #27497

dukenv0307 · 2023-09-15T07:31:47Z

Details

Fixed Issues

$ #26955
PROPOSAL: #26955 (comment)

Tests

Go to workspaces and select members
Select a few members
Verify that the search bar is focused after clicking a user on all platforms except mobile web
Click on remove button and confirm to remove the user
Verify that the search bar is focused after removing user

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to workspaces and select members
Select a few members
Verify that the search bar is focused after clicking a user on all platforms except mobile web
Click on remove button and confirm to remove the user
Verify that the search bar is focused after removing user

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-27.at.17.53.34.mov

Mobile Web - Chrome

Record_2023-09-27-17-54-48.mp4

Mobile Web - Safari

Screen.Recording.2023-09-27.at.17.57.37.mov

Desktop

Screen.Recording.2023-09-27.at.18.08.14.mov

iOS

Screen.Recording.2023-09-27.at.17.59.19.mov

Android

Screen.Recording.2023-09-27.at.18.03.52.mov

melvin-bot · 2023-09-23T00:12:54Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2023-09-26T14:25:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome-desktop-2023-09-28_17.52.33.mp4

Mobile Web - Chrome

Uploading android-chrome-new.mp4…

Mobile Web - Safari

ios-safari-2023-09-28_17.48.25.mp4

Desktop

mac-desktop-2023-09-28_17.51.48.mp4

iOS

ios-native-2023-09-28_17.49.10.mp4

Android

android-native.mp4

jjcoffee · 2023-09-26T14:29:20Z

@dukenv0307 Why don't the test steps match the original issue which was triggered when removing members?

jjcoffee · 2023-09-26T14:30:32Z

src/components/SelectionList/BaseSelectionList.js

@@ -169,6 +169,7 @@ function BaseSelectionList({
    };

    const selectRow = (item, index) => {
+        textInputRef.current.focus();


Can we guarantee that textInputRef.current will always be available in this component?

dukenv0307 · 2023-09-26T14:41:35Z

Why don't the test steps match the original issue which was triggered when removing members

@jjcoffee I believe that isn't expected when refocusing after removing members because the remove button doesn't in BaseSelectionList.

jjcoffee · 2023-09-26T14:43:21Z

@dukenv0307 So you're saying you haven't fixed the issue?

dukenv0307 · 2023-09-26T15:02:43Z

@jjcoffee In the past when we didn't use SectionList in WorkspaceMembersPage, we also didn't have the logic to refocus the text input when we removed the member so I think this case is not a bug here.
https://github.com/Expensify/App/pull/20687/files

…x/26955

dukenv0307 · 2023-09-26T15:53:06Z

@jjcoffee Any thoughts on this comment #27497 (comment)? If it is really the bug I will update the PR to fix this.

jjcoffee · 2023-09-27T08:22:33Z

@dukenv0307 I can't see any reason why we wouldn't want to refocus the input after deleting a member, just like we do after inviting a member (i.e. the second case in the linked issue that was already fixed), so that's the fix we're looking for here (you can revert your other fix if it doesn't handle this issue).

dukenv0307 · 2023-09-27T11:10:06Z

@jjcoffee I updated the test step, code, and screenshot. Please help to review again.

jjcoffee · 2023-09-27T15:29:53Z

@dukenv0307 Thanks! Is there a more generic solution here that refocuses when the delete confirmation modal closes? Ideally we'd refocus when tapping Cancel too.

dukenv0307 · 2023-09-27T16:03:40Z

@jjcoffee Update to refocus whenever the modal is closed and tested it.

jjcoffee · 2023-09-28T17:53:37Z

Having Android build issues unfortunately, so will have to finish reviewing tomorrow!

jjcoffee · 2023-09-29T13:06:28Z

@dukenv0307 Can you remove the input focus on every selection? It feels really janky to me on native devices to have the keyboard popping up every time I tick a user. Unless we have an open issue stating it as unexpected behaviour, I don't think it's worth "fixing" here.

dukenv0307 · 2023-09-29T13:14:04Z

@jjcoffee I think we can add a prop shouldFocusOnSelectRow and then pass it to decide to focus or not. On member page we can pass this prop with the value !Browser.isMobile(). That is the same way we do in MoneyRequestParticipantsSelector

jjcoffee · 2023-09-29T13:17:22Z

@dukenv0307 Okay that makes sense to me, let's do it!

dukenv0307 · 2023-09-29T13:29:39Z

@jjcoffee I just updated.

jjcoffee · 2023-10-02T13:10:19Z

@dukenv0307 The branch has conflicts.

jjcoffee · 2023-10-02T13:16:46Z

@dukenv0307 Could you also update test step 3 to include that it won't happen on mobile?

dukenv0307 · 2023-10-02T13:21:08Z

@jjcoffee Updated.

jjcoffee · 2023-10-02T13:22:21Z

@dukenv0307 Thanks! Looks like lint is failing now 😅

dukenv0307 · 2023-10-02T13:24:01Z

Just fix lint after merging main.

jjcoffee

LGTM!

OSBotify · 2023-10-02T19:21:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-03T16:09:30Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:16:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 2 commits September 15, 2023 14:21

fix: Web - Members page search bar does not get focused

0b2fbb3

Merge branch 'main' into fix/26955

d5f44f3

dukenv0307 marked this pull request as ready for review September 23, 2023 00:12

dukenv0307 requested a review from a team as a code owner September 23, 2023 00:12

melvin-bot bot requested review from jjcoffee and removed request for a team September 23, 2023 00:12

jjcoffee reviewed Sep 26, 2023

View reviewed changes

merge main

4ef8ea1

dukenv0307 added 4 commits September 26, 2023 22:05

merge main

c3f05b2

Merge branch 'fix/26955' of https://github.com/dukenv0307/App into fi…

7e9376c

…x/26955

fix lint

c4869c1

refocus on select all

6b8f1e7

dukenv0307 added 3 commits September 27, 2023 16:53

Merge branch 'main' into fix/26955

4d655cd

refocus after removing user

9b06dab

fix refocus after removing user

57876ad

dukenv0307 added 2 commits September 27, 2023 22:56

refocus whenever the modal is closed

c7943a4

merge main

4091c6d

dukenv0307 added 2 commits September 28, 2023 00:40

Merge branch 'main' into fix/26955

28f0016

add prop type to test jest

3653195

dukenv0307 added 5 commits September 29, 2023 14:38

Merge branch 'main' into fix/26955

08a5314

revert to test jest

344f5cd

refocus when confirm modal is closed

308cc3a

fix jest

ce1424c

fix/26955

a9f0545

don't refocus on select the row in mobile web

4f9a761

merge main

e56b36a

fix lint

c5c8206

jjcoffee approved these changes Oct 2, 2023

View reviewed changes

melvin-bot bot requested a review from jasperhuangg October 2, 2023 13:28

jasperhuangg approved these changes Oct 2, 2023

View reviewed changes

jasperhuangg merged commit 7dc923e into Expensify:main Oct 2, 2023
12 checks passed

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

melvin-bot bot mentioned this pull request Oct 5, 2023

[HOLD for payment 2023-10-12] [$500] Web - Members page search bar does not get focused after removing and inviting a member #26955

Closed

6 tasks

This was referenced Oct 6, 2023

[HOLD for payment 2023-10-23][$2000] Choosing group members change the search input and it's label style #22812

Closed

fix: prevent refocusing in options-selector and selection-list #29084

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Web - Members page search bar does not get focused #27497

fix: Web - Members page search bar does not get focused #27497

dukenv0307 commented Sep 15, 2023 •

edited

Loading

melvin-bot bot commented Sep 23, 2023

jjcoffee commented Sep 26, 2023 •

edited

Loading

jjcoffee commented Sep 26, 2023

jjcoffee Sep 26, 2023

dukenv0307 commented Sep 26, 2023

jjcoffee commented Sep 26, 2023

dukenv0307 commented Sep 26, 2023

dukenv0307 commented Sep 26, 2023 •

edited

Loading

jjcoffee commented Sep 27, 2023

dukenv0307 commented Sep 27, 2023

jjcoffee commented Sep 27, 2023

dukenv0307 commented Sep 27, 2023

jjcoffee commented Sep 28, 2023

jjcoffee commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

jjcoffee commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

jjcoffee commented Oct 2, 2023

jjcoffee commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023

jjcoffee commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023

jjcoffee left a comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

fix: Web - Members page search bar does not get focused #27497

fix: Web - Members page search bar does not get focused #27497

Conversation

dukenv0307 commented Sep 15, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 23, 2023

jjcoffee commented Sep 26, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Sep 26, 2023

jjcoffee Sep 26, 2023

Choose a reason for hiding this comment

dukenv0307 commented Sep 26, 2023

jjcoffee commented Sep 26, 2023

dukenv0307 commented Sep 26, 2023

dukenv0307 commented Sep 26, 2023 • edited Loading

jjcoffee commented Sep 27, 2023

dukenv0307 commented Sep 27, 2023

jjcoffee commented Sep 27, 2023

dukenv0307 commented Sep 27, 2023

jjcoffee commented Sep 28, 2023

jjcoffee commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

jjcoffee commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

jjcoffee commented Oct 2, 2023

jjcoffee commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023

jjcoffee commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

dukenv0307 commented Sep 15, 2023 •

edited

Loading

jjcoffee commented Sep 26, 2023 •

edited

Loading

dukenv0307 commented Sep 26, 2023 •

edited

Loading