Add margin between unread marker and the created action #27766

dukenv0307 · 2023-09-19T10:54:46Z

Details

Add a space between the unread marker and the special created action when this unread is the first action

Fixed Issues

$ #26015
PROPOSAL: #26015 (comment)

Tests

Login with any account
Create a task
Send a message
Mark as unread this message
Open any other report and go back (Note: this step is necessary because we have an issue with unread logic. We can remove this step after the issue 15212 is fixed)
Hover (with web and desktop) or long press (with native platform) the assignee option
Verify that we have a space 8px between the created action and unread marker

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with any account
Create a task
Send a message
Mark as unread this message
Open any other report and go back (Note: this step is necessary because we have an issue with unread logic. We can remove this step after the issue 15212 is fixed)
Hover (with web and desktop) or long press (with native platform) the assignee option
Verify that we have a space 8px between the created action and unread marker

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.19-09-2023.17.35.09.webm

Mobile Web - Chrome

Record_2023-09-19-17-36-29.mp4

Mobile Web - Safari

Screen.Recording.2023-09-19.at.17.39.35.mp4

Desktop

Screen.Recording.2023-09-19.at.17.43.39.mov

iOS

Screen.Recording.2023-09-19.at.17.41.15.mov

Android

26015.webm

melvin-bot · 2023-09-19T11:00:10Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-09-19T11:03:43Z

@allroundexperts Please ignore this PR.

allroundexperts · 2023-09-19T17:16:00Z

I think @rushatgabhane is supposed to review this.

dukenv0307 · 2023-09-21T03:33:10Z

@rushatgabhane Friendly bump.

rushatgabhane · 2023-09-25T06:44:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-10-02.at.20.00.05.mov

Desktop

iOS

Screen.Recording.2023-10-02.at.19.57.38.mov

Android

Uploading Screen Recording 2023-10-02 at 19.57.38.mov…

rushatgabhane

@dukenv0307 we're modifying a boolean variable if some conditions are true.
Let's clean this up.

Revert all code
Determine isNormalCreatedAction in the end. const isNormalCreatedAction = condition1 || condition2 ...

This will make it a one line change then. What do you think?

dukenv0307 · 2023-09-25T07:17:05Z

@rushatgabhane If we make it with one line change, we will need to call those functions one more time.

rushatgabhane · 2023-09-25T07:21:01Z

I think that's completely fine because we are improving code readability, and those functions are just doing an equality check. What do you think?

dukenv0307 · 2023-09-25T07:41:41Z

@rushatgabhane Updated.

dukenv0307 · 2023-09-26T02:34:58Z

@rushatgabhane Friendly bump.

rushatgabhane · 2023-09-26T20:46:24Z

@dukenv0307 sorry for the delay

rushatgabhane · 2023-09-26T20:46:37Z

could you please fix the merge conflicts

dukenv0307 · 2023-09-27T03:29:13Z

@rushatgabhane I just updated.

rushatgabhane · 2023-09-29T12:37:36Z

reviewing

rushatgabhane

LGTM

OSBotify · 2023-10-02T20:56:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-03T16:09:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-10-04T12:36:23Z

src/pages/home/report/ReportActionItem.js

@@ -535,15 +541,15 @@ function ReportActionItem(props) {
                );
            }

-            return (
+            content = (


This caused regression. canceled task view is overwritten by normal task view. Anyone can raise quick PR? (I can if not)

Actual Result:

Expected Result:

I will go ahead and raise PR for fixing #27874
Edit: @dukenv0307 is on it

OSBotify · 2023-10-05T00:16:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add margin between unread marker and the created action

87e4785

dukenv0307 marked this pull request as ready for review September 19, 2023 11:00

dukenv0307 requested a review from a team as a code owner September 19, 2023 11:00

melvin-bot bot requested review from allroundexperts and removed request for a team September 19, 2023 11:00

rushatgabhane suggested changes Sep 25, 2023

View reviewed changes

Merge branch 'main' into fix/26015

2e25fa9

update condition

6d75be2

dukenv0307 added 2 commits September 27, 2023 10:25

merge main

d954114

fix merge mainn

5c32682

dukenv0307 added 4 commits September 27, 2023 11:40

fix jest

180ca64

fix lint

3d1a472

merge main

cdab890

Merge branch 'main' into fix/26015

13de88f

rushatgabhane approved these changes Oct 2, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny October 2, 2023 14:11

mountiny assigned dukenv0307 Oct 2, 2023

mountiny approved these changes Oct 2, 2023

View reviewed changes

mountiny merged commit 7ec43fa into Expensify:main Oct 2, 2023
12 checks passed

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

aimane-chnaif reviewed Oct 4, 2023

View reviewed changes

aimane-chnaif mentioned this pull request Oct 4, 2023

[$500] Web - Cancel task does not show [Deleted task] view #27874

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 5, 2023

[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$250] Assign Task - No margin New marker in Task report screen #26015

Closed

6 tasks

akamefi202 mentioned this pull request Oct 24, 2023

[C+ Checklist Needs Completion] [$500] When clicking on "Mark as unread" the background image scrolls up and down unexpectedly #30218

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add margin between unread marker and the created action #27766

Add margin between unread marker and the created action #27766

dukenv0307 commented Sep 19, 2023 •

edited

Loading

melvin-bot bot commented Sep 19, 2023

dukenv0307 commented Sep 19, 2023

allroundexperts commented Sep 19, 2023

dukenv0307 commented Sep 21, 2023

rushatgabhane commented Sep 25, 2023 •

edited

Loading

rushatgabhane left a comment

dukenv0307 commented Sep 25, 2023

rushatgabhane commented Sep 25, 2023 •

edited

Loading

dukenv0307 commented Sep 25, 2023

dukenv0307 commented Sep 26, 2023

rushatgabhane commented Sep 26, 2023

rushatgabhane commented Sep 26, 2023

dukenv0307 commented Sep 27, 2023

rushatgabhane commented Sep 29, 2023

rushatgabhane left a comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

aimane-chnaif Oct 4, 2023

aimane-chnaif Oct 4, 2023 •

edited

Loading

mountiny Oct 4, 2023

OSBotify commented Oct 5, 2023

Add margin between unread marker and the created action #27766

Add margin between unread marker and the created action #27766

Conversation

dukenv0307 commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 19, 2023

dukenv0307 commented Sep 19, 2023

allroundexperts commented Sep 19, 2023

dukenv0307 commented Sep 21, 2023

rushatgabhane commented Sep 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

dukenv0307 commented Sep 25, 2023

rushatgabhane commented Sep 25, 2023 • edited Loading

dukenv0307 commented Sep 25, 2023

dukenv0307 commented Sep 26, 2023

rushatgabhane commented Sep 26, 2023

rushatgabhane commented Sep 26, 2023

dukenv0307 commented Sep 27, 2023

rushatgabhane commented Sep 29, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

aimane-chnaif Oct 4, 2023

Choose a reason for hiding this comment

aimane-chnaif Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

mountiny Oct 4, 2023

Choose a reason for hiding this comment

OSBotify commented Oct 5, 2023

dukenv0307 commented Sep 19, 2023 •

edited

Loading

rushatgabhane commented Sep 25, 2023 •

edited

Loading

rushatgabhane commented Sep 25, 2023 •

edited

Loading

aimane-chnaif Oct 4, 2023 •

edited

Loading