Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added policyID to report while creating task #27853

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Added policyID to report while creating task #27853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa1ebca
Added policyIDto report while creating task
esh-g Sep 20, 2023
3059039
Fix Lint
esh-g Sep 20, 2023
fd324b9
Merge branch 'main' into task-policy
esh-g Sep 21, 2023
cf28be0
Changed default values of policyID
esh-g Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libs/ReportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2646,12 +2646,12 @@ function buildOptimisticWorkspaceChats(policyID, policyName) {
* @param {String} parentReportID - Report ID of the chat where the Task is.
* @param {String} title - Task title.
* @param {String} description - Task description.
* @param {String | undefined} policyID - PolicyID of the parent report
* @param {String} policyID - PolicyID of the parent report
*
* @returns {Object}
*/

function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parentReportID, title, description, policyID = undefined) {
function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parentReportID, title, description, policyID = CONST.POLICY.OWNER_EMAIL_FAKE) {
return {
reportID: generateReportID(),
reportName: title,
Expand All @@ -2661,9 +2661,9 @@ function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parent
managerID: assigneeAccountID,
type: CONST.REPORT.TYPE.TASK,
parentReportID,
policyID,
stateNum: CONST.REPORT.STATE_NUM.OPEN,
statusNum: CONST.REPORT.STATUS.OPEN,
...(_.isUndefined(policyID) ? {} : {policyID}),
};
}

Expand Down
4 changes: 2 additions & 2 deletions src/libs/actions/Task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ function clearOutTaskInfo() {
* @param {String} assigneeEmail
* @param {Number} assigneeAccountID
* @param {Object} assigneeChatReport - The chat report between you and the assignee
* @param {String | undefined} policyID - the policyID of the parent report
* @param {String} policyID - the policyID of the parent report
*/
function createTaskAndNavigate(parentReportID, title, description, assigneeEmail, assigneeAccountID = 0, assigneeChatReport = null, policyID = undefined) {
function createTaskAndNavigate(parentReportID, title, description, assigneeEmail, assigneeAccountID = 0, assigneeChatReport = null, policyID = CONST.POLICY.OWNER_EMAIL_FAKE) {
const optimisticTaskReport = ReportUtils.buildOptimisticTaskReport(currentUserAccountID, assigneeAccountID, parentReportID, title, description, policyID);

const assigneeChatReportID = assigneeChatReport ? assigneeChatReport.reportID : 0;
Expand Down
Loading