[TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #27923

Skalakid · 2023-09-21T08:12:24Z

Details

Migrated PaymentUtils.js to TypeScript

Fixed Issues

$ #24889
PROPOSAL: #24889

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

blazejkustra · 2023-09-21T13:00:40Z

src/libs/PaymentUtils.ts

+import {SvgProps} from 'react-native-svg';
+import {FC} from 'react';
+// eslint-disable-next-line import/no-named-default
+import {default as BankAccountModel} from './models/BankAccount';


Suggested change

import {default as BankAccountModel} from './models/BankAccount';

import BankAccountModel from './models/BankAccount';

blazejkustra · 2023-09-21T13:01:11Z

src/libs/PaymentUtils.ts

+
+type PaymentMethod = {
+    description: string;
+    icon: FC<SvgProps>;


Suggested change

icon: FC<SvgProps>;

icon: React.FC<SvgProps>;

blazejkustra · 2023-09-21T13:13:07Z

src/libs/PaymentUtils.ts

+function getPaymentMethodDescription(accountType: AccountType, account: BankAccount['accountData'] & Fund['accountData']): string {
+    if (account) {
+        if (accountType === CONST.PAYMENT_METHODS.BANK_ACCOUNT && account?.accountNumber) {
+            return `${Localize.translateLocal('paymentMethodList.accountLastFour')} ${account?.accountNumber?.slice(-4)}`;
+        }
+        if (accountType === CONST.PAYMENT_METHODS.DEBIT_CARD) {
+            return `${Localize.translateLocal('paymentMethodList.cardLastFour')} ${account?.cardNumber?.slice(-4)}`;
+        }
+    }
+    return '';
+}


Suggested change

function getPaymentMethodDescription(accountType: AccountType, account: BankAccount['accountData'] & Fund['accountData']): string {

if (account) {

if (accountType === CONST.PAYMENT_METHODS.BANK_ACCOUNT && account?.accountNumber) {

return `${Localize.translateLocal('paymentMethodList.accountLastFour')} ${account?.accountNumber?.slice(-4)}`;

}

if (accountType === CONST.PAYMENT_METHODS.DEBIT_CARD) {

return `${Localize.translateLocal('paymentMethodList.cardLastFour')} ${account?.cardNumber?.slice(-4)}`;

}

}

return '';

}

type AccountType = BankAccount['accountType'] | Fund['accountType'];

function getPaymentMethodDescription(accountType: AccountType, account: BankAccount['accountData'] | Fund['accountData']): string {

if (account) {

if (accountType === CONST.PAYMENT_METHODS.BANK_ACCOUNT && 'accountNumber' in account) {

return `${Localize.translateLocal('paymentMethodList.accountLastFour')} ${account.accountNumber?.slice(-4)}`;

}

if (accountType === CONST.PAYMENT_METHODS.DEBIT_CARD && 'cardNumber' in account) {

return `${Localize.translateLocal('paymentMethodList.cardLastFour')} ${account.cardNumber?.slice(-4)}`;

}

}

return '';

}

blazejkustra · 2023-09-21T13:14:29Z

src/libs/PaymentUtils.ts

+/**
+ * Get the PaymentMethods list
+ */
+function formatPaymentMethods(bankAccountList: Record<string, BankAccount>, fundList: Record<string, Fund>) {


Suggested change

function formatPaymentMethods(bankAccountList: Record<string, BankAccount>, fundList: Record<string, Fund>) {

function formatPaymentMethods(bankAccountList: Record<string, BankAccount>, fundList: Record<string, Fund>): PaymentMethod[]

blazejkustra · 2023-09-21T13:14:45Z

src/libs/PaymentUtils.ts

+        const {icon, iconSize} = getBankIcon(bankAccount?.accountData?.additionalData?.bankName ?? '', false);
+        combinedPaymentMethods.push({
+            ...bankAccount,
+            description: getPaymentMethodDescription(bankAccount?.accountType as AccountType, bankAccount.accountData),


No need for assertion after changes above.

blazejkustra · 2023-09-21T13:14:49Z

src/libs/PaymentUtils.ts

+        const {icon, iconSize} = getBankIcon(card?.accountData?.bank ?? '', true);
+        combinedPaymentMethods.push({
+            ...card,
+            description: getPaymentMethodDescription(card?.accountType as AccountType, card.accountData),


No need for assertion after changes above.

blazejkustra · 2023-09-21T13:15:25Z

src/libs/PaymentUtils.ts

+
+type AccountType = 'debitCard' | 'bankAccount';
+
+type PaymentMethod = {


Suggested change

type PaymentMethod = {

type PaymentMethod = (BankAccount | Fund) & {

description: string;

icon: React.FC<SvgProps>;

iconSize: number;

};

blazejkustra · 2023-09-21T13:16:24Z

src/libs/PaymentUtils.ts

+import Fund from '../types/onyx/Fund';
+import BankAccount from '../types/onyx/BankAccount';


Change these types so that BankAccount['accountType'] is of CONST.PAYMENT_METHODS.BANK_ACCOUNT and
Fund['accountType'] is of CONST.PAYMENT_METHODS.DEBIT_CARD

melvin-bot · 2023-09-22T10:53:41Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010 · 2023-09-25T20:16:45Z

src/components/Icon/BankIcons.ts

 */

-export default function getBankIcon(bankName, isCard) {
-    const bankIcon = {
+export default function getBankIcon(bankName: string, isCard = false) {


Suggested change

export default function getBankIcon(bankName: string, isCard = false) {

export default function getBankIcon(bankName: string, isCard = false): BankIcon {

fabioh8010 · 2023-09-25T20:18:35Z

src/types/onyx/BankAccount.ts

@@ -49,7 +51,7 @@ type AccountData = {

 type BankAccount = {
    /** The bank account type */
-    accountType?: string;
+    accountType?: typeof CONST.PAYMENT_METHODS.BANK_ACCOUNT;


Is this really correct?

@Skalakid Please check it once you are back

I checked the codebase and i can't find any other string that accountType can be. Also I tested the app and all bank accounts are type of CONST.PAYMENT_METHODS.BANK_ACCOUNT. The change was suggested by @blazejkustra here. Błażej do you have any other argument why we shoudn't use string type in accountType ?

No, it's just to be precise. Not much benefits out of it 🤷

fabioh8010 · 2023-09-25T20:18:40Z

src/types/onyx/Fund.ts

 };

 type Fund = {
    accountData?: AccountData;
-    accountType?: string;
+    accountType?: typeof CONST.PAYMENT_METHODS.DEBIT_CARD;


Is this really correct?

@Skalakid Please check it once you are back

mananjadhav

Approving as per the TS migration guidelines.

melvin-bot · 2023-10-02T16:24:52Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24889 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

blazejkustra · 2023-10-03T13:05:25Z

@mananjadhav TS process was changed recently and now C+ are responsible for the reviewer checklist. Please check C+ slack channel for more info.

mananjadhav · 2023-10-03T13:09:41Z

Thanks for clarifying @blazejkustra. I realized, and I will be completing this checklist today.

mananjadhav · 2023-10-03T19:29:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-payment-utils.mov

Mobile Web - Chrome

mweb-chrome-payment-utils.mov

Mobile Web - Safari

mweb-safari-payment-utils.mov

Desktop

desktop-payment-utils.mov

iOS

ios-payment-utils.mov

Android

android-payment-utils.mov

mananjadhav · 2023-10-03T19:43:07Z

@blazejkustra @joelbettner All good from my side.

melvin-bot · 2023-10-04T19:47:41Z

@joelbettner looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-10-04T19:53:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-05T00:38:15Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T07:53:12Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:25:24Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:33:58Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:42:51Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:18:45Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Skalakid added 2 commits September 21, 2023 10:09

migrate PaymentUtils to TS

bd31bf3

Merge branch 'main' into @Skalakid/ts/PaymentUtils

e795c85

blazejkustra suggested changes Sep 21, 2023

View reviewed changes

Skalakid added 2 commits September 22, 2023 10:32

review changes

03cfe9c

Merge branch 'main' into @Skalakid/ts/PaymentUtils

e2caf02

blazejkustra approved these changes Sep 22, 2023

View reviewed changes

fix debit card icons

06376b2

Skalakid marked this pull request as ready for review September 22, 2023 10:53

Skalakid requested a review from a team as a code owner September 22, 2023 10:53

melvin-bot bot requested review from mananjadhav and removed request for a team September 22, 2023 10:53

fabioh8010 reviewed Sep 25, 2023

View reviewed changes

Skalakid added 2 commits October 2, 2023 16:38

Merge branch 'main' into @Skalakid/ts/PaymentUtils

b0d39cd

review changes

7ca844f

mananjadhav approved these changes Oct 2, 2023

View reviewed changes

melvin-bot bot requested a review from joelbettner October 2, 2023 16:24

fabioh8010 approved these changes Oct 2, 2023

View reviewed changes

joelbettner approved these changes Oct 4, 2023

View reviewed changes

joelbettner merged commit 180fd60 into Expensify:main Oct 4, 2023
11 of 14 checks passed

melvin-bot bot added the Emergency label Oct 4, 2023

OSBotify mentioned this pull request Oct 5, 2023

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed

57 tasks

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

melvin-bot bot mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-13] [TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #24889

Closed

perunt mentioned this pull request Nov 24, 2023

Optimization of mobile startup time #31776

Merged

47 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #27923

[TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #27923

Skalakid commented Sep 21, 2023 •

edited

Loading

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

blazejkustra Sep 21, 2023

melvin-bot bot commented Sep 22, 2023

fabioh8010 Sep 25, 2023

fabioh8010 Sep 25, 2023

blazejkustra Sep 26, 2023

Skalakid Oct 2, 2023 •

edited

Loading

blazejkustra Oct 2, 2023

fabioh8010 Sep 25, 2023

blazejkustra Sep 26, 2023

mananjadhav left a comment

melvin-bot bot commented Oct 2, 2023

blazejkustra commented Oct 3, 2023

mananjadhav commented Oct 3, 2023

mananjadhav commented Oct 3, 2023 •

edited

Loading

mananjadhav commented Oct 3, 2023

melvin-bot bot commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

	import {default as BankAccountModel} from './models/BankAccount';
	import BankAccountModel from './models/BankAccount';

	function formatPaymentMethods(bankAccountList: Record<string, BankAccount>, fundList: Record<string, Fund>) {
	function formatPaymentMethods(bankAccountList: Record<string, BankAccount>, fundList: Record<string, Fund>): PaymentMethod[]


		type AccountType = 'debitCard' \| 'bankAccount';

		type PaymentMethod = {

-type PaymentMethod = {
+type PaymentMethod = (BankAccount | Fund) & {
+    description: string;
+    icon: React.FC<SvgProps>;
+    iconSize: number;
+};

		import Fund from '../types/onyx/Fund';
		import BankAccount from '../types/onyx/BankAccount';

	export default function getBankIcon(bankName: string, isCard = false) {
	export default function getBankIcon(bankName: string, isCard = false): BankIcon {

[TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #27923

[TS migration] Migrate 'PaymentUtils.js' lib to TypeScript #27923

Conversation

Skalakid commented Sep 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Skalakid Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mananjadhav left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 2, 2023

blazejkustra commented Oct 3, 2023

mananjadhav commented Oct 3, 2023

mananjadhav commented Oct 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Oct 3, 2023

melvin-bot bot commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

Skalakid commented Sep 21, 2023 •

edited

Loading

Skalakid Oct 2, 2023 •

edited

Loading

mananjadhav commented Oct 3, 2023 •

edited

Loading