Fix unread marker showing double lines on task comment #28146

zukilover · 2023-09-25T14:29:02Z

Details

Changes useRef implementation for userActiveSince flag with useState to render the horizontal line correctly when a message is marked as unread on task views.

Fixed Issues

$ #26529
PROPOSAL: #26529

Tests

Click on the FAB and Assign task
Enter the task details and click Confirm task
Add a new comment to the task
Hover over the comment and mark it as unread
An unread mark should appear and the grey horizontal line should be hidden

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.webm

Mobile Web - Chrome

mweb.chrome.webm

Mobile Web - Safari

mweb.safari.mp4

Desktop

desktop.webm

iOS

ios.mp4

Android

android.webm

melvin-bot · 2023-09-25T14:29:41Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertKozik · 2023-09-27T15:21:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

iOS.-.web.mov

Desktop

desktop.mov

iOS

iOS.-.native.mov

Android

android.-.native.mov

robertKozik · 2023-09-27T15:52:27Z

I cannot make it unread on mobile chrome, could you check on your end? @zukilover

Screen.Recording.2023-09-27.at.17.51.02.mov

robertKozik · 2023-09-27T16:04:43Z

On first run (fe. after reloading app) we can ancounter the warning after amking message unread

warning.mov

robertKozik · 2023-09-29T12:55:04Z

@zukilover kindly bump

zukilover · 2023-09-29T13:58:30Z

Hi, I'll check it out shortly. @robertKozik

zukilover · 2023-09-29T22:41:56Z

@robertKozik I can make it unread on Android Chrome:

android.chrome.webm

zukilover · 2023-09-29T23:55:35Z

I have fixed the warning on app @robertKozik.

android.webm

robertKozik · 2023-10-01T21:41:35Z

Thanks will continue review on monday 😉

robertKozik

LGTM

melvin-bot · 2023-10-03T08:35:44Z

🎯 @robertKozik, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28692.

melvin-bot · 2023-10-07T00:05:57Z

@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-10-07T00:11:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-09T23:01:55Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jasperhuangg · 2023-10-10T19:52:25Z

@zukilover this PR was reverted becuase of #29160. Please correct your PR and submit a new one, thanks!

OSBotify · 2023-10-11T04:42:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T05:11:06Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

zukilover · 2023-10-11T13:53:36Z

@jasperhuangg @robertKozik new PR ready for review: #29314

OSBotify · 2023-10-13T22:00:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:12:14Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:28:27Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:03:52Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:15:32Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:51:52Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix unread marker showing double lines on task comment

4f2d8c2

zukilover requested a review from a team as a code owner September 25, 2023 14:29

zukilover mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-10-25] [$500] Web - The horizontal line separating the header and the messages in the IOU report room disappears and reappears irregularly #26529

Closed

6 tasks

melvin-bot bot requested review from Julesssss and removed request for a team September 25, 2023 14:29

Fix unit test for unread marker

249cd27

Julesssss assigned zukilover Sep 26, 2023

Julesssss requested a review from robertKozik September 26, 2023 05:16

zukilover added 3 commits September 30, 2023 06:35

Refactor unread marker effect

db64659

Resolve conflict

a1c06dd

Merge branch 'main' into webfix/26529-unread-task

b772708

Merge branch 'main' into webfix/26529-unread-task

41d6629

robertKozik approved these changes Oct 3, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Oct 3, 2023

Payment issue for E/App PR#28146 #28692

Closed

Resolve conflicts

49ca73a

deetergp approved these changes Oct 7, 2023

View reviewed changes

deetergp merged commit 168e7f7 into Expensify:main Oct 7, 2023
11 checks passed

melvin-bot bot added the Emergency label Oct 7, 2023

tienifr mentioned this pull request Oct 9, 2023

fix: 27963 Dev: Web - Console error after create new account #28996

Closed

59 tasks

deetergp removed the Emergency label Oct 9, 2023

mananjadhav mentioned this pull request Oct 9, 2023

[$500] Dev: Web - Console error after create new account #27963

Closed

6 tasks

OSBotify mentioned this pull request Oct 9, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

hungvu193 mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-18] [$500] Chat - Green line only appears on the first message marked as unread until the chat is reloaded #29160

Closed

6 tasks

aimane-chnaif mentioned this pull request Oct 10, 2023

Revert "Fix unread marker showing double lines on task comment" #29189

Merged

58 tasks

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix unread marker showing double lines on task comment #28146

Fix unread marker showing double lines on task comment #28146

zukilover commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

robertKozik commented Sep 27, 2023 •

edited

Loading

robertKozik commented Sep 27, 2023

robertKozik commented Sep 27, 2023

robertKozik commented Sep 29, 2023

zukilover commented Sep 29, 2023

zukilover commented Sep 29, 2023

zukilover commented Sep 29, 2023

robertKozik commented Oct 1, 2023

robertKozik left a comment

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 7, 2023

OSBotify commented Oct 7, 2023

OSBotify commented Oct 9, 2023

jasperhuangg commented Oct 10, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

zukilover commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

Fix unread marker showing double lines on task comment #28146

Fix unread marker showing double lines on task comment #28146

Conversation

zukilover commented Sep 25, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 25, 2023

robertKozik commented Sep 27, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

robertKozik commented Sep 27, 2023

robertKozik commented Sep 27, 2023

robertKozik commented Sep 29, 2023

zukilover commented Sep 29, 2023

zukilover commented Sep 29, 2023

zukilover commented Sep 29, 2023

robertKozik commented Oct 1, 2023

robertKozik left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 7, 2023

OSBotify commented Oct 7, 2023

OSBotify commented Oct 9, 2023

jasperhuangg commented Oct 10, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

zukilover commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

robertKozik commented Sep 27, 2023 •

edited

Loading