Hide replace option for the request that cannot edit #28373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer Checklist
Screenshots/VideosWeb28373-web.movMobile Web - Chrome28373-web-chrome.movMobile Web - Safari28373-web-safari.movDesktop28373-desktop.moviOS28373-ios.movAndroid28373-android.mov |
|
@dukenv0307 I successfully tested on web but I'm struggling with other devices (ios and android so far) - I'm getting some errors while trying to request money using scan - please take a look at the video below: Screen.Recording.2023-09-29.at.13.15.00.movI guess it may not be related to your changes but can you take a look? Maybe syncing with main will help? |
|
@burczu This is an Onyx issue. Please merge the newest main and npm i again. |
|
@Li357 Please help to review the PR when you have a chance. |
Li357
approved these changes
Oct 4, 2023
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
57 tasks
|
🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.78-0 🚀
|
dukenv0307
commented
Oct 5, 2023
| icon: Expensicons.Camera, | ||
| text: props.translate('common.replace'), | ||
| onSelected: () => { | ||
| onModalHideCallbackRef.current = () => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.RECEIPT)); |
6 tasks
mountiny
removed
the
DeployBlockerCash
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀
|
|
🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.79-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
| }); | ||
| return menuItems; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isAttachmentReceipt, props.parentReport, props.parentReportActions, props.policy]); |
There was a problem hiding this comment.
file dependency was missing here. It's needed to re-calculate downloadAttachment function as it's inside menuItems' onSelected call.
It caused #30616
6 tasks
Comment on lines
+356
to
+360
| menuItems.push({ | ||
| icon: Expensicons.Download, | ||
| text: props.translate('common.download'), | ||
| onSelected: () => downloadAttachment(source), | ||
| }); |
There was a problem hiding this comment.
We shouldn't show download button when offline attachments are not available when offline
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We hide replace option in attachment modal of receipt if the request cannot be edited
Fixed Issues
$ #27965
PROPOSAL: #27965 (comment)
Tests
Offline tests
None
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-28.at.15.24.07.mov
Mobile Web - Chrome
Screen.Recording.2023-09-28.at.15.32.50.mov
Mobile Web - Safari
Screen.Recording.2023-09-28.at.15.36.47.mov
Desktop
Screen.Recording.2023-09-28.at.16.32.38.mov
iOS
Screen.Recording.2023-09-28.at.16.02.53.mov
Android
27965.webm