-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][TS migration] Migrate 'Welcome.js' lib to TypeScript #28381
Merged
hayata-suenaga
merged 9 commits into
Expensify:main
from
fvlvte:24908-migrate-welcome-lib
Oct 27, 2023
Merged
[No QA][TS migration] Migrate 'Welcome.js' lib to TypeScript #28381
hayata-suenaga
merged 9 commits into
Expensify:main
from
fvlvte:24908-migrate-welcome-lib
Oct 27, 2023
Commits on Oct 19, 2023
-
Migrated Welcome.js to TypeScript.
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for a691d7e - Browse repository at this point
Copy the full SHA a691d7eView commit details -
Requested changes implemented.
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for 5127257 - Browse repository at this point
Copy the full SHA 5127257View commit details -
Requested changes implemented + prettier.
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for 220991b - Browse repository at this point
Copy the full SHA 220991bView commit details -
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for c5a2f2b - Browse repository at this point
Copy the full SHA c5a2f2bView commit details -
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for 2258f1f - Browse repository at this point
Copy the full SHA 2258f1fView commit details -
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for bdd1841 - Browse repository at this point
Copy the full SHA bdd1841View commit details -
Graceful handling of last array element.
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for f973331 - Browse repository at this point
Copy the full SHA f973331View commit details -
Requested change on Welcome.ts
Co-authored-by: Hayata Suenaga <hayata@expensify.com> Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
Configuration menu - View commit details
-
Copy full SHA for 69b495a - Browse repository at this point
Copy the full SHA 69b495aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e651ba3 - Browse repository at this point
Copy the full SHA e651ba3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.