Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA][TS migration] Migrate 'Welcome.js' lib to TypeScript #28381

Merged
merged 9 commits into from
Oct 27, 2023
Merged

[No QA][TS migration] Migrate 'Welcome.js' lib to TypeScript #28381

merged 9 commits into from
Oct 27, 2023

Commits on Oct 19, 2023

  1. Migrated Welcome.js to TypeScript. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a691d7e View commit details
    Browse the repository at this point in the history

  2. Requested changes implemented. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5127257 View commit details
    Browse the repository at this point in the history

  3. Requested changes implemented + prettier. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    220991b View commit details
    Browse the repository at this point in the history

  4. Solved comments. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c5a2f2b View commit details
    Browse the repository at this point in the history

  5. Renamed val -> value. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    2258f1f View commit details
    Browse the repository at this point in the history

  6. Resolved comment. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    bdd1841 View commit details
    Browse the repository at this point in the history

  7. Graceful handling of last array element. 

    Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f973331 View commit details
    Browse the repository at this point in the history

  8. Requested change on Welcome.ts 

    Co-authored-by: Hayata Suenaga <hayata@expensify.com>
Signed-off-by: Kacper Falat <kacper.falat@callstack.com>
    @fvlvte
    fvlvte and Hayata Suenaga committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    69b495a View commit details
    Browse the repository at this point in the history

  9. Rebased and resigned old commit tree.

    @fvlvte
    fvlvte committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e651ba3 View commit details
    Browse the repository at this point in the history