Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] Update Lyft.md #28429

Merged
merged 10 commits into from
Oct 4, 2023
Merged

[NoQA] Update Lyft.md #28429

merged 10 commits into from
Oct 4, 2023

Conversation

miljakljajic
Copy link
Contributor

@miljakljajic miljakljajic commented Sep 29, 2023

Updated to add the relevant photos from the image repo

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/311465
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

No QA

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors
  • I followed proper code patterns
    • I verified callback methods are named for what the method does and not what callback they handle
    • I verified that the left part of a conditional rendering a React component is a boolean and not a string
    • I verified that comments were added to code that is not self explanatory
    • I verified any new or modified comments were clear and in correct English
    • I verified any copy / text shown in the product is localized
    • I verified all numbers, amounts, dates and phone numbers are using the localization methods
    • I verified any copy / text added to the app is grammatically correct in English
    • I verified proper file naming conventions were followed
    • I verified the JSDocs style guidelines were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes
  • I verified all code is DRY
  • I verified any variables that can be defined as constants are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a comment above it
    • The file is named correctly
    • The component has a clear name that is non-ambiguous
    • The only data being stored in the state is data necessary for rendering
    • Proper selector is added to ensure the component only re-renders when necessary
    • Any internal methods passed to components event handlers are bound to this properly
    • All JSX used for rendering exists in the render method
    • The component is broken down into smaller components to separate concerns
  • If any new file was added I verified that:
    • The file has a description at the top if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps
  • I have checked off every checkbox in the PR author checklist

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

Updated to add the relevant photos from the image repo
@miljakljajic miljakljajic requested a review from a team as a code owner September 29, 2023 05:07
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from yuwenmemon and removed request for a team September 29, 2023 05:07
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ns/Lyft.md

Co-authored-by: Yuwen Memon <yuwen@expensify.com>
@rushatgabhane
Copy link
Member

@miljakljajic this is what we want

  1. remove comments <--- --->
  2. the ## shouldn't have a space in between
  3. Add title and description that will be shown in social media links when this article is shared
---
title: Lyft Integration
description: add appropriate description here to be used for SEO
---

# Overview
You can link Expensify directly to your Lyft account. This means that your receipts for work-related Lyft rides will populate automatically in Expensify. 

# How to connect a Lyft Business profile for individual use
If you use Lyft for work, you can connect your business profile to Expensify to have your Business-related trips populate directly in your Expensify account.
1. Open the Lyft mobile app and tap your profile photo in the upper left. 
4. Go to Settings.
5. Select Business profile, and create one if you don’t already have one. 
6. Tap Expense management and choose Expensify. You'll be asked to enter your email, make sure it matches the email you use to access Expensify.
You're all set! Switch into business profile mode each time you take a ride for work, and your receipts will automatically populate in Expensify. 


## How to set up Lyft for Business
If you have a Lyft for Business account for your company, setting up the Expensify and Lyft integration for your whole team is very straightforward:
1. Open your Lyft for Business portal from a web browser.
2. Navigate to People > Business Profile (+) and input each team member's work email.
3. Once invited, each employee will receive an email prompting Lyft Business Profile setup. 
4. After they set up their profiles, employees can then switch into business profile mode each time they take a ride for work, and their receipts will automatically populate in Expensify.
When any employee completes a ride on a Lyft Business Profile, it will show up in the "Rides" section of your Lyft for Business portal.


![Alt text for accessibility]
(https://help.expensify.com/assets/images/ExpensifyHelp_Lyft_01.png){:width="100%"}

@miljakljajic
Copy link
Contributor Author

made the suggested updates!

…ns/Lyft.md

Co-authored-by: Yuwen Memon <yuwen@expensify.com>
@yuwenmemon
Copy link
Contributor

@yuwenmemon
Copy link
Contributor

Also, can you find another reviewer? I'm headed out on sabbatical! (Also you need to fill out the checklist 😉)

@francoisl francoisl self-requested a review October 2, 2023 18:13
…ns/Lyft.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
@miljakljajic
Copy link
Contributor Author


I have read the CLA Document and I hereby sign the CLA


…ns/Lyft.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
Comment on lines 26 to 27
![Alt text for accessibility]
(https://help.expensify.com/assets/images/ExpensifyHelp_Lyft_01.png){:width="100%"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's supposed to be a new image committed in this PR as well? This one doesn't seem to exist in the repo yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be up soon: #28425

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the caption on the file in miljakljajic-patch-4

miljakljajic and others added 2 commits October 4, 2023 09:28
…ns/Lyft.md

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
Made the suggested updates to the Lyft photo caption
@miljakljajic
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

…ns/Lyft.md

Co-authored-by: Francois Laithier <francois@expensify.com>
@francoisl
Copy link
Contributor

@miljakljajic why did you make another pull request for the same file at the same time?

This branch looks good as it stands, but now there's a conflict because of that other PR that was just merged.

@francoisl
Copy link
Contributor

The text looks mostly the same (except the last sentence and the page title/description), I'll help resolve the conflicts. We'll use the existing copy from main and just add the image.

@francoisl
Copy link
Contributor

francoisl commented Oct 4, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

Copy link
Contributor

@francoisl francoisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with the image at the bottom (ignore the messy left panel, it's because I made a panoramic screenshot)

image

@francoisl francoisl merged commit 66aeeef into main Oct 4, 2023
15 checks passed
@francoisl francoisl deleted the miljakljajic-patch-4 branch October 4, 2023 21:35
@francoisl francoisl changed the title Update Lyft.md [NoQA] Update Lyft.md Oct 4, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.78-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.79-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants