-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: room name field does not automatically focus when returning from the chat option #28646
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1a80a9e
implement a hook to delay auto focus on text inputs
akinwale f7b8659
change default delay for the useDelayedInputFocus hook
akinwale 0a9d3e4
fix merge conflict
akinwale 574b648
use component-specific delay value for room name input
akinwale 7be57f5
parameter cleanup
akinwale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import {useCallback, useRef} from 'react'; | ||
import {useFocusEffect} from '@react-navigation/native'; | ||
import CONST from '../CONST'; | ||
|
||
/** | ||
* Focus a text input when a screen is navigated to, after the specified time delay has elapsed. | ||
* | ||
* @param {Object} inputRef | ||
* @param {Number} [delay] | ||
*/ | ||
export default function useDelayedInputFocus(inputRef, delay = CONST.ANIMATED_TRANSITION) { | ||
const timeoutRef = useRef(null); | ||
|
||
useFocusEffect( | ||
useCallback(() => { | ||
timeoutRef.current = setTimeout(() => inputRef.current && inputRef.current.focus(), delay); | ||
return () => { | ||
if (!timeoutRef.current) { | ||
return; | ||
} | ||
clearTimeout(timeoutRef.current); | ||
}; | ||
}, [delay, inputRef]), | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akinwale Is there a particular reason for 600ms timing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#28646 (comment)