Fix: emoji picker hides on resize window #28688

shubham1206agra · 2023-10-03T07:49:24Z

Details

Fixed Issues

$ #21560
PROPOSAL: #21560 (comment)

Tests

Go to any chat
Open emoji picker
Resize window (<800)
Resize the window to a wider view

Verify that no errors appear in the JS console
Verify that the emoji picker remains open at steps 3 and 4

Additional Test

Go to any chat
Open ReportActionContextMenu for any message
Resize window (<800)
Close the Menu
Reopen the menu for the same message in step 2
Resize the window to a wider view

Verify that no errors appear in the JS console
Verify that the emoji picker remains open at steps 3 and 6

Offline Tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-03.at.1.12.18.PM.mov

Mobile Web - Chrome

NA

Mobile Web - Safari

NA

Desktop

Screen.Recording.2023-10-03.at.1.22.27.PM.mov

iOS

NA

Android

NA

melvin-bot · 2023-10-03T07:49:29Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-10-03T07:49:52Z

@abdulrahuman5196 You can start review

abdulrahuman5196

I am supposed to take over this PR since I had approved the proposal on issue.
@narefyev91 Sorry for the confusion.

Just commenting to get this issue into my K2

abdulrahuman5196 · 2023-10-03T13:47:56Z

@shubham1206agra Offline tests are missing in author's checklist.

shubham1206agra · 2023-10-03T13:50:38Z

Updated

abdulrahuman5196 · 2023-10-03T14:02:45Z

@shubham1206agra Even though the issue is specific to web/desktop. The changes are still made in index.js files which could indirectly affect safari and chrome mobile as well. We have to test and make sure nothing breaks there and add videos in the author's checklist on the same.

shubham1206agra · 2023-10-03T14:04:52Z

@shubham1206agra Even though the issue is specific to web/desktop. The changes are still made in index.js files which could indirectly affect safari and chrome mobile as well. We have to test and make sure nothing breaks there and add videos in the author's checklist on the same.

How would we test mobile?
We can't resize there

abdulrahuman5196 · 2023-10-03T14:07:26Z

@shubham1206agra Even though the issue is specific to web/desktop. The changes are still made in index.js files which could indirectly affect safari and chrome mobile as well. We have to test and make sure nothing breaks there and add videos in the author's checklist on the same.

How would we test mobile? We can't resize there

@shubham1206agra Not needed to test the issue specifically(If the issue is not directly applicable on mobile). Just need to make sure popover opens normally there and we don't see any crashes or abnormal behaviour there should be fine.

This is to make sure we don't break anything else unknowingly.

abdulrahuman5196 · 2023-10-03T14:22:10Z

@shubham1206agra

Occasionally I am seeing the window getting closed. Not sure on the pattern. Could you check on the video attached?

Screen.Recording.2023-10-03.at.7.48.42.PM.mp4

shubham1206agra · 2023-10-04T06:24:23Z

@abdulrahuman5196 Can you confirm this behaviour on Safari?

abdulrahuman5196 · 2023-10-04T06:27:22Z

@abdulrahuman5196 Can you confirm this behaviour on Safari?

I don't understand this. Do you mean web safari? For any specific reason?

shubham1206agra · 2023-10-04T06:28:38Z

Wait
Let me try to first fix this
I may have found the problem

shubham1206agra · 2023-10-04T07:19:58Z

@abdulrahuman5196 Can you test this now?
I have also added additional test

abdulrahuman5196 · 2023-10-04T07:26:25Z

@shubham1206agra Could you provide some information on the fix made for the issue? I am not able to understand the fix?

shubham1206agra · 2023-10-04T07:31:28Z

When we open any popover in the larger view, the PopoverContextProvider stores the ref. But when we go to the smaller view and dismiss the popover, it does not run closePopover, which clears the ref, and when we go to the larger view again, we see the same problem with unequal refs.

shubham1206agra · 2023-10-04T12:20:46Z

@abdulrahuman5196 Can you complete the review today itself please?

abdulrahuman5196 · 2023-10-04T12:21:46Z

Yes will re-review tonight, just closing a deployment blocker. If not other issue, it should be good.

abdulrahuman5196 · 2023-10-04T15:28:40Z

Reviewing now

abdulrahuman5196 · 2023-10-04T15:59:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-04.at.9.01.18.PM.mp4

Mobile Web - Chrome

az_recorder_20231004_210919.mp4

Mobile Web - Safari

Screen.Recording.2023-10-04.at.9.06.23.PM.mp4

Desktop

Screen.Recording.2023-10-04.at.9.21.33.PM.mp4

iOS

Screen.Recording.2023-10-04.at.9.11.02.PM.mp4

Android

az_recorder_20231004_211613.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

mountiny

Thank you!

OSBotify · 2023-10-04T20:41:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-05T00:38:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T07:53:09Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:25:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:33:55Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:42:48Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:18:42Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix popover for resizing

ec50dce

shubham1206agra requested a review from a team as a code owner October 3, 2023 07:49

melvin-bot bot requested review from narefyev91 and removed request for a team October 3, 2023 07:49

abdulrahuman5196 reviewed Oct 3, 2023

View reviewed changes

mountiny assigned shubham1206agra Oct 3, 2023

Merge branch 'Expensify:main' into fix-popover

dbc7c9f

fix proper closing of popover context

b7d6470

abdulrahuman5196 approved these changes Oct 4, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny October 4, 2023 16:02

mountiny approved these changes Oct 4, 2023

View reviewed changes

mountiny merged commit ef30730 into Expensify:main Oct 4, 2023
16 checks passed

OSBotify mentioned this pull request Oct 5, 2023

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed

57 tasks

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

melvin-bot bot mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-13] [$500] Web - emoji picker hides on resize window #21560

Closed

6 tasks

shubham1206agra deleted the fix-popover branch February 6, 2024 03:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: emoji picker hides on resize window #28688

Fix: emoji picker hides on resize window #28688

shubham1206agra commented Oct 3, 2023 •

edited

Loading

melvin-bot bot commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023

abdulrahuman5196 left a comment

abdulrahuman5196 commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023

abdulrahuman5196 commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 3, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 3, 2023

shubham1206agra commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023 •

edited

Loading

abdulrahuman5196 left a comment

mountiny left a comment

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

Fix: emoji picker hides on resize window #28688

Fix: emoji picker hides on resize window #28688

Conversation

shubham1206agra commented Oct 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Additional Test

Offline Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023

abdulrahuman5196 commented Oct 3, 2023

shubham1206agra commented Oct 3, 2023 • edited Loading

abdulrahuman5196 commented Oct 3, 2023 • edited Loading

abdulrahuman5196 commented Oct 3, 2023

shubham1206agra commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023 • edited Loading

abdulrahuman5196 commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

shubham1206agra commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

shubham1206agra commented Oct 3, 2023 •

edited

Loading

shubham1206agra commented Oct 3, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 3, 2023 •

edited

Loading

shubham1206agra commented Oct 4, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 4, 2023 •

edited

Loading