-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: auto focus and scroll to bottom on large-text in composer #28790
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
adc3aee
fix: auto focus and scroll to bottom on large-text in composer
jeet-dhandha 72bb8a2
changed shouldAutoFocus to autoFocusCheck in Composer
jeet-dhandha 3828277
updated name for flag and fixed callback dependencies
jeet-dhandha f070f8b
removed extra code
jeet-dhandha f189981
removed InteractionManager as it was creating a janky animation
jeet-dhandha 23ff678
Updated comments and variable name for better understanding
jeet-dhandha 2dafa3f
remove unnecessary code.
jeet-dhandha d79641a
removed `focusWithScrolledToBottom`
jeet-dhandha 317d060
fix: remove extra code and handle web scroll to bottom
jeet-dhandha 5b2d7b9
Merge branch 'main' into fix-27153
jeet-dhandha 82778ee
removed extra useEffect and extra checks
jeet-dhandha 8972e44
updated checks
jeet-dhandha fbb9dac
Merge branch 'main' into fix-27153
jeet-dhandha 1fbbbb0
Update src/pages/home/report/ReportActionCompose/ComposerWithSuggesti…
jeet-dhandha ce44e6e
Merge branch 'main' into fix-27153
jeet-dhandha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why we need to force focus here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js
Line 535 in f070f8b
If you check above line of code we are disabling autoFocus as we wan't to focus manually after scrollHeight and selection are updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So without that, the selection wouldn't be set to the end, is that what you mean? Or what side-effect is there if we don't add that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2023-10-06.at.3.10.04.PM.mov
Without that Composer won't get Focused. As you can see the Cursor isn't there in the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this still isn't really making sense to me. If I remove your change to
autoFocus
and just have a simpleuseEffect
that runsupdateMultilineInputRange
, it works fine (on desktop at least). I'm struggling to understand the reason why all this extra logic is necessary here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check out my video @jjcoffee ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets have a quick chat in Slack here its harder to chat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeet-dhandha Yes, is that with
autoFocus
set back toshouldAutoFocus
? I don't get the same behaviour if so...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue also doesn't show any problem with focusing on the composer. That's why I'm quite sceptical about adding extra focus calls here!